[multiple changes]

2014-01-31  Robert Dewar  <dewar@adacore.com>

	* exp_ch9.adb, s-tassta.adb, s-tposen.adb, s-tposen.ads: Minor
	reformatting.

2014-01-31  Tristan Gingold  <gingold@adacore.com>

	* exp_disp.adb: Add a historic note.

2014-01-31  Robert Dewar  <dewar@adacore.com>

	* sem_warn.adb (Warn_On_Useless_Assignments): Add call to
	Process_Deferred_References.

2014-01-31  Yannick Moy  <moy@adacore.com>

	* erroutc.adb (Validate_Specific_Warnings): Do not issue a message for
	ineffective pragma Warnings(Off) in GNATprove_Mode.

From-SVN: r207351

gcc/ada/ChangeLog

+2014-01-31  Robert Dewar  <dewar@adacore.com>
+
+	* exp_ch9.adb, s-tassta.adb, s-tposen.adb, s-tposen.ads: Minor
+	reformatting.
+
+2014-01-31  Tristan Gingold  <gingold@adacore.com>
+
+	* exp_disp.adb: Add a historic note.
+
+2014-01-31  Robert Dewar  <dewar@adacore.com>
+
+	* sem_warn.adb (Warn_On_Useless_Assignments): Add call to
+	Process_Deferred_References.
+
+2014-01-31  Yannick Moy  <moy@adacore.com>
+
+	* erroutc.adb (Validate_Specific_Warnings): Do not issue a message for
+	ineffective pragma Warnings(Off) in GNATprove_Mode.
+
 2014-01-31  Bob Duff  <duff@adacore.com>
 
 	* s-taskin.ads: Minor comment fix.

gcc/ada/erroutc.adb

@@ -1318,6 +1318,13 @@ package body Erroutc is
 
                elsif not SWE.Used
 
+                 --  Do not issue this warning in GNATprove_Mode, as not
+                 --  all warnings may be generated in this mode, and pragma
+                 --  Warnings(Off) may correspond to warnings generated by the
+                 --  formal verification backend instead of frontend warnings.
+
+                 and then not GNATprove_Mode
+
                  --  Do not issue this warning for -Wxxx messages since the
                  --  back-end doesn't report the information.
 

gcc/ada/exp_disp.adb

@@ -3522,6 +3522,13 @@ package body Exp_Disp is
             --  the wrapped parameters, D is the delay amount, M is the delay
             --  mode and F is the status flag.
 
+            --  Historically, there was also an implementation for single
+            --  entry protected types (in s-tposen). However, it was removed
+            --  by also testing for no No_Select_Statements restriction in
+            --  Exp_Utils.Corresponding_Runtime_Package. This simplified the
+            --  implementation of s-tposen, which was initially created for
+            --  the Ravenscar profile.
+
             case Corresponding_Runtime_Package (Conc_Typ) is
                when System_Tasking_Protected_Objects_Entries =>
                   Append_To (Stmts,

gcc/ada/s-tassta.adb

@@ -150,14 +150,14 @@ package body System.Tasking.Stages is
       C : Task_Id;
       P : Task_Id;
 
-      --  Each task C will take care of its own dependents, so there is no need
-      --  to worry about them here. In fact, it would be wrong to abort
+      --  Each task C will take care of its own dependents, so there is no
+      --  need to worry about them here. In fact, it would be wrong to abort
       --  indirect dependents here, because we can't distinguish between
-      --  duplicate master ids. For example, suppose we have three nested task
-      --  bodies T1,T2,T3. And suppose T1 also calls P which calls Q (and both
-      --  P and Q are task masters). Q will have the same master id as
-      --  Master_of_Task of T3. Previous versions of this would abort T3 when Q
-      --  calls Complete_Master, which was completely wrong.
+      --  duplicate master ids. For example, suppose we have three nested
+      --  task bodies T1,T2,T3. And suppose T1 also calls P which calls Q (and
+      --  both P and Q are task masters). Q will have the same master id as
+      --  Master_of_Task of T3. Previous versions of this would abort T3 when
+      --  Q calls Complete_Master, which was completely wrong.
 
    begin
       C := All_Tasks_List;

gcc/ada/s-tposen.adb

@@ -54,7 +54,7 @@ pragma Style_Checks (All_Checks);
 
 pragma Polling (Off);
 --  Turn off polling, we do not want polling to take place during tasking
---  operations. It can cause  infinite loops and other problems.
+--  operations. It can cause infinite loops and other problems.
 
 pragma Suppress (All_Checks);
 --  Why is this required ???
@@ -84,10 +84,9 @@ package body System.Tasking.Protected_Objects.Single_Entry is
 
    procedure Wakeup_Entry_Caller (Entry_Call : Entry_Call_Link);
    pragma Inline (Wakeup_Entry_Caller);
-   --  This is called at the end of service of an entry call,
-   --  to abort the caller if he is in an abortable part, and
-   --  to wake up the caller if he is on Entry_Caller_Sleep.
-   --  Call it holding the lock of Entry_Call.Self.
+   --  This is called at the end of service of an entry call, to abort the
+   --  caller if he is in an abortable part, and to wake up the caller if he
+   --  is on Entry_Caller_Sleep. Call it holding the lock of Entry_Call.Self.
 
    procedure Wait_For_Completion (Entry_Call : Entry_Call_Link);
    pragma Inline (Wait_For_Completion);
@@ -100,17 +99,16 @@ package body System.Tasking.Protected_Objects.Single_Entry is
      (Self_ID : Task_Id;
       Entry_Call : Entry_Call_Link);
    pragma Inline (Check_Exception);
-   --  Raise any pending exception from the Entry_Call.
-   --  This should be called at the end of every compiler interface procedure
-   --  that implements an entry call.
-   --  The caller should not be holding any locks, or there will be deadlock.
+   --  Raise any pending exception from the Entry_Call. This should be called
+   --  at the end of every compiler interface procedure that implements an
+   --  entry call. The caller should not be holding any locks, or there will
+   --  be deadlock.
 
    procedure PO_Do_Or_Queue
      (Object     : Protection_Entry_Access;
       Entry_Call : Entry_Call_Link);
-   --  This procedure executes or queues an entry call, depending
-   --  on the status of the corresponding barrier. It assumes that the
-   --  specified object is locked.
+   --  This procedure executes or queues an entry call, depending on the status
+   --  of the corresponding barrier. The specified object is assumed locked.
 
    ---------------------
    -- Check_Exception --
@@ -140,9 +138,9 @@ package body System.Tasking.Protected_Objects.Single_Entry is
    -- Send_Program_Error --
    ------------------------
 
-   procedure Send_Program_Error (Entry_Call : Entry_Call_Link)
-   is
+   procedure Send_Program_Error (Entry_Call : Entry_Call_Link) is
       Caller : constant Task_Id := Entry_Call.Self;
+
    begin
       Entry_Call.Exception_To_Raise := Program_Error'Identity;
 
@@ -192,7 +190,6 @@ package body System.Tasking.Protected_Objects.Single_Entry is
       pragma Assert
         (Caller.Common.State /= Terminated and then
          Caller.Common.State /= Unactivated);
-
       Entry_Call.State := Done;
       STPO.Wakeup (Caller, Entry_Caller_Sleep);
    end Wakeup_Entry_Caller;
@@ -207,7 +204,8 @@ package body System.Tasking.Protected_Objects.Single_Entry is
 
    procedure Exceptional_Complete_Single_Entry_Body
      (Object : Protection_Entry_Access;
-      Ex     : Ada.Exceptions.Exception_Id) is
+      Ex     : Ada.Exceptions.Exception_Id)
+   is
    begin
       Object.Call_In_Progress.Exception_To_Raise := Ex;
    end Exceptional_Complete_Single_Entry_Body;
@@ -235,7 +233,8 @@ package body System.Tasking.Protected_Objects.Single_Entry is
    -- Lock_Entry --
    ----------------
 
-   --  Compiler interface only.
+   --  Compiler interface only
+
    --  Do not call this procedure from within the run-time system.
 
    procedure Lock_Entry (Object : Protection_Entry_Access) is
@@ -391,7 +390,8 @@ package body System.Tasking.Protected_Objects.Single_Entry is
    -----------------------------------
 
    function Protected_Single_Entry_Caller
-     (Object : Protection_Entry) return Task_Id is
+     (Object : Protection_Entry) return Task_Id
+   is
    begin
       return Object.Call_In_Progress.Self;
    end Protected_Single_Entry_Caller;

gcc/ada/s-tposen.ads

@@ -228,7 +228,7 @@ package System.Tasking.Protected_Objects.Single_Entry is
       Uninterpreted_Data  : System.Address);
    --  Make a protected entry call to the specified object
    --
-   --  Pend a protected entry call on the protected object represented by
+   --  Pends a protected entry call on the protected object represented by
    --  Object. A pended call is not queued; it may be executed immediately
    --  or queued, depending on the state of the entry barrier.
    --

gcc/ada/sem_warn.adb

@@ -4244,7 +4244,10 @@ package body Sem_Warn is
 
    procedure Warn_On_Useless_Assignments (E : Entity_Id) is
       Ent : Entity_Id;
+
    begin
+      Process_Deferred_References;
+
       if Warn_On_Modified_Unread
         and then In_Extended_Main_Source_Unit (E)
       then