Skip to content

R
riscv-gcc-1
Commit 9811e84c by Richard Biener Committed by Richard Biener
Options

re PR middle-end/81502 (In some cases the data is moved to memory unnecessarily… 

re PR middle-end/81502 (In some cases the data is moved to memory unnecessarily [partial regression])

2017-07-27  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/81502
	* tree-ssa.c (non_rewritable_lvalue_p): Handle BIT_INSERT_EXPR
	with incompatible but same sized type.
	(execute_update_addresses_taken): Likewise.

	* gcc.target/i386/vect-insert-1.c: New testcase.

From-SVN: r250620
parent 0919ce3e
Showing with 61 additions and 9 deletions
gcc/ChangeLog
2017-07-27 Richard Biener <rguenther@suse.de>
PR tree-optimization/81502
* tree-ssa.c (non_rewritable_lvalue_p): Handle BIT_INSERT_EXPR
with incompatible but same sized type.
(execute_update_addresses_taken): Likewise.
2017-07-27 James Greenhalgh <james.greenhalgh@arm.com> 2017-07-27 James Greenhalgh <james.greenhalgh@arm.com>
* tree-ssa-loop-ch.c (pass_ch::process_loop_p): Guard on * tree-ssa-loop-ch.c (pass_ch::process_loop_p): Guard on
......
gcc/testsuite/ChangeLog
2017-07-27 Richard Biener <rguenther@suse.de>
PR tree-optimization/81502
* gcc.target/i386/vect-insert-1.c: New testcase.
2017-07-27 Andreas Krebbel <krebbel@linux.vnet.ibm.com> 2017-07-27 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
PR target/81534 PR target/81534
......
gcc/testsuite/gcc.target/i386/vect-insert-1.c 0 → 100644
/* { dg-do compile } */
/* { dg-options "-O -msse2 -fdump-tree-ccp1" } */
typedef int v4si __attribute__((vector_size(16)));
float f;
v4si foo (v4si a)
{
__builtin_memcpy ((char *)&a + 4, &f, 4);
return a;
}
/* { dg-final { scan-tree-dump "Now a gimple register: a" "ccp1" } } */
/* { dg-final { scan-tree-dump "BIT_INSERT_EXPR <a" "ccp1" } } */
gcc/tree-ssa.c
...@@ -1513,8 +1513,8 @@ non_rewritable_lvalue_p (tree lhs) ...@@ -1513,8 +1513,8 @@ non_rewritable_lvalue_p (tree lhs)
if (DECL_P (decl) if (DECL_P (decl)
&& VECTOR_TYPE_P (TREE_TYPE (decl)) && VECTOR_TYPE_P (TREE_TYPE (decl))
&& TYPE_MODE (TREE_TYPE (decl)) != BLKmode && TYPE_MODE (TREE_TYPE (decl)) != BLKmode
&& types_compatible_p (TREE_TYPE (lhs), && operand_equal_p (TYPE_SIZE_UNIT (TREE_TYPE (lhs)),
TREE_TYPE (TREE_TYPE (decl))) TYPE_SIZE_UNIT (TREE_TYPE (TREE_TYPE (decl))), 0)
&& tree_fits_uhwi_p (TREE_OPERAND (lhs, 1)) && tree_fits_uhwi_p (TREE_OPERAND (lhs, 1))
&& tree_int_cst_lt (TREE_OPERAND (lhs, 1), && tree_int_cst_lt (TREE_OPERAND (lhs, 1),
TYPE_SIZE_UNIT (TREE_TYPE (decl))) TYPE_SIZE_UNIT (TREE_TYPE (decl)))
...@@ -1529,8 +1529,9 @@ non_rewritable_lvalue_p (tree lhs) ...@@ -1529,8 +1529,9 @@ non_rewritable_lvalue_p (tree lhs)
&& DECL_P (TREE_OPERAND (lhs, 0)) && DECL_P (TREE_OPERAND (lhs, 0))
&& VECTOR_TYPE_P (TREE_TYPE (TREE_OPERAND (lhs, 0))) && VECTOR_TYPE_P (TREE_TYPE (TREE_OPERAND (lhs, 0)))
&& TYPE_MODE (TREE_TYPE (TREE_OPERAND (lhs, 0))) != BLKmode && TYPE_MODE (TREE_TYPE (TREE_OPERAND (lhs, 0))) != BLKmode
&& types_compatible_p (TREE_TYPE (lhs), && operand_equal_p (TYPE_SIZE_UNIT (TREE_TYPE (lhs)),
TREE_TYPE (TREE_TYPE (TREE_OPERAND (lhs, 0)))) TYPE_SIZE_UNIT
(TREE_TYPE (TREE_TYPE (TREE_OPERAND (lhs, 0)))), 0)
&& (tree_to_uhwi (TREE_OPERAND (lhs, 2)) && (tree_to_uhwi (TREE_OPERAND (lhs, 2))
% tree_to_uhwi (TYPE_SIZE (TREE_TYPE (lhs)))) == 0) % tree_to_uhwi (TYPE_SIZE (TREE_TYPE (lhs)))) == 0)
return false; return false;
...@@ -1812,14 +1813,26 @@ execute_update_addresses_taken (void) ...@@ -1812,14 +1813,26 @@ execute_update_addresses_taken (void)
DECL_UID (TREE_OPERAND (lhs, 0))) DECL_UID (TREE_OPERAND (lhs, 0)))
&& VECTOR_TYPE_P (TREE_TYPE (TREE_OPERAND (lhs, 0))) && VECTOR_TYPE_P (TREE_TYPE (TREE_OPERAND (lhs, 0)))
&& TYPE_MODE (TREE_TYPE (TREE_OPERAND (lhs, 0))) != BLKmode && TYPE_MODE (TREE_TYPE (TREE_OPERAND (lhs, 0))) != BLKmode
&& types_compatible_p (TREE_TYPE (lhs), && operand_equal_p (TYPE_SIZE_UNIT (TREE_TYPE (lhs)),
TREE_TYPE (TREE_TYPE TYPE_SIZE_UNIT (TREE_TYPE
(TREE_OPERAND (lhs, 0)))) (TREE_TYPE (TREE_OPERAND (lhs, 0)))),
0)
&& (tree_to_uhwi (TREE_OPERAND (lhs, 2)) && (tree_to_uhwi (TREE_OPERAND (lhs, 2))
% tree_to_uhwi (TYPE_SIZE (TREE_TYPE (lhs))) == 0)) % tree_to_uhwi (TYPE_SIZE (TREE_TYPE (lhs))) == 0))
{ {
tree var = TREE_OPERAND (lhs, 0); tree var = TREE_OPERAND (lhs, 0);
tree val = gimple_assign_rhs1 (stmt); tree val = gimple_assign_rhs1 (stmt);
if (! types_compatible_p (TREE_TYPE (TREE_TYPE (var)),
TREE_TYPE (val)))
{
tree tem = make_ssa_name (TREE_TYPE (TREE_TYPE (var)));
gimple *pun
= gimple_build_assign (tem,
build1 (VIEW_CONVERT_EXPR,
TREE_TYPE (tem), val));
gsi_insert_before (&gsi, pun, GSI_SAME_STMT);
val = tem;
}
tree bitpos = TREE_OPERAND (lhs, 2); tree bitpos = TREE_OPERAND (lhs, 2);
gimple_assign_set_lhs (stmt, var); gimple_assign_set_lhs (stmt, var);
gimple_assign_set_rhs_with_ops gimple_assign_set_rhs_with_ops
...@@ -1839,8 +1852,9 @@ execute_update_addresses_taken (void) ...@@ -1839,8 +1852,9 @@ execute_update_addresses_taken (void)
&& bitmap_bit_p (suitable_for_renaming, DECL_UID (sym)) && bitmap_bit_p (suitable_for_renaming, DECL_UID (sym))
&& VECTOR_TYPE_P (TREE_TYPE (sym)) && VECTOR_TYPE_P (TREE_TYPE (sym))
&& TYPE_MODE (TREE_TYPE (sym)) != BLKmode && TYPE_MODE (TREE_TYPE (sym)) != BLKmode
&& types_compatible_p (TREE_TYPE (lhs), && operand_equal_p (TYPE_SIZE_UNIT (TREE_TYPE (lhs)),
TREE_TYPE (TREE_TYPE (sym))) TYPE_SIZE_UNIT
(TREE_TYPE (TREE_TYPE (sym))), 0)
&& tree_fits_uhwi_p (TREE_OPERAND (lhs, 1)) && tree_fits_uhwi_p (TREE_OPERAND (lhs, 1))
&& tree_int_cst_lt (TREE_OPERAND (lhs, 1), && tree_int_cst_lt (TREE_OPERAND (lhs, 1),
TYPE_SIZE_UNIT (TREE_TYPE (sym))) TYPE_SIZE_UNIT (TREE_TYPE (sym)))
...@@ -1848,6 +1862,17 @@ execute_update_addresses_taken (void) ...@@ -1848,6 +1862,17 @@ execute_update_addresses_taken (void)
% tree_to_uhwi (TYPE_SIZE_UNIT (TREE_TYPE (lhs)))) == 0) % tree_to_uhwi (TYPE_SIZE_UNIT (TREE_TYPE (lhs)))) == 0)
{ {
tree val = gimple_assign_rhs1 (stmt); tree val = gimple_assign_rhs1 (stmt);
if (! types_compatible_p (TREE_TYPE (val),
TREE_TYPE (TREE_TYPE (sym))))
{
tree tem = make_ssa_name (TREE_TYPE (TREE_TYPE (sym)));
gimple *pun
= gimple_build_assign (tem,
build1 (VIEW_CONVERT_EXPR,
TREE_TYPE (tem), val));
gsi_insert_before (&gsi, pun, GSI_SAME_STMT);
val = tem;
}
tree bitpos tree bitpos
= wide_int_to_tree (bitsizetype, = wide_int_to_tree (bitsizetype,
mem_ref_offset (lhs) * BITS_PER_UNIT); mem_ref_offset (lhs) * BITS_PER_UNIT);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment