Commit 91bb5cd9 by Tim Shen Committed by Tim Shen

regex.tcc (match_results<>::format, [...]): Update __out after calling std::copy.

2014-02-26  Tim Shen  <timshen91@gmail.com>

	* include/bits/regex.tcc (match_results<>::format,
	regex_replace<>): Update __out after calling std::copy.
	* testsuite/28_regex/algorithms/regex_replace/char/dr2213.cc:
	Add testcase.
	* testsuite/28_regex/match_results/format.cc: Likewise.

From-SVN: r208179
parent b0ff7fe1
2014-02-26 Tim Shen <timshen91@gmail.com>
* include/bits/regex.tcc (match_results<>::format,
regex_replace<>): Update __out after calling std::copy.
* testsuite/28_regex/algorithms/regex_replace/char/dr2213.cc:
Add testcase.
* testsuite/28_regex/match_results/format.cc: Likewise.
2014-02-22 Marc Glisse <marc.glisse@inria.fr> 2014-02-22 Marc Glisse <marc.glisse@inria.fr>
PR libstdc++/60308 PR libstdc++/60308
......
...@@ -425,7 +425,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION ...@@ -425,7 +425,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
{ {
auto& __sub = _Base_type::operator[](__idx); auto& __sub = _Base_type::operator[](__idx);
if (__sub.matched) if (__sub.matched)
std::copy(__sub.first, __sub.second, __out); __out = std::copy(__sub.first, __sub.second, __out);
}; };
if (__flags & regex_constants::format_sed) if (__flags & regex_constants::format_sed)
...@@ -455,7 +455,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION ...@@ -455,7 +455,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
if (__next == __fmt_last) if (__next == __fmt_last)
break; break;
std::copy(__fmt_first, __next, __out); __out = std::copy(__fmt_first, __next, __out);
auto __eat = [&](char __ch) -> bool auto __eat = [&](char __ch) -> bool
{ {
...@@ -493,7 +493,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION ...@@ -493,7 +493,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
*__out++ = '$'; *__out++ = '$';
__fmt_first = __next; __fmt_first = __next;
} }
std::copy(__fmt_first, __fmt_last, __out); __out = std::copy(__fmt_first, __fmt_last, __out);
} }
return __out; return __out;
} }
...@@ -512,7 +512,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION ...@@ -512,7 +512,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
if (__i == __end) if (__i == __end)
{ {
if (!(__flags & regex_constants::format_no_copy)) if (!(__flags & regex_constants::format_no_copy))
std::copy(__first, __last, __out); __out = std::copy(__first, __last, __out);
} }
else else
{ {
...@@ -521,14 +521,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION ...@@ -521,14 +521,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
for (; __i != __end; ++__i) for (; __i != __end; ++__i)
{ {
if (!(__flags & regex_constants::format_no_copy)) if (!(__flags & regex_constants::format_no_copy))
std::copy(__i->prefix().first, __i->prefix().second, __out); __out = std::copy(__i->prefix().first, __i->prefix().second,
__out);
__out = __i->format(__out, __fmt, __fmt + __len, __flags); __out = __i->format(__out, __fmt, __fmt + __len, __flags);
__last = __i->suffix(); __last = __i->suffix();
if (__flags & regex_constants::format_first_only) if (__flags & regex_constants::format_first_only)
break; break;
} }
if (!(__flags & regex_constants::format_no_copy)) if (!(__flags & regex_constants::format_no_copy))
std::copy(__last.first, __last.second, __out); __out = std::copy(__last.first, __last.second, __out);
} }
return __out; return __out;
} }
......
// { dg-options "-std=gnu++11" }
//
// Copyright (C) 2014 Free Software Foundation, Inc.
//
// This file is part of the GNU ISO C++ Library. This library is free
// software; you can redistribute it and/or modify it under the
// terms of the GNU General Public License as published by the
// Free Software Foundation; either version 3, or (at your option)
// any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License along
// with this library; see the file COPYING3. If not see
// <http://www.gnu.org/licenses/>.
// 28.11.4 regex_replace
// Tests ECMAScript regex_replace's _Out_iter return value.
#include <regex>
#include <testsuite_hooks.h>
using namespace std;
void
test01()
{
bool test __attribute__((unused)) = true;
char buff[4096] = {0};
regex re("asdf");
cmatch m;
string s = "asdf";
string res = "|asdf|asdf|";
VERIFY(regex_replace(buff, s.data(), s.data() + s.size(), re, "|&|\\0|",
regex_constants::format_sed) == buff + res.size());
VERIFY(res == buff);
}
int
main()
{
test01();
return 0;
}
...@@ -45,9 +45,26 @@ test01() ...@@ -45,9 +45,26 @@ test01()
== "this is a string|a|string|is|this|\\"); == "this is a string|a|string|is|this|\\");
} }
void
test02()
{
bool test __attribute__((unused)) = true;
regex re("asdf");
cmatch m;
regex_match("asdf", m, re);
string fmt = "|&|\\0|";
char buff[4096] = {0};
string res = "|asdf|asdf|";
VERIFY(m.format(buff, fmt.data(), fmt.data() + fmt.size(),
regex_constants::format_sed) == buff + res.size());
VERIFY(res == buff);
}
int int
main() main()
{ {
test01(); test01();
test02();
return 0; return 0;
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment