re PR fortran/88376 (ICE in is_illegal_recursion, at fortran/resolve.c:1689)

2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88376
	* resolve.c (is_illegal_recursion): Remove an assert().

2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/88376
	* gfortran.dg/pr88376.f90: New test.

From-SVN: r267793

gcc/fortran/ChangeLog

+2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+	PR fortran/88376
+	* resolve.c (is_illegal_recursion): Remove an assert().
+
 2019-01-09  Sandra Loosemore  <sandra@codesourcery.com>
 
 	PR other/16615
-
 	* expr.c: Change "can not" to "cannot".
 
 2019-01-09  Sandra Loosemore  <sandra@codesourcery.com>
 
 	PR other/16615
-
 	* class.c: Mechanically replace "can not" with "cannot".
 	* decl.c: Likewise.
 	* expr.c: Likewise.

gcc/fortran/resolve.c

@@ -1686,8 +1686,6 @@ is_illegal_recursion (gfc_symbol* sym, gfc_namespace* context)
       || gfc_fl_struct (sym->attr.flavor))
     return false;
 
-  gcc_assert (sym->attr.flavor == FL_PROCEDURE);
-
   /* If we've got an ENTRY, find real procedure.  */
   if (sym->attr.entry && sym->ns->entries)
     proc_sym = sym->ns->entries->sym;

gcc/testsuite/ChangeLog

+2019-01-09  Steven G. Kargl  <kargl@gcc.gnu.org>
+
+	PR fortran/88376
+	* gfortran.dg/pr88376.f90: New test.
+
 2019-01-09  Sandra Loosemore  <sandra@codesourcery.com>
 
 	PR other/16615
-
 	* g++.dg/lto/odr-1_1.C: Update diagnostic message patterns to replace
 	"can not" with "cannot".
 	* gfortran.dg/common_15.f90: Likewise.

gcc/testsuite/gfortran.dg/pr88376.f90

+! { dg-do compile }
+module m
+   integer :: n
+contains
+   subroutine s
+      character(n(3)) :: c  ! { dg-error "not a function" }
+   end
+end