Commit 8b718de8 by Georg-Johann Lay Committed by Georg-Johann Lay

re PR target/81407 ([avr] Diagnose if a variable in progmem needs constructing.)

	PR target/81407
	* config/avr/avr.c (avr_encode_section_info)
	[progmem && !TREE_READONLY]: Error if progmem object needs
	constructing.

From-SVN: r250151
parent 6ea93a64
2017-07-12 Georg-Johann Lay <avr@gjlay.de>
PR target/81407
* config/avr/avr.c (avr_encode_section_info)
[progmem && !TREE_READONLY]: Error if progmem object needs
constructing.
2017-07-11 Michael Collison <michael.collison@arm.com>
* config/aarch64/aarch64-simd.md (aarch64_sub<mode>_compare0):
......
......@@ -10376,18 +10376,26 @@ avr_encode_section_info (tree decl, rtx rtl, int new_decl_p)
if (new_decl_p
&& decl && DECL_P (decl)
&& NULL_TREE == DECL_INITIAL (decl)
&& !DECL_EXTERNAL (decl)
&& avr_progmem_p (decl, DECL_ATTRIBUTES (decl)))
{
// Don't warn for (implicit) aliases like in PR80462.
tree asmname = DECL_ASSEMBLER_NAME (decl);
varpool_node *node = varpool_node::get_for_asmname (asmname);
bool alias_p = node && node->alias;
if (!TREE_READONLY (decl))
{
// This might happen with C++ if stuff needs constructing.
error ("variable %q+D with dynamic initialization put "
"into program memory area", decl);
}
else if (NULL_TREE == DECL_INITIAL (decl))
{
// Don't warn for (implicit) aliases like in PR80462.
tree asmname = DECL_ASSEMBLER_NAME (decl);
varpool_node *node = varpool_node::get_for_asmname (asmname);
bool alias_p = node && node->alias;
if (!alias_p)
warning (OPT_Wuninitialized, "uninitialized variable %q+D put into "
"program memory area", decl);
if (!alias_p)
warning (OPT_Wuninitialized, "uninitialized variable %q+D put "
"into program memory area", decl);
}
}
default_encode_section_info (decl, rtl, new_decl_p);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment