re PR tree-optimization/60849 (bogus comparison result type)

2014-04-17  Richard Biener  <rguenther@suse.de>

	PR middle-end/60849
	* tree-ssa-propagate.c (valid_gimple_rhs_p): Only allow effective
	boolean results for comparisons.

	* g++.dg/opt/pr60849.C: New testcase.

From-SVN: r209469

gcc/ChangeLog

 2014-04-17  Richard Biener  <rguenther@suse.de>
 
+	PR middle-end/60849
+	* tree-ssa-propagate.c (valid_gimple_rhs_p): Only allow effective
+	boolean results for comparisons.
+
+2014-04-17  Richard Biener  <rguenther@suse.de>
+
 	PR tree-optimization/60836
 	* tree-vect-loop.c (vect_create_epilog_for_reduction): Force
 	initial PHI args to be gimple values.

gcc/testsuite/ChangeLog

 2014-04-17  Richard Biener  <rguenther@suse.de>
 
+	PR middle-end/60849
+	* g++.dg/opt/pr60849.C: New testcase.
+
+2014-04-17  Richard Biener  <rguenther@suse.de>
+
 	PR tree-optimization/60836
 	* g++.dg/vect/pr60836.cc: New testcase.
 

gcc/testsuite/g++.dg/opt/pr60849.C

+// { dg-do compile }
+// { dg-options "-O2" }
+
+int g;
+
+extern "C" int isnan ();
+
+void foo(float a) {
+  int (*xx)(...);
+  xx = isnan;
+  if (xx(a))
+    g++;
+}

gcc/tree-ssa-propagate.c

@@ -571,8 +571,14 @@ valid_gimple_rhs_p (tree expr)
       /* All constants are ok.  */
       break;
 
-    case tcc_binary:
     case tcc_comparison:
+      if (!INTEGRAL_TYPE_P (TREE_TYPE (expr))
+	  || (TREE_CODE (TREE_TYPE (expr)) != BOOLEAN_TYPE
+	      && TYPE_PRECISION (TREE_TYPE (expr)) != 1))
+	return false;
+
+      /* Fallthru.  */
+    case tcc_binary:
       if (!is_gimple_val (TREE_OPERAND (expr, 0))
 	  || !is_gimple_val (TREE_OPERAND (expr, 1)))
 	return false;