re PR c++/8586 (-Wwrite-strings should be included in -Wall)

2006-11-19  Gabriel Dos Reis  <gdr@integrable-solutions.net>

        PR c++/8586
        * c-opts.c (c_common_handle_option): Enable -Wwrite-strings if
        -Wall.

testsuite/
2006-11-19  Gabriel Dos Reis  <gdr@integrable-solutions.net>

        PR c++/8586
        * g++.dg/warn/Wall-write-strings.C: New.

From-SVN: r119009

gcc/ChangeLog

+2006-11-19  Gabriel Dos Reis  <gdr@integrable-solutions.net>
+
+	PR c++/8586
+	* c-opts.c (c_common_handle_option): Enable -Wwrite-strings if -Wall.
+
 2006-11-19  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>
 
 	PR target/29114

gcc/c-opts.c

@@ -416,6 +416,8 @@ c_common_handle_option (size_t scode, const char *arg, int value)
 	  /* C++-specific warnings.  */
 	  warn_reorder = value;
 	  warn_nontemplate_friend = value;
+          if (value > 0)
+            warn_write_strings = true;
 	}
 
       cpp_opts->warn_trigraphs = value;

gcc/testsuite/ChangeLog

+2006-11-19  Gabriel Dos Reis  <gdr@integrable-solutions.net>
+
+	PR c++/8586
+	* g++.dg/warn/Wall-write-strings.C: New.
+
 2006-11-19  Erik Edelmann  <eedelman@gcc.gnu.org>
 
 	* gfortran.dg/alloc_comp_constraint_5.f90: New.

gcc/testsuite/g++.dg/warn/Wall-write-strings.C

+// PR 8586
+// { dg-do compile }
+// { dg-options "-Wall" }
+
+char* foo = "foo";              // { dg-warning "" }
+const char* bar = "bar";
+