re PR tree-optimization/37024 (bad tail call from tuples merge)

2008-08-05  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR tree-opt/37024
        * tree-tailcall.c (process_assignment): Use gimple_assign_cast_p 
        instead of IS_CONVERT_EXPR_CODE_P for seeing if the assignment
        is a conversion.

2008-08-05  Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR tree-opt/37024
        * gcc.dg/tree-ssa/tailcall-4.c: New testcase.

From-SVN: r138735

gcc/ChangeLog

+2008-08-05  Andrew Pinski  <andrew_pinski@playstation.sony.com>
+
+	PR tree-opt/37024
+	* tree-tailcall.c (process_assignment): Use gimple_assign_cast_p
+	instead of IS_CONVERT_EXPR_CODE_P for seeing if the assignment
+	is a conversion.
+
 2008-08-05  Richard Henderson  <rth@redhat.com>
 
 	* Makefile.in (c-cppbuiltin.o): Depend on debug.h.

gcc/testsuite/ChangeLog

+2008-08-05  Andrew Pinski  <andrew_pinski@playstation.sony.com>
+
+	PR tree-opt/37024
+	* gcc.dg/tree-ssa/tailcall-4.c: New testcase.
+
 2008-08-05  Richard Guenther  <rguenther@suse.de>
 
 	PR middle-end/37026

gcc/testsuite/gcc.dg/tree-ssa/tailcall-4.c

+/* { dg-do compile } */
+/* { dg-options "-O2 -fdump-tree-tailc-details" } */
+/* PR tree-opt/37024 */
+
+double doubleValue();
+
+long
+longValue ()
+{
+ return (long) doubleValue ();
+}
+
+/* We should not tail call doubleValue in longValue as the mode changes. */
+/* { dg-final { scan-tree-dump-times "Found tail call" 0 "tailc"} } */
+/* { dg-final { cleanup-tree-dump "tailc" } } */
+

gcc/tree-tailcall.c

@@ -283,7 +283,7 @@ process_assignment (gimple stmt, gimple_stmt_iterator call, tree *m,
     {
       /* Reject a tailcall if the type conversion might need
 	 additional code.  */
-      if (IS_CONVERT_EXPR_CODE_P (code)
+      if (gimple_assign_cast_p (stmt)
 	  && TYPE_MODE (TREE_TYPE (dest)) != TYPE_MODE (TREE_TYPE (src_var)))
 	return false;