Commit 72b16773 by Alexandre Oliva Committed by John David Anglin

re PR other/24829 (libobjc testsuite failures)

	PR other/24829
	PR target/24831
	* gthr-dce.h: Do not gthrw-ify pthread_once_init,
	pthread_key_delete.  From John David Anglin.  gthrw-ify
	pthread_getunique_np only if it it's not a macro.  Delete
	UNUSED macro.
	(__gthread_objc_condition_allocate, __gthread_objc_condition_deallocate,
	__gthread_objc_condition_wait, __gthread_objc_condition_broadcast,
	__gthread_objc_condition_signal, __gthread_key_delete): Add
	"__attribute__ ((__unused__))" to unused arguments.
	(__gthread_recursive_mutex_init_function): Add missing return.
	* gthr-dce.h, gthr-tpf.h, gthr-solaris.h, gthr-posix.h,
	gthr-posix95.h: Use macro-based approach for name redirection
	on targets missing weakref.

From-SVN: r110278
parent f7c8e4fc
2006-01-26 Alexandre Oliva <aoliva@redhat.com>
PR other/24829
PR target/24831
* gthr-dce.h: Do not gthrw-ify pthread_once_init,
pthread_key_delete. From John David Anglin. gthrw-ify
pthread_getunique_np only if it it's not a macro. Delete
UNUSED macro.
(__gthread_objc_condition_allocate, __gthread_objc_condition_deallocate,
__gthread_objc_condition_wait, __gthread_objc_condition_broadcast,
__gthread_objc_condition_signal, __gthread_key_delete): Add
"__attribute__ ((__unused__))" to unused arguments.
(__gthread_recursive_mutex_init_function): Add missing return.
* gthr-dce.h, gthr-tpf.h, gthr-solaris.h, gthr-posix.h,
gthr-posix95.h: Use macro-based approach for name redirection
on targets missing weakref.
2006-01-26 Zack Weinberg <zackw@panix.com> 2006-01-26 Zack Weinberg <zackw@panix.com>
* genconditions.c (write_header): In generated code, #ifdef out * genconditions.c (write_header): In generated code, #ifdef out
......
...@@ -70,25 +70,23 @@ typedef pthread_mutex_t __gthread_recursive_mutex_t; ...@@ -70,25 +70,23 @@ typedef pthread_mutex_t __gthread_recursive_mutex_t;
#if SUPPORTS_WEAK && GTHREAD_USE_WEAK #if SUPPORTS_WEAK && GTHREAD_USE_WEAK
# define __gthrw(name) \ # define __gthrw(name) \
static __typeof(name) __gthrw_ ## name __attribute__ ((__weakref__(#name))) static __typeof(name) __gthrw_ ## name __attribute__ ((__weakref__(#name)));
# define __gthrw_(name) __gthrw_ ## name
#else #else
# define __gthrw_asmname(cname) __gthrw_asmnamep (__USER_LABEL_PREFIX__, cname) # define __gthrw(name)
# define __gthrw_asmnamep(prefix, cname) __gthrw_string (prefix) cname # define __gthrw_(name) name
# define __gthrw_string(x) #x
# define __gthrw(name) \
extern __typeof(name) __gthrw_ ## name __asm (__gthrw_asmname (#name))
#endif #endif
__gthrw(pthread_once); __gthrw(pthread_once)
__gthrw(pthread_key_create); __gthrw(pthread_key_create)
__gthrw(pthread_key_delete); __gthrw(pthread_key_delete)
__gthrw(pthread_getspecific); __gthrw(pthread_getspecific)
__gthrw(pthread_setspecific); __gthrw(pthread_setspecific)
__gthrw(pthread_create); __gthrw(pthread_create)
__gthrw(pthread_mutex_lock); __gthrw(pthread_mutex_lock)
__gthrw(pthread_mutex_trylock); __gthrw(pthread_mutex_trylock)
__gthrw(pthread_mutex_unlock); __gthrw(pthread_mutex_unlock)
static inline int static inline int
__gthread_active_p (void) __gthread_active_p (void)
...@@ -100,7 +98,7 @@ static inline int ...@@ -100,7 +98,7 @@ static inline int
__gthread_once (__gthread_once_t *once, void (*func) (void)) __gthread_once (__gthread_once_t *once, void (*func) (void))
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_once (once, func); return __gthrw_(pthread_once) (once, func);
else else
return -1; return -1;
} }
...@@ -109,7 +107,7 @@ static inline int ...@@ -109,7 +107,7 @@ static inline int
__gthread_key_create (__gthread_key_t *key, void (*dtor) (void *)) __gthread_key_create (__gthread_key_t *key, void (*dtor) (void *))
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_key_create (key, dtor); return __gthrw_(pthread_key_create) (key, dtor);
else else
return -1; return -1;
} }
...@@ -118,7 +116,7 @@ static inline int ...@@ -118,7 +116,7 @@ static inline int
__gthread_key_delete (__gthread_key_t key) __gthread_key_delete (__gthread_key_t key)
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_key_delete (key); return __gthrw_(pthread_key_delete) (key);
else else
return -1; return -1;
} }
...@@ -127,7 +125,7 @@ static inline void * ...@@ -127,7 +125,7 @@ static inline void *
__gthread_getspecific (__gthread_key_t key) __gthread_getspecific (__gthread_key_t key)
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_getspecific (key); return __gthrw_(pthread_getspecific) (key);
else else
return NULL; return NULL;
} }
...@@ -136,7 +134,7 @@ static inline int ...@@ -136,7 +134,7 @@ static inline int
__gthread_setspecific (__gthread_key_t key, const void *ptr) __gthread_setspecific (__gthread_key_t key, const void *ptr)
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_setspecific (key, ptr); return __gthrw_(pthread_setspecific) (key, ptr);
else else
return -1; return -1;
} }
...@@ -145,7 +143,7 @@ static inline int ...@@ -145,7 +143,7 @@ static inline int
__gthread_mutex_lock (__gthread_mutex_t *mutex) __gthread_mutex_lock (__gthread_mutex_t *mutex)
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_mutex_lock (mutex); return __gthrw_(pthread_mutex_lock) (mutex);
else else
return 0; return 0;
} }
...@@ -154,7 +152,7 @@ static inline int ...@@ -154,7 +152,7 @@ static inline int
__gthread_mutex_trylock (__gthread_mutex_t *mutex) __gthread_mutex_trylock (__gthread_mutex_t *mutex)
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_mutex_trylock (mutex); return __gthrw_(pthread_mutex_trylock) (mutex);
else else
return 0; return 0;
} }
...@@ -163,7 +161,7 @@ static inline int ...@@ -163,7 +161,7 @@ static inline int
__gthread_mutex_unlock (__gthread_mutex_t *mutex) __gthread_mutex_unlock (__gthread_mutex_t *mutex)
{ {
if (__tpf_pthread_active ()) if (__tpf_pthread_active ())
return __gthrw_pthread_mutex_unlock (mutex); return __gthrw_(pthread_mutex_unlock) (mutex);
else else
return 0; return 0;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment