Commit 6d4fbcc9 by Jeff Law Committed by Jeff Law

re PR rtl-optimization/59446 (loop2_doloop creates constant comparison and dead jump)

	PR rtl-optimization/59446
	* tree-ssa-threadupdate.c (mark_threaded_blocks): Properly
	test for crossing a loop header.

From-SVN: r205905
parent 26084432
2013-12-11 Jeff Law <law@redhat.com>
PR rtl-optimization/59446
* tree-ssa-threadupdate.c (mark_threaded_blocks): Properly
test for crossing a loop header.
2013-12-11 Sriraman Tallam <tmsriram@google.com> 2013-12-11 Sriraman Tallam <tmsriram@google.com>
PR target/59390 PR target/59390
...@@ -1449,44 +1449,32 @@ mark_threaded_blocks (bitmap threaded_blocks) ...@@ -1449,44 +1449,32 @@ mark_threaded_blocks (bitmap threaded_blocks)
{ {
vec<jump_thread_edge *> *path = THREAD_PATH (e); vec<jump_thread_edge *> *path = THREAD_PATH (e);
/* Basically we're looking for a situation where we can see for (unsigned int i = 0, crossed_headers = 0;
3 or more loop structures on a jump threading path. */ i < path->length ();
i++)
struct loop *first_father = (*path)[0]->e->src->loop_father;
struct loop *second_father = NULL;
for (unsigned int i = 0; i < path->length (); i++)
{ {
/* See if this is a loop father we have not seen before. */ basic_block dest = (*path)[i]->e->dest;
if ((*path)[i]->e->dest->loop_father != first_father crossed_headers += (dest == dest->loop_father->header);
&& (*path)[i]->e->dest->loop_father != second_father) if (crossed_headers > 1)
{ {
/* We've already seen two loop fathers, so we /* Trim from entry I onwards. */
need to trim this jump threading path. */ for (unsigned int j = i; j < path->length (); j++)
if (second_father != NULL) delete (*path)[j];
{ path->truncate (i);
/* Trim from entry I onwards. */
for (unsigned int j = i; j < path->length (); j++) /* Now that we've truncated the path, make sure
delete (*path)[j]; what's left is still valid. We need at least
path->truncate (i); two edges on the path and the last edge can not
be a joiner. This should never happen, but let's
/* Now that we've truncated the path, make sure be safe. */
what's left is still valid. We need at least if (path->length () < 2
two edges on the path and the last edge can not || (path->last ()->type
be a joiner. This should never happen, but let's == EDGE_COPY_SRC_JOINER_BLOCK))
be safe. */
if (path->length () < 2
|| (path->last ()->type
== EDGE_COPY_SRC_JOINER_BLOCK))
{
delete_jump_thread_path (path);
e->aux = NULL;
}
break;
}
else
{ {
second_father = (*path)[i]->e->dest->loop_father; delete_jump_thread_path (path);
e->aux = NULL;
} }
break;
} }
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment