Commit 6d26724a by Ralf Wildenhues Committed by Ralf Wildenhues

libgomp/

	* acinclude.m4 (LIBGOMP_CHECK_SYNC_BUILTINS)
	(LIBGOMP_CHECK_ATTRIBUTE_VISIBILITY)
	(LIBGOMP_CHECK_ATTRIBUTE_DLLEXPORT)
	(LIBGOMP_CHECK_ATTRIBUTE_ALIAS): Fix cache variable names.
	* configure: Regenerate.
	* Makefile.in, testsuite/Makefile.in: Likewise.

libstdc++-v3/
	* acinclude.m4 (GLIBCXX_CHECK_SETRLIMIT, GLIBCXX_ENABLE_C99)
	(GLIBCXX_CHECK_C99_TR1, GLIBCXX_CHECK_RANDOM_TR1)
	(GLIBCXX_ENABLE_VISIBILITY): Fix cache variable names.
	(GLIBCXX_CHECK_SYSTEM_ERROR): Likewise.  Factorize.
	* configure: Regenerate.

libgfortran/
	* acinclude.m4 (LIBGFOR_CHECK_ATTRIBUTE_VISIBILITY)
	(LIBGFOR_CHECK_ATTRIBUTE_DLLEXPORT)
	(LIBGFOR_CHECK_ATTRIBUTE_ALIAS, LIBGFOR_CHECK_SYNC_FETCH_AND_ADD)
	(LIBGFOR_GTHREAD_WEAK, LIBGFOR_CHECK_UNLINK_OPEN_FILE)
	(LIBGFOR_CHECK_CRLF, LIBGFOR_CHECK_FOR_BROKEN_ISFINITE)
	(LIBGFOR_CHECK_FOR_BROKEN_ISNAN)
	(LIBGFOR_CHECK_FOR_BROKEN_FPCLASSIFY, LIBGFOR_CHECK_WORKING_STAT)
	(LIBGFOR_CHECK_FPSETMASK, LIBGFOR_CHECK_MINGW_SNPRINTF):
	Fix cache variable names.
	* configure, Makefile.in: Regenerate.

From-SVN: r134531
parent b60db1ba
2008-04-21 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
* acinclude.m4 (LIBGFOR_CHECK_ATTRIBUTE_VISIBILITY)
(LIBGFOR_CHECK_ATTRIBUTE_DLLEXPORT)
(LIBGFOR_CHECK_ATTRIBUTE_ALIAS, LIBGFOR_CHECK_SYNC_FETCH_AND_ADD)
(LIBGFOR_GTHREAD_WEAK, LIBGFOR_CHECK_UNLINK_OPEN_FILE)
(LIBGFOR_CHECK_CRLF, LIBGFOR_CHECK_FOR_BROKEN_ISFINITE)
(LIBGFOR_CHECK_FOR_BROKEN_ISNAN)
(LIBGFOR_CHECK_FOR_BROKEN_FPCLASSIFY, LIBGFOR_CHECK_WORKING_STAT)
(LIBGFOR_CHECK_FPSETMASK, LIBGFOR_CHECK_MINGW_SNPRINTF):
Fix cache variable names.
* configure, Makefile.in: Regenerate.
2008-04-20 Jerry DeLisle <jvdelisle@gcc.gnu.org> 2008-04-20 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/35991 PR fortran/35991
......
...@@ -51,6 +51,7 @@ ACLOCAL_M4 = $(top_srcdir)/aclocal.m4 ...@@ -51,6 +51,7 @@ ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
am__aclocal_m4_deps = $(top_srcdir)/../config/depstand.m4 \ am__aclocal_m4_deps = $(top_srcdir)/../config/depstand.m4 \
$(top_srcdir)/../config/lead-dot.m4 \ $(top_srcdir)/../config/lead-dot.m4 \
$(top_srcdir)/../config/multi.m4 \ $(top_srcdir)/../config/multi.m4 \
$(top_srcdir)/../config/override.m4 \
$(top_srcdir)/../config/proginstall.m4 \ $(top_srcdir)/../config/proginstall.m4 \
$(top_srcdir)/../config/stdint.m4 \ $(top_srcdir)/../config/stdint.m4 \
$(top_srcdir)/../ltoptions.m4 $(top_srcdir)/../ltsugar.m4 \ $(top_srcdir)/../ltoptions.m4 $(top_srcdir)/../ltsugar.m4 \
......
2008-04-21 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
* acinclude.m4 (LIBGOMP_CHECK_SYNC_BUILTINS)
(LIBGOMP_CHECK_ATTRIBUTE_VISIBILITY)
(LIBGOMP_CHECK_ATTRIBUTE_DLLEXPORT)
(LIBGOMP_CHECK_ATTRIBUTE_ALIAS): Fix cache variable names.
* configure: Regenerate.
* Makefile.in, testsuite/Makefile.in: Likewise.
2008-04-18 Paolo Bonzini <bonzini@gnu.org> 2008-04-18 Paolo Bonzini <bonzini@gnu.org>
PR bootstrap/35457 PR bootstrap/35457
......
...@@ -55,6 +55,7 @@ am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \ ...@@ -55,6 +55,7 @@ am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \
$(top_srcdir)/../config/futex.m4 \ $(top_srcdir)/../config/futex.m4 \
$(top_srcdir)/../config/lead-dot.m4 \ $(top_srcdir)/../config/lead-dot.m4 \
$(top_srcdir)/../config/multi.m4 \ $(top_srcdir)/../config/multi.m4 \
$(top_srcdir)/../config/override.m4 \
$(top_srcdir)/../config/proginstall.m4 \ $(top_srcdir)/../config/proginstall.m4 \
$(top_srcdir)/../config/stdint.m4 \ $(top_srcdir)/../config/stdint.m4 \
$(top_srcdir)/../config/tls.m4 $(top_srcdir)/../ltoptions.m4 \ $(top_srcdir)/../config/tls.m4 $(top_srcdir)/../ltoptions.m4 \
......
...@@ -4,10 +4,10 @@ dnl This whole bit snagged from libgfortran. ...@@ -4,10 +4,10 @@ dnl This whole bit snagged from libgfortran.
dnl Check whether the target supports __sync_*_compare_and_swap. dnl Check whether the target supports __sync_*_compare_and_swap.
AC_DEFUN([LIBGOMP_CHECK_SYNC_BUILTINS], [ AC_DEFUN([LIBGOMP_CHECK_SYNC_BUILTINS], [
AC_CACHE_CHECK([whether the target supports __sync_*_compare_and_swap], AC_CACHE_CHECK([whether the target supports __sync_*_compare_and_swap],
have_sync_builtins, [ libgomp_cv_have_sync_builtins, [
AC_TRY_LINK([], [int foo, bar; bar = __sync_val_compare_and_swap(&foo, 0, 1);], AC_TRY_LINK([], [int foo, bar; bar = __sync_val_compare_and_swap(&foo, 0, 1);],
have_sync_builtins=yes, have_sync_builtins=no)]) libgomp_cv_have_sync_builtins=yes, libgomp_cv_have_sync_builtins=no)])
if test $have_sync_builtins = yes; then if test $libgomp_cv_have_sync_builtins = yes; then
AC_DEFINE(HAVE_SYNC_BUILTINS, 1, AC_DEFINE(HAVE_SYNC_BUILTINS, 1,
[Define to 1 if the target supports __sync_*_compare_and_swap]) [Define to 1 if the target supports __sync_*_compare_and_swap])
fi]) fi])
...@@ -15,14 +15,14 @@ AC_DEFUN([LIBGOMP_CHECK_SYNC_BUILTINS], [ ...@@ -15,14 +15,14 @@ AC_DEFUN([LIBGOMP_CHECK_SYNC_BUILTINS], [
dnl Check whether the target supports hidden visibility. dnl Check whether the target supports hidden visibility.
AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_VISIBILITY], [ AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_VISIBILITY], [
AC_CACHE_CHECK([whether the target supports hidden visibility], AC_CACHE_CHECK([whether the target supports hidden visibility],
have_attribute_visibility, [ libgomp_cv_have_attribute_visibility, [
save_CFLAGS="$CFLAGS" save_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS -Werror" CFLAGS="$CFLAGS -Werror"
AC_TRY_COMPILE([void __attribute__((visibility("hidden"))) foo(void) { }], AC_TRY_COMPILE([void __attribute__((visibility("hidden"))) foo(void) { }],
[], have_attribute_visibility=yes, [], libgomp_cv_have_attribute_visibility=yes,
have_attribute_visibility=no) libgomp_cv_have_attribute_visibility=no)
CFLAGS="$save_CFLAGS"]) CFLAGS="$save_CFLAGS"])
if test $have_attribute_visibility = yes; then if test $libgomp_cv_have_attribute_visibility = yes; then
AC_DEFINE(HAVE_ATTRIBUTE_VISIBILITY, 1, AC_DEFINE(HAVE_ATTRIBUTE_VISIBILITY, 1,
[Define to 1 if the target supports __attribute__((visibility(...))).]) [Define to 1 if the target supports __attribute__((visibility(...))).])
fi]) fi])
...@@ -30,14 +30,14 @@ AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_VISIBILITY], [ ...@@ -30,14 +30,14 @@ AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_VISIBILITY], [
dnl Check whether the target supports dllexport dnl Check whether the target supports dllexport
AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_DLLEXPORT], [ AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_DLLEXPORT], [
AC_CACHE_CHECK([whether the target supports dllexport], AC_CACHE_CHECK([whether the target supports dllexport],
have_attribute_dllexport, [ libgomp_cv_have_attribute_dllexport, [
save_CFLAGS="$CFLAGS" save_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS -Werror" CFLAGS="$CFLAGS -Werror"
AC_TRY_COMPILE([void __attribute__((dllexport)) foo(void) { }], AC_TRY_COMPILE([void __attribute__((dllexport)) foo(void) { }],
[], have_attribute_dllexport=yes, [], libgomp_cv_have_attribute_dllexport=yes,
have_attribute_dllexport=no) libgomp_cv_have_attribute_dllexport=no)
CFLAGS="$save_CFLAGS"]) CFLAGS="$save_CFLAGS"])
if test $have_attribute_dllexport = yes; then if test $libgomp_cv_have_attribute_dllexport = yes; then
AC_DEFINE(HAVE_ATTRIBUTE_DLLEXPORT, 1, AC_DEFINE(HAVE_ATTRIBUTE_DLLEXPORT, 1,
[Define to 1 if the target supports __attribute__((dllexport)).]) [Define to 1 if the target supports __attribute__((dllexport)).])
fi]) fi])
...@@ -45,12 +45,12 @@ AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_DLLEXPORT], [ ...@@ -45,12 +45,12 @@ AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_DLLEXPORT], [
dnl Check whether the target supports symbol aliases. dnl Check whether the target supports symbol aliases.
AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_ALIAS], [ AC_DEFUN([LIBGOMP_CHECK_ATTRIBUTE_ALIAS], [
AC_CACHE_CHECK([whether the target supports symbol aliases], AC_CACHE_CHECK([whether the target supports symbol aliases],
have_attribute_alias, [ libgomp_cv_have_attribute_alias, [
AC_TRY_LINK([ AC_TRY_LINK([
void foo(void) { } void foo(void) { }
extern void bar(void) __attribute__((alias("foo")));], extern void bar(void) __attribute__((alias("foo")));],
[bar();], have_attribute_alias=yes, have_attribute_alias=no)]) [bar();], libgomp_cv_have_attribute_alias=yes, libgomp_cv_have_attribute_alias=no)])
if test $have_attribute_alias = yes; then if test $libgomp_cv_have_attribute_alias = yes; then
AC_DEFINE(HAVE_ATTRIBUTE_ALIAS, 1, AC_DEFINE(HAVE_ATTRIBUTE_ALIAS, 1,
[Define to 1 if the target supports __attribute__((alias(...))).]) [Define to 1 if the target supports __attribute__((alias(...))).])
fi]) fi])
......
...@@ -17364,7 +17364,7 @@ _ACEOF ...@@ -17364,7 +17364,7 @@ _ACEOF
echo "$as_me:$LINENO: checking whether the target supports hidden visibility" >&5 echo "$as_me:$LINENO: checking whether the target supports hidden visibility" >&5
echo $ECHO_N "checking whether the target supports hidden visibility... $ECHO_C" >&6 echo $ECHO_N "checking whether the target supports hidden visibility... $ECHO_C" >&6
if test "${have_attribute_visibility+set}" = set; then if test "${libgomp_cv_have_attribute_visibility+set}" = set; then
echo $ECHO_N "(cached) $ECHO_C" >&6 echo $ECHO_N "(cached) $ECHO_C" >&6
else else
...@@ -17407,19 +17407,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5 ...@@ -17407,19 +17407,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5
ac_status=$? ac_status=$?
echo "$as_me:$LINENO: \$? = $ac_status" >&5 echo "$as_me:$LINENO: \$? = $ac_status" >&5
(exit $ac_status); }; }; then (exit $ac_status); }; }; then
have_attribute_visibility=yes libgomp_cv_have_attribute_visibility=yes
else else
echo "$as_me: failed program was:" >&5 echo "$as_me: failed program was:" >&5
sed 's/^/| /' conftest.$ac_ext >&5 sed 's/^/| /' conftest.$ac_ext >&5
have_attribute_visibility=no libgomp_cv_have_attribute_visibility=no
fi fi
rm -f conftest.err conftest.$ac_objext conftest.$ac_ext rm -f conftest.err conftest.$ac_objext conftest.$ac_ext
CFLAGS="$save_CFLAGS" CFLAGS="$save_CFLAGS"
fi fi
echo "$as_me:$LINENO: result: $have_attribute_visibility" >&5 echo "$as_me:$LINENO: result: $libgomp_cv_have_attribute_visibility" >&5
echo "${ECHO_T}$have_attribute_visibility" >&6 echo "${ECHO_T}$libgomp_cv_have_attribute_visibility" >&6
if test $have_attribute_visibility = yes; then if test $libgomp_cv_have_attribute_visibility = yes; then
cat >>confdefs.h <<\_ACEOF cat >>confdefs.h <<\_ACEOF
#define HAVE_ATTRIBUTE_VISIBILITY 1 #define HAVE_ATTRIBUTE_VISIBILITY 1
...@@ -17429,7 +17429,7 @@ _ACEOF ...@@ -17429,7 +17429,7 @@ _ACEOF
echo "$as_me:$LINENO: checking whether the target supports dllexport" >&5 echo "$as_me:$LINENO: checking whether the target supports dllexport" >&5
echo $ECHO_N "checking whether the target supports dllexport... $ECHO_C" >&6 echo $ECHO_N "checking whether the target supports dllexport... $ECHO_C" >&6
if test "${have_attribute_dllexport+set}" = set; then if test "${libgomp_cv_have_attribute_dllexport+set}" = set; then
echo $ECHO_N "(cached) $ECHO_C" >&6 echo $ECHO_N "(cached) $ECHO_C" >&6
else else
...@@ -17472,19 +17472,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5 ...@@ -17472,19 +17472,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5
ac_status=$? ac_status=$?
echo "$as_me:$LINENO: \$? = $ac_status" >&5 echo "$as_me:$LINENO: \$? = $ac_status" >&5
(exit $ac_status); }; }; then (exit $ac_status); }; }; then
have_attribute_dllexport=yes libgomp_cv_have_attribute_dllexport=yes
else else
echo "$as_me: failed program was:" >&5 echo "$as_me: failed program was:" >&5
sed 's/^/| /' conftest.$ac_ext >&5 sed 's/^/| /' conftest.$ac_ext >&5
have_attribute_dllexport=no libgomp_cv_have_attribute_dllexport=no
fi fi
rm -f conftest.err conftest.$ac_objext conftest.$ac_ext rm -f conftest.err conftest.$ac_objext conftest.$ac_ext
CFLAGS="$save_CFLAGS" CFLAGS="$save_CFLAGS"
fi fi
echo "$as_me:$LINENO: result: $have_attribute_dllexport" >&5 echo "$as_me:$LINENO: result: $libgomp_cv_have_attribute_dllexport" >&5
echo "${ECHO_T}$have_attribute_dllexport" >&6 echo "${ECHO_T}$libgomp_cv_have_attribute_dllexport" >&6
if test $have_attribute_dllexport = yes; then if test $libgomp_cv_have_attribute_dllexport = yes; then
cat >>confdefs.h <<\_ACEOF cat >>confdefs.h <<\_ACEOF
#define HAVE_ATTRIBUTE_DLLEXPORT 1 #define HAVE_ATTRIBUTE_DLLEXPORT 1
...@@ -17494,7 +17494,7 @@ _ACEOF ...@@ -17494,7 +17494,7 @@ _ACEOF
echo "$as_me:$LINENO: checking whether the target supports symbol aliases" >&5 echo "$as_me:$LINENO: checking whether the target supports symbol aliases" >&5
echo $ECHO_N "checking whether the target supports symbol aliases... $ECHO_C" >&6 echo $ECHO_N "checking whether the target supports symbol aliases... $ECHO_C" >&6
if test "${have_attribute_alias+set}" = set; then if test "${libgomp_cv_have_attribute_alias+set}" = set; then
echo $ECHO_N "(cached) $ECHO_C" >&6 echo $ECHO_N "(cached) $ECHO_C" >&6
else else
...@@ -17537,19 +17537,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_link\"") >&5 ...@@ -17537,19 +17537,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_link\"") >&5
ac_status=$? ac_status=$?
echo "$as_me:$LINENO: \$? = $ac_status" >&5 echo "$as_me:$LINENO: \$? = $ac_status" >&5
(exit $ac_status); }; }; then (exit $ac_status); }; }; then
have_attribute_alias=yes libgomp_cv_have_attribute_alias=yes
else else
echo "$as_me: failed program was:" >&5 echo "$as_me: failed program was:" >&5
sed 's/^/| /' conftest.$ac_ext >&5 sed 's/^/| /' conftest.$ac_ext >&5
have_attribute_alias=no libgomp_cv_have_attribute_alias=no
fi fi
rm -f conftest.err conftest.$ac_objext \ rm -f conftest.err conftest.$ac_objext \
conftest$ac_exeext conftest.$ac_ext conftest$ac_exeext conftest.$ac_ext
fi fi
echo "$as_me:$LINENO: result: $have_attribute_alias" >&5 echo "$as_me:$LINENO: result: $libgomp_cv_have_attribute_alias" >&5
echo "${ECHO_T}$have_attribute_alias" >&6 echo "${ECHO_T}$libgomp_cv_have_attribute_alias" >&6
if test $have_attribute_alias = yes; then if test $libgomp_cv_have_attribute_alias = yes; then
cat >>confdefs.h <<\_ACEOF cat >>confdefs.h <<\_ACEOF
#define HAVE_ATTRIBUTE_ALIAS 1 #define HAVE_ATTRIBUTE_ALIAS 1
...@@ -17997,7 +17997,7 @@ CFLAGS="$save_CFLAGS $XCFLAGS" ...@@ -17997,7 +17997,7 @@ CFLAGS="$save_CFLAGS $XCFLAGS"
echo "$as_me:$LINENO: checking whether the target supports __sync_*_compare_and_swap" >&5 echo "$as_me:$LINENO: checking whether the target supports __sync_*_compare_and_swap" >&5
echo $ECHO_N "checking whether the target supports __sync_*_compare_and_swap... $ECHO_C" >&6 echo $ECHO_N "checking whether the target supports __sync_*_compare_and_swap... $ECHO_C" >&6
if test "${have_sync_builtins+set}" = set; then if test "${libgomp_cv_have_sync_builtins+set}" = set; then
echo $ECHO_N "(cached) $ECHO_C" >&6 echo $ECHO_N "(cached) $ECHO_C" >&6
else else
...@@ -18038,19 +18038,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_link\"") >&5 ...@@ -18038,19 +18038,19 @@ if { (eval echo "$as_me:$LINENO: \"$ac_link\"") >&5
ac_status=$? ac_status=$?
echo "$as_me:$LINENO: \$? = $ac_status" >&5 echo "$as_me:$LINENO: \$? = $ac_status" >&5
(exit $ac_status); }; }; then (exit $ac_status); }; }; then
have_sync_builtins=yes libgomp_cv_have_sync_builtins=yes
else else
echo "$as_me: failed program was:" >&5 echo "$as_me: failed program was:" >&5
sed 's/^/| /' conftest.$ac_ext >&5 sed 's/^/| /' conftest.$ac_ext >&5
have_sync_builtins=no libgomp_cv_have_sync_builtins=no
fi fi
rm -f conftest.err conftest.$ac_objext \ rm -f conftest.err conftest.$ac_objext \
conftest$ac_exeext conftest.$ac_ext conftest$ac_exeext conftest.$ac_ext
fi fi
echo "$as_me:$LINENO: result: $have_sync_builtins" >&5 echo "$as_me:$LINENO: result: $libgomp_cv_have_sync_builtins" >&5
echo "${ECHO_T}$have_sync_builtins" >&6 echo "${ECHO_T}$libgomp_cv_have_sync_builtins" >&6
if test $have_sync_builtins = yes; then if test $libgomp_cv_have_sync_builtins = yes; then
cat >>confdefs.h <<\_ACEOF cat >>confdefs.h <<\_ACEOF
#define HAVE_SYNC_BUILTINS 1 #define HAVE_SYNC_BUILTINS 1
......
...@@ -45,6 +45,7 @@ am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \ ...@@ -45,6 +45,7 @@ am__aclocal_m4_deps = $(top_srcdir)/../config/acx.m4 \
$(top_srcdir)/../config/futex.m4 \ $(top_srcdir)/../config/futex.m4 \
$(top_srcdir)/../config/lead-dot.m4 \ $(top_srcdir)/../config/lead-dot.m4 \
$(top_srcdir)/../config/multi.m4 \ $(top_srcdir)/../config/multi.m4 \
$(top_srcdir)/../config/override.m4 \
$(top_srcdir)/../config/proginstall.m4 \ $(top_srcdir)/../config/proginstall.m4 \
$(top_srcdir)/../config/stdint.m4 \ $(top_srcdir)/../config/stdint.m4 \
$(top_srcdir)/../config/tls.m4 $(top_srcdir)/../ltoptions.m4 \ $(top_srcdir)/../config/tls.m4 $(top_srcdir)/../ltoptions.m4 \
......
2008-04-21 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
* acinclude.m4 (GLIBCXX_CHECK_SETRLIMIT, GLIBCXX_ENABLE_C99)
(GLIBCXX_CHECK_C99_TR1, GLIBCXX_CHECK_RANDOM_TR1)
(GLIBCXX_ENABLE_VISIBILITY): Fix cache variable names.
(GLIBCXX_CHECK_SYSTEM_ERROR): Likewise. Factorize.
* configure: Regenerate.
2008-04-20 Ralf Wildenhues <Ralf.Wildenhues@gmx.de> 2008-04-20 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
PR libstdc++/35954 PR libstdc++/35954
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment