analyzer: fix ICE with 'const void *' (PR 93457)

gcc/analyzer/ChangeLog:
	PR analyzer/93457
	* region-model.cc (make_region_for_type): Use VOID_TYPE_P rather
	than checking against void_type_node.

gcc/testsuite/ChangeLog:
	PR analyzer/93457
	* gcc.dg/analyzer/pr93457.c: New test.

gcc/analyzer/ChangeLog

 2020-01-31  David Malcolm  <dmalcolm@redhat.com>
 
+	PR analyzer/93457
+	* region-model.cc (make_region_for_type): Use VOID_TYPE_P rather
+	than checking against void_type_node.
+
+2020-01-31  David Malcolm  <dmalcolm@redhat.com>
+
 	PR analyzer/93373
 	* region-model.cc (ASSERT_COMPAT_TYPES): Convert to...
 	(assert_compat_types): ...this, and bail when either type is NULL,

gcc/analyzer/region-model.cc

@@ -6005,7 +6005,7 @@ make_region_for_type (region_id parent_rid, tree type)
     return new function_region (parent_rid, type);
 
   /* If we have a void *, make a new symbolic region.  */
-  if (type == void_type_node)
+  if (VOID_TYPE_P (type))
     return new symbolic_region (parent_rid, false);
 
   gcc_unreachable ();

gcc/testsuite/ChangeLog

 2020-01-31  David Malcolm  <dmalcolm@redhat.com>
 
+	PR analyzer/93457
+	* gcc.dg/analyzer/pr93457.c: New test.
+
+2020-01-31  David Malcolm  <dmalcolm@redhat.com>
+
 	PR analyzer/93373
 	* gcc.dg/analyzer/torture/pr93373.c: New test.
 

gcc/testsuite/gcc.dg/analyzer/pr93457.c

+/* { dg-do compile } */
+
+void
+p5 (const void *);
+
+void
+s5 (const void *cl)
+{
+  p5 (&cl[1]); /* { dg-warning "dereferencing 'void \\*' pointer" } */
+}