re PR c++/33558 ('mutable' incorrectly accepted on reference members)

2011-01-15  Giovanni Funchal  <gafunchal@gmail.com>
	    Jonathan Wakely  <jwakely.gcc@gmail.com>

	PR c++/33558
	* decl.c (grokdeclarator): Reject mutable reference members.


Co-Authored-By: Jonathan Wakely <jwakely.gcc@gmail.com>

From-SVN: r168843

gcc/cp/ChangeLog

+2011-01-15  Giovanni Funchal  <gafunchal@gmail.com>
+	    Jonathan Wakely  <jwakely.gcc@gmail.com>
+
+	PR c++/33558
+	* decl.c (grokdeclarator): Reject mutable reference members.
+
 2011-01-14  Jason Merrill  <jason@redhat.com>
 
 	PR c++/47289

gcc/cp/decl.c

@@ -9214,6 +9214,12 @@ grokdeclarator (const cp_declarator *declarator,
 	  error ("const %qs cannot be declared %<mutable%>", name);
 	  storage_class = sc_none;
 	}
+      else if (TREE_CODE (type) == REFERENCE_TYPE)
+	{
+	  permerror (input_location, "reference %qs cannot be declared "
+	             "%<mutable%>", name);
+	  storage_class = sc_none;
+	}
     }
 
   /* If this is declaring a typedef name, return a TYPE_DECL.  */

gcc/testsuite/ChangeLog

+2011-01-15  Giovanni Funchal  <gafunchal@gmail.com>
+	    Jonathan Wakely  <jwakely.gcc@gmail.com>
+
+	PR c++/33558
+	* g++.dg/other/pr33558.C: New.
+	* g++.dg/other/pr33558-2.C: New.
+
 2011-01-14  Martin Jambor  <mjambor@suse.cz>
 
 	PR tree-optimization/45934

gcc/testsuite/g++.dg/other/pr33558-2.C

+/* { dg-do compile } */
+/* { dg-options "-fpermissive" } */
+
+class X {
+  mutable int &q; /* { dg-warning "cannot be declared 'mutable'" } */
+};

gcc/testsuite/g++.dg/other/pr33558.C

+/* { dg-do compile } */
+
+class X {
+  mutable int &q; /* { dg-error "cannot be declared 'mutable'" } */
+};