rs6000: Improve the load/store-with-update patterns (PR17108)

Many of these patterns only worked in 32-bit mode, and some only worked
in 64-bit mode.  This patch makes these use Pmode, fixing the PR.  On
the other hand, the stack updates have to use the same mode for the
stack pointer as for the value stored, so let's simplify that a bit.

Many of these patterns pass the wrong mode to
avoiding_indexed_address_p (it should be the mode of the datum
accessed, not the mode of the pointer).

Finally, I merge some patterns into one (using iterators).


	PR target/17108
	* config/rs6000/rs6000.c (rs6000_split_multireg_move): Adjust pattern
	name.
	(rs6000_emit_allocate_stack_1): Simplify condition.  Adjust pattern
	name.
	* config/rs6000/rs6000.md (bits): Add entries for SF and DF.
	(*movdi_update1): Use Pmode.
	(movdi_<mode>_update): Fix argument to avoiding_indexed_address_p.
	(movdi_<mode>_update_stack): Rename to ...
	(movdi_update_stack): ... this.  Fix comment.  Change condition. Don't
	use Pmode.
	(*movsi_update1): Use Pmode.
	(*movsi_update2): Use Pmode.
	(movsi_update): Rename to ...
	(movsi_<mode>_update): ... this.  Use Pmode.
	(movsi_update_stack): Fix condition.
	(*movhi_update1): Use Pmode.  Fix argument to
	avoiding_indexed_address_p.
	(*movhi_update2): Ditto.
	(*movhi_update3): Ditto.
	(*movhi_update4): Ditto.
	(*movqi_update1): Ditto.
	(*movqi_update2): Ditto.
	(*movqi_update3): Ditto.
	(*movsf_update1, *movdf_update1): Merge, rename to...
	(*mov<mode>_update1): This.  Use Pmode.  Fix argument to
	avoiding_indexed_address_p.  Add "size" attribute.
	(*movsf_update2, *movdf_update2): Merge, rename to...
	(*mov<mode>_update2): This.  Ditto.
	(*movsf_update3): Use Pmode.  Fix argument to
	avoiding_indexed_address_p.
	(*movsf_update4): Ditto.
	(allocate_stack): Simplify condition.  Adjust pattern names.

From-SVN: r270407

gcc/ChangeLog

+2019-04-17  Segher Boessenkool  <segher@kernel.crashing.org>
+
+	PR target/17108
+	* config/rs6000/rs6000.c (rs6000_split_multireg_move): Adjust pattern
+	name.
+	(rs6000_emit_allocate_stack_1): Simplify condition.  Adjust pattern
+	name.
+	* config/rs6000/rs6000.md (bits): Add entries for SF and DF.
+	(*movdi_update1): Use Pmode.
+	(movdi_<mode>_update): Fix argument to avoiding_indexed_address_p.
+	(movdi_<mode>_update_stack): Rename to ...
+	(movdi_update_stack): ... this.  Fix comment.  Change condition. Don't
+	use Pmode.
+	(*movsi_update1): Use Pmode.
+	(*movsi_update2): Use Pmode.
+	(movsi_update): Rename to ...
+	(movsi_<mode>_update): ... this.  Use Pmode.
+	(movsi_update_stack): Fix condition.
+	(*movhi_update1): Use Pmode.  Fix argument to
+	avoiding_indexed_address_p.
+	(*movhi_update2): Ditto.
+	(*movhi_update3): Ditto.
+	(*movhi_update4): Ditto.
+	(*movqi_update1): Ditto.
+	(*movqi_update2): Ditto.
+	(*movqi_update3): Ditto.
+	(*movsf_update1, *movdf_update1): Merge, rename to...
+	(*mov<mode>_update1): This.  Use Pmode.  Fix argument to
+	avoiding_indexed_address_p.  Add "size" attribute.
+	(*movsf_update2, *movdf_update2): Merge, rename to...
+	(*mov<mode>_update2): This.  Ditto.
+	(*movsf_update3): Use Pmode.  Fix argument to
+	avoiding_indexed_address_p.
+	(*movsf_update4): Ditto.
+	(allocate_stack): Simplify condition.  Adjust pattern names.
+
 2019-04-17  Jakub Jelinek  <jakub@redhat.com>
 
 	PR target/89093

gcc/config/rs6000/rs6000.c

@@ -24010,7 +24010,7 @@ rs6000_split_multireg_move (rtx dst, rtx src)
 		  emit_insn (TARGET_32BIT
 			     ? (TARGET_POWERPC64
 				? gen_movdi_si_update (breg, breg, delta_rtx, nsrc)
-				: gen_movsi_update (breg, breg, delta_rtx, nsrc))
+				: gen_movsi_si_update (breg, breg, delta_rtx, nsrc))
 			     : gen_movdi_di_update (breg, breg, delta_rtx, nsrc));
 		  used_update = true;
 		}
@@ -25486,16 +25486,16 @@ rs6000_emit_allocate_stack_1 (HOST_WIDE_INT size_int, rtx orig_sp)
       size_rtx = tmp_reg;
     }
   
-  if (Pmode == SImode)
+  if (TARGET_32BIT)
     insn = emit_insn (gen_movsi_update_stack (stack_pointer_rtx,
 					      stack_pointer_rtx,
 					      size_rtx,
 					      orig_sp));
   else
-    insn = emit_insn (gen_movdi_di_update_stack (stack_pointer_rtx,
-						 stack_pointer_rtx,
-						 size_rtx,
-						 orig_sp));
+    insn = emit_insn (gen_movdi_update_stack (stack_pointer_rtx,
+					      stack_pointer_rtx,
+					      size_rtx,
+					      orig_sp));
   rtx par = PATTERN (insn);
   gcc_assert (GET_CODE (par) == PARALLEL);
   rtx set = XVECEXP (par, 0, 0);