Commit 57c7a33b by Ian Lance Taylor

compiler: Remove unnecessary check for GCC-specific issue.

    Reviewed-on: https://go-review.googlesource.com/11800

    compiler: remove name of unused parameter to avoid warning
    
    Reviewed-on: https://go-review.googlesource.com/12367

From-SVN: r226007
parent 824478c0
2c985e4781691fea3eb4171de85265bfbc4e4997 19ff97ed3eb07d902bc4b3f97b21c4b6df834ad2
The first line of this file holds the git revision number of the last The first line of this file holds the git revision number of the last
merge done from the gofrontend repository. merge done from the gofrontend repository.
...@@ -133,7 +133,7 @@ Expression::determine_type_no_context() ...@@ -133,7 +133,7 @@ Expression::determine_type_no_context()
// assignment. // assignment.
Expression* Expression*
Expression::convert_for_assignment(Gogo* gogo, Type* lhs_type, Expression::convert_for_assignment(Gogo*, Type* lhs_type,
Expression* rhs, Location location) Expression* rhs, Location location)
{ {
Type* rhs_type = rhs->type(); Type* rhs_type = rhs->type();
...@@ -177,17 +177,6 @@ Expression::convert_for_assignment(Gogo* gogo, Type* lhs_type, ...@@ -177,17 +177,6 @@ Expression::convert_for_assignment(Gogo* gogo, Type* lhs_type,
|| (lhs_type->array_type() != NULL || (lhs_type->array_type() != NULL
&& rhs_type->array_type() != NULL)) && rhs_type->array_type() != NULL))
{ {
// Avoid confusion from zero sized variables which may be
// represented as non-zero-sized.
// TODO(cmang): This check is for a GCC-specific issue, and should be
// removed from the frontend. FIXME.
int64_t lhs_size =
gogo->backend()->type_size(lhs_type->get_backend(gogo));
int64_t rhs_size =
gogo->backend()->type_size(rhs_type->get_backend(gogo));
if (rhs_size == 0 || lhs_size == 0)
return rhs;
// This conversion must be permitted by Go, or we wouldn't have // This conversion must be permitted by Go, or we wouldn't have
// gotten here. // gotten here.
return Expression::make_unsafe_cast(lhs_type, rhs, location); return Expression::make_unsafe_cast(lhs_type, rhs, location);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment