Commit 53f2d033 by Nick Clifton Committed by Nick Clifton

Undid previous delta to dbxout.c

Added comment explaining why.

From-SVN: r19855
parent a9f7d5a1
Mon May 18 15:30:42 1998 Nick Clifton <nickc@cygnus.com>
* dbxout.c (dbxout_parms): Revert to using DECL_ARG_TYPE. Add
comment explaining why.
Mon May 18 13:20:23 1998 Richard Henderson <rth@cygnus.com>
* tree.h (TYPE_SIZE_UNIT): New.
......
......@@ -2274,7 +2274,21 @@ dbxout_parms (parms)
DBX_MEMPARM_STABS_LETTER);
}
dbxout_type (TREE_TYPE (parms), 0, 0);
/* It is quite tempting to use:
dbxout_type (TREE_TYPE (parms), 0, 0);
as the next statement, rather than using DECL_ARG_TYPE(), so
that gcc reports the actual type of the parameter, rather
than the promoted type. This certainly makes GDB's life
easier, at least for some ports. The change is a bad idea
however, since GDB expects to be able access the type without
performing any conversions. So for example, if we were
passing a float to an unprototyped function, gcc will store a
double on the stack, but if we emit a stab saying the type is a
float, then gdb will only read in a single value, and this will
produce an erropneous value. */
dbxout_type (DECL_ARG_TYPE (parms), 0, 0);
current_sym_value = DEBUGGER_ARG_OFFSET (current_sym_value, addr);
dbxout_finish_symbol (parms);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment