Commit 53bbb42e by Tom Tromey Committed by Tom Tromey

re PR java/25283 (gcj generates invalid signature)

	PR java/25283:
	* parse.y (patch_new_array_init): Revert previous patch.
	(lookup_method_invoke): Use size-less array type when creating an
	anonymous constructor.

From-SVN: r108143
parent 67c4e19e
2005-12-06 Tom Tromey <tromey@redhat.com>
PR java/25283:
* parse.y (patch_new_array_init): Revert previous patch.
(lookup_method_invoke): Use size-less array type when creating an
anonymous constructor.
2005-12-05 Tom Tromey <tromey@redhat.com> 2005-12-05 Tom Tromey <tromey@redhat.com>
* parse.y (patch_new_array_init): Don't set length on array. * parse.y (patch_new_array_init): Don't set length on array.
......
...@@ -11204,6 +11204,17 @@ lookup_method_invoke (int lc, tree cl, tree class, tree name, tree arg_list) ...@@ -11204,6 +11204,17 @@ lookup_method_invoke (int lc, tree cl, tree class, tree name, tree arg_list)
/* And promoted */ /* And promoted */
if (TREE_CODE (current_arg) == RECORD_TYPE) if (TREE_CODE (current_arg) == RECORD_TYPE)
current_arg = promote_type (current_arg); current_arg = promote_type (current_arg);
/* If we're building an anonymous constructor call, and one of
the arguments has array type, cast it to a size-less array
type. This prevents us from getting a strange gcj-specific
"sized array" signature in the constructor's signature. */
if (lc && ANONYMOUS_CLASS_P (class)
&& TREE_CODE (current_arg) == POINTER_TYPE
&& TYPE_ARRAY_P (TREE_TYPE (current_arg)))
{
tree elt = TYPE_ARRAY_ELEMENT (TREE_TYPE (current_arg));
current_arg = build_pointer_type (build_java_array_type (elt, -1));
}
atl = tree_cons (NULL_TREE, current_arg, atl); atl = tree_cons (NULL_TREE, current_arg, atl);
} }
...@@ -14857,12 +14868,8 @@ patch_new_array_init (tree type, tree node) ...@@ -14857,12 +14868,8 @@ patch_new_array_init (tree type, tree node)
/* Create a new type. We can't reuse the one we have here by /* Create a new type. We can't reuse the one we have here by
patching its dimension because it originally is of dimension -1 patching its dimension because it originally is of dimension -1
hence reused by gcc. This would prevent triangular arrays. hence reused by gcc. This would prevent triangular arrays. */
Note that we don't pass the length here. If we do that then the type = build_java_array_type (element_type, length);
length will end up in the signature of this type, and hence in
the signature of the anonymous constructor -- but this is not a
valid java signature. */
type = build_java_array_type (element_type, -1);
TREE_TYPE (init) = TREE_TYPE (TREE_CHAIN (TREE_CHAIN (TYPE_FIELDS (type)))); TREE_TYPE (init) = TREE_TYPE (TREE_CHAIN (TREE_CHAIN (TYPE_FIELDS (type))));
TREE_TYPE (node) = promote_type (type); TREE_TYPE (node) = promote_type (type);
TREE_CONSTANT (init) = all_constant; TREE_CONSTANT (init) = all_constant;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment