Skip to content

R
riscv-gcc-1
Commit 50929dd3 by David Edelsohn
Options

rs6000: Don't push stack frame for AIX when debugging and -fcompare-debug. 

AIX pushes a stack frame when debugging is enabled.  With -fcompare-debug
this generates comparison failures because code geneation is different.
This patch disables the stack push for -fcompare-debug that only is used
for internal testing and not for normal debug information generation that
will be consumed by AIX tools.

This patch also removes xfails from testsuite testcases that use
-fcompare-debug and no longer fail on AIX without the stack push difference.

        * config/rs6000/rs6000-logue.c (rs6000_stack_info): Don't push a
        stack frame when debugging and flag_compare_debug is enabled.

testsuite/
        * g++.dg/debug/dwarf2/pr61433.C: Unfail AIX.
        * g++.dg/opt/pr48549.C: Same.
        * g++.dg/opt/pr60002.C: Same.
        * g++.dg/opt/pr80436.C: Same.
        * g++.dg/opt/pr83084.C: Same.
        * g++.dg/other/pr42685.C: Same.
        * gcc.dg/pr41241.c: Same.
        * gcc.dg/pr42629.c: Same.
        * gcc.dg/pr42630.c: Same.
        * gcc.dg/pr42719.c: Same.
        * gcc.dg/pr42728.c: Same.
        * gcc.dg/pr42889.c: Same.
        * gcc.dg/pr42916.c: Same.
        * gcc.dg/pr43084.c: Same.
        * gcc.dg/pr43670.c: Same.
        * gcc.dg/pr44023.c: Same.
        * gcc.dg/pr44971.c: Same.
        * gcc.dg/pr45449.c: Same.
        * gcc.dg/pr46771.c: Same.
        * gcc.dg/pr47684.c: Same.
        * gcc.dg/pr47881.c: Same.
        * gcc.dg/pr48768.c: Same.
        * gcc.dg/pr50017.c: Same.
        * gcc.dg/pr56023.c: Same.
        * gcc.dg/pr64935-1.c: Same.
        * gcc.dg/pr64935-2.c: Same.
        * gcc.dg/pr65521.c: Same.
        * gcc.dg/pr65779.c: Same.
        * gcc.dg/pr65980.c: Same.
        * gcc.dg/pr66688.c: Same.
        * gcc.dg/pr70405.c: Same.
        * gcc.dg/vect/pr49352.c: Same.
parent 9b933c99
Showing with 50 additions and 42 deletions
gcc/ChangeLog
2020-04-25 David Edelsohn <dje.gcc@gmail.com>
* config/rs6000/rs6000-logue.c (rs6000_stack_info): Don't push a
stack frame when debugging and flag_compare_debug is enabled.
2020-04-25 Michael Meissner <meissner@linux.ibm.com>
* config/rs6000/linux64.h (PCREL_SUPPORTED_BY_OS): Define to
......
gcc/config/rs6000/rs6000-logue.c
......@@ -909,7 +909,7 @@ rs6000_stack_info (void)
else if (frame_pointer_needed)
info->push_p = 1;
else if (TARGET_XCOFF && write_symbols != NO_DEBUG)
else if (TARGET_XCOFF && write_symbols != NO_DEBUG && !flag_compare_debug)
info->push_p = 1;
else
......
gcc/testsuite/ChangeLog
2020-04-25 David Edelsohn <dje.gcc@gmail.com>
* g++.dg/debug/dwarf2/pr61433.C: Unfail AIX.
* g++.dg/opt/pr48549.C: Same.
* g++.dg/opt/pr60002.C: Same.
* g++.dg/opt/pr80436.C: Same.
* g++.dg/opt/pr83084.C: Same.
* g++.dg/other/pr42685.C: Same.
* gcc.dg/pr41241.c: Same.
* gcc.dg/pr42629.c: Same.
* gcc.dg/pr42630.c: Same.
* gcc.dg/pr42719.c: Same.
* gcc.dg/pr42728.c: Same.
* gcc.dg/pr42889.c: Same.
* gcc.dg/pr42916.c: Same.
* gcc.dg/pr43084.c: Same.
* gcc.dg/pr43670.c: Same.
* gcc.dg/pr44023.c: Same.
* gcc.dg/pr44971.c: Same.
* gcc.dg/pr45449.c: Same.
* gcc.dg/pr46771.c: Same.
* gcc.dg/pr47684.c: Same.
* gcc.dg/pr47881.c: Same.
* gcc.dg/pr48768.c: Same.
* gcc.dg/pr50017.c: Same.
* gcc.dg/pr56023.c: Same.
* gcc.dg/pr64935-1.c: Same.
* gcc.dg/pr64935-2.c: Same.
* gcc.dg/pr65521.c: Same.
* gcc.dg/pr65779.c: Same.
* gcc.dg/pr65980.c: Same.
* gcc.dg/pr66688.c: Same.
* gcc.dg/pr70405.c: Same.
* gcc.dg/vect/pr49352.c: Same.
2020-04-25 David Edelsohn <dje.gcc@gmail.com>
* gcc.dg/ipa/ipa-sra-19.c: Add -Wno-psabi option on AIX.
2020-04-25 David Edelsohn <dje.gcc@gmail.com>
......
gcc/testsuite/g++.dg/debug/dwarf2/pr61433.C
// PR c++/61433
// { dg-do compile { target c++11 } }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
// { dg-options "-O -fcompare-debug -fno-inline -fno-ipa-pure-const -fipa-sra" }
// { dg-additional-options "-Wno-return-type" }
......
gcc/testsuite/g++.dg/debug/pr46583.C
// PR debug/46583
// { dg-do compile }
// { dg-options "-O -fno-inline -fipa-cp -fipa-cp-clone -fcompare-debug" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
// { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } }
template < typename = unsigned long >struct A
{
......
gcc/testsuite/g++.dg/debug/pr47106.C
// { dg-do compile }
// { dg-options "-O -fpartial-inlining -flto -fconserve-stack -fcompare-debug" }
// { dg-require-effective-target lto }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
// { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } }
void end (int, int) __attribute__ ((__noreturn__));
......
gcc/testsuite/g++.dg/debug/pr56294.C
// { dg-do compile }
// { dg-options "-fno-ipa-sra -fcompare-debug" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
// { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } }
struct comp_cost { int cost; unsigned complexity; };
struct cost_pair { struct iv_cand *cand; };
......
gcc/testsuite/g++.dg/debug/pr56819.C
// PR debug/56819
// { dg-do compile }
// { dg-options "-fcompare-debug" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
// { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } }
template <typename>
struct A
......
gcc/testsuite/g++.dg/debug/pr71432.C
/* { dg-do compile } */
/* { dg-options "-O2 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
/* { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } } */
namespace std
{
......
gcc/testsuite/g++.dg/debug/pr84704.C
// PR c++/84704
// { dg-do compile }
// { dg-options "-g -fcompare-debug -O2" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
// { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } }
int a[1] = { 0 };
......
gcc/testsuite/g++.dg/opt/pr48549.C
// PR rtl-optimization/48549
// { dg-do compile }
// { dg-options "-fcompare-debug -O2" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
__extension__ typedef __PTRDIFF_TYPE__ pdiff_t;
......
gcc/testsuite/g++.dg/opt/pr60002.C
// PR tree-optimization/60002
// { dg-do compile }
// { dg-options "-O2 -fcompare-debug -fdeclone-ctor-dtor -fipa-cp-clone" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
struct A {};
......
gcc/testsuite/g++.dg/opt/pr80436.C
// PR debug/80436
// { dg-do compile { target c++11 } }
// { dg-options "-O3 -fcompare-debug" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
void fn (...);
void foo (int, int, int);
......
gcc/testsuite/g++.dg/opt/pr83084.C
// PR debug/83084
// { dg-do compile }
// { dg-options "-O2 -fcompare-debug -Wno-return-type" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
enum E { F };
template <E = F> struct A {
......
gcc/testsuite/g++.dg/other/pr42685.C
// { dg-do compile }
// { dg-options "-O -funroll-loops -fcompare-debug" }
// { dg-xfail-if "" { powerpc-ibm-aix* } }
void Remap(int n, int *src, int *dst, int *map)
{
......
gcc/testsuite/gcc.dg/pr41241.c
......@@ -2,7 +2,6 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fcompare-debug -g" } */
/* { dg-options "-O2 -fcompare-debug -g -march=i586 -mtune=i586 -fomit-frame-pointer" { target { { i?86-*-* x86_64-*-* } && ia32 } } } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
typedef struct { int t1; int t2; int t3; } *T;
typedef struct { int s; } S;
......
gcc/testsuite/gcc.dg/pr41345.c
/* PR bootstrap/41345 */
/* { dg-do compile } */
/* { dg-options "-O2 -g -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
/* { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } } */
void
foo (int *x)
......
gcc/testsuite/gcc.dg/pr42629.c
......@@ -4,7 +4,6 @@
/* { dg-options "-O1 -fsched-pressure -fschedule-insns -fcompare-debug" { target scheduling } } */
/* { dg-options "-O1 -fcompare-debug" { target { ! scheduling } } } */
/* { dg-require-effective-target int32plus } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int lzo_adler32(int adler, char *buf)
{
......
gcc/testsuite/gcc.dg/pr42630.c
/* { dg-do compile } */
/* { dg-options "-O1 -fvariable-expansion-in-unroller -funroll-loops -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int sum(int *buf, int len)
{
......
gcc/testsuite/gcc.dg/pr42631.c
......@@ -15,7 +15,7 @@
/* { dg-do compile } */
/* { dg-options "-g -O1 -funroll-loops -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
/* { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } } */
void foo()
{
......
gcc/testsuite/gcc.dg/pr42719.c
/* PR tree-optimization/42719 */
/* { dg-do compile } */
/* { dg-options "-O2 -ftracer -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int *v;
......
gcc/testsuite/gcc.dg/pr42728.c
/* PR debug/42728 */
/* { dg-do compile } */
/* { dg-options "-O1 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
void
foo (char *a)
......
gcc/testsuite/gcc.dg/pr42889.c
/* PR rtl-optimization/42889 */
/* { dg-do compile } */
/* { dg-options "-O -fgcse -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
extern int A[], B[];
......
gcc/testsuite/gcc.dg/pr42916.c
/* { dg-do compile } */
/* { dg-options "-O1 -funroll-loops -ftree-vectorize -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int seed;
......
gcc/testsuite/gcc.dg/pr43084.c
/* PR debug/43084 */
/* { dg-do compile } */
/* { dg-options "-O1 -fwhole-program -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
struct S
{
......
gcc/testsuite/gcc.dg/pr43670.c
/* PR debug/43670 */
/* { dg-do compile } */
/* { dg-options "-O -ftree-vrp -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
extern void abort (void);
......
gcc/testsuite/gcc.dg/pr44023.c
......@@ -3,7 +3,6 @@
/* { dg-options "-fcompare-debug -O2" } */
/* { dg-options "-fcompare-debug -O2 -mcpu=ev67" { target alpha*-*-* } } */
/* { dg-require-effective-target int32plus } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
void
foo (unsigned f, long v, unsigned *w, unsigned a, unsigned b, unsigned e, unsigned c, unsigned d)
......
gcc/testsuite/gcc.dg/pr44971.c
/* { dg-do compile } */
/* { dg-options "-O2 -fcompare-debug -w" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
typedef struct
{
......
gcc/testsuite/gcc.dg/pr45449.c
/* { dg-do compile } */
/* { dg-options "-O2 -fno-tree-pre -fno-tree-pta -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
struct S
{
......
gcc/testsuite/gcc.dg/pr46771.c
/* PR debug/46771 */
/* { dg-do compile } */
/* { dg-options "-O -ftree-vectorize -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
unsigned char v[1600];
......
gcc/testsuite/gcc.dg/pr47684.c
/* PR debug/47684 */
/* { dg-do compile } */
/* { dg-options "-O3 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int in[8][4];
int out[4];
......
gcc/testsuite/gcc.dg/pr47881.c
/* PR debug/47881 */
/* { dg-do compile } */
/* { dg-options "-O -fcompare-debug -fno-dce -funroll-loops -fno-web" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
extern int data[];
......
gcc/testsuite/gcc.dg/pr48768.c
/* PR debug/48768 */
/* { dg-do compile } */
/* { dg-options "-O -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int a, b;
......
gcc/testsuite/gcc.dg/pr50017.c
/* PR debug/50017 */
/* { dg-do compile } */
/* { dg-options "-O3 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
struct S { int r, i; };
......
gcc/testsuite/gcc.dg/pr56023.c
/* { dg-do compile } */
/* { dg-options "-O2 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
void
foo (char *c)
......
gcc/testsuite/gcc.dg/pr64935-1.c
/* PR rtl-optimization/64935 */
/* { dg-do compile } */
/* { dg-options "-std=gnu89 -Wno-shift-count-overflow -O2 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int a[] = {}, b[] = {}, c[] = {}, d[] = {}, e[] = {}, f[] = {}, h[] = {};
int g[] = { 0 };
......
gcc/testsuite/gcc.dg/pr64935-2.c
......@@ -2,7 +2,6 @@
/* { dg-do compile } */
/* { dg-options "-O -fschedule-insns --param=max-sched-ready-insns=1 -fcompare-debug" } */
/* { dg-require-effective-target scheduling } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
void
foo (int *data, unsigned len, const int qlp_coeff[],
......
gcc/testsuite/gcc.dg/pr65521.c
/* PR ipa/65521 */
/* { dg-do compile } */
/* { dg-options "-O2 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
struct S { int s; };
int f6 (void *, unsigned long);
......
gcc/testsuite/gcc.dg/pr65779.c
/* PR debug/65779 */
/* { dg-do assemble } */
/* { dg-options "-O2 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
unsigned long
foo (unsigned long x, unsigned char *y, unsigned int z)
......
gcc/testsuite/gcc.dg/pr65980.c
/* PR rtl-optimization/65980 */
/* { dg-do compile } */
/* { dg-options "-O3 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
typedef struct { int b; } A;
void (*a) (int);
......
gcc/testsuite/gcc.dg/pr66688.c
/* PR tree-optimization/66688 */
/* { dg-do compile } */
/* { dg-options "-O2 -fno-reorder-blocks -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
struct fdt_header { unsigned magic; } *a;
......
gcc/testsuite/gcc.dg/pr70405.c
......@@ -2,7 +2,6 @@
/* { dg-do compile } */
/* { dg-options "-O2 -fcompare-debug" } */
/* { dg-additional-options "-mavx512f" { target i?86-*-* x86_64-*-* } } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
typedef short V __attribute__ ((vector_size (32)));
......
gcc/testsuite/gcc.dg/torture/pr59166.c
/* PR rtl-optimization/59166 */
/* { dg-additional-options "-fcompare-debug" } */
/* { dg-xfail-if "compare-debug failure" { powerpc-ibm-aix* } } */
/* { dg-xfail-if "AIX compare debug" { powerpc-ibm-aix* } } */
int a, b, c, f, g;
......
gcc/testsuite/gcc.dg/vect/pr49352.c
/* PR tree-optimization/49352 */
/* { dg-do compile } */
/* { dg-additional-options "-O2 -fcompare-debug" } */
/* { dg-xfail-if "" { powerpc-ibm-aix* } } */
int
foo (int *x, int *y, int n)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment