Commit 4f40164a by David Malcolm

analyzer: fix ICE on failed casts [PR 93777]

PR analyzer/93777 reports ICEs in a Fortran and C++ case involving
a cast of a NULL pointer to a REFERENCE_TYPE.

In both cases the call to build_cast fails and returns a NULL type, but
region_model::maybe_cast_1 asserts that a non-NULL type was returned.

This patch fixes the ICEs by converting the assertion to a conditional.

gcc/analyzer/ChangeLog:
	PR analyzer/93777
	* region-model.cc (region_model::maybe_cast_1): Replace assertion
	that build_cast returns non-NULL with a conditional, falling
	through to the logic which returns a new unknown value of the
	desired type if it fails.

gcc/testsuite/ChangeLog:
	PR analyzer/93777
	* g++.dg/analyzer/pr93777.C: New test.
	* gfortran.dg/analyzer/pr93777.f90: New test.
parent 2e623393
2020-02-18 David Malcolm <dmalcolm@redhat.com> 2020-02-18 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93777
* region-model.cc (region_model::maybe_cast_1): Replace assertion
that build_cast returns non-NULL with a conditional, falling
through to the logic which returns a new unknown value of the
desired type if it fails.
2020-02-18 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93778 PR analyzer/93778
* engine.cc (impl_region_model_context::on_unknown_tree_code): * engine.cc (impl_region_model_context::on_unknown_tree_code):
Rename to... Rename to...
......
...@@ -5089,10 +5089,9 @@ region_model::maybe_cast_1 (tree dst_type, svalue_id sid) ...@@ -5089,10 +5089,9 @@ region_model::maybe_cast_1 (tree dst_type, svalue_id sid)
/* Attempt to cast constants. */ /* Attempt to cast constants. */
if (tree src_cst = sval->maybe_get_constant ()) if (tree src_cst = sval->maybe_get_constant ())
{ {
tree dst = build_cast (dst_type, src_cst); if (tree dst = build_cast (dst_type, src_cst))
gcc_assert (dst != NULL_TREE); if (CONSTANT_CLASS_P (dst))
if (CONSTANT_CLASS_P (dst)) return get_or_create_constant_svalue (dst);
return get_or_create_constant_svalue (dst);
} }
/* Otherwise, return a new unknown value. */ /* Otherwise, return a new unknown value. */
......
2020-02-18 David Malcolm <dmalcolm@redhat.com> 2020-02-18 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93777
* g++.dg/analyzer/pr93777.C: New test.
* gfortran.dg/analyzer/pr93777.f90: New test.
2020-02-18 David Malcolm <dmalcolm@redhat.com>
PR analyzer/93778 PR analyzer/93778
* gfortran.dg/analyzer/pr93778.f90: New test. * gfortran.dg/analyzer/pr93778.f90: New test.
......
#include "../../g++.old-deja/g++.pt/spec36.C"
! { dg-additional-options "-O0 -Wno-analyzer-possible-null-dereference -Wno-analyzer-null-dereference -Wno-analyzer-malloc-leak" }
program cb
implicit none
type :: jn
real, allocatable :: ie
character(len = :), allocatable :: e5
end type jn
real, parameter :: gm = 5.0
block
type(jn) :: r2
r2 = jn (gm, "")
call vz (r2%ie, gm)
end block
contains
subroutine vz (arg1, arg2)
real :: arg1, arg2
if (arg1 .ne. arg2) STOP 1
end subroutine vz
end program cb
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment