re PR c++/28743 (ICE with invalid specialization)

/cp
2008-02-14  Paolo Carlini  <pcarlini@suse.de>

        PR c++/28743
        * pt.c (determine_specialization): In case of function templates,
	when the type of DECL does not match FN there is no match.

/testsuite
2008-02-14  Paolo Carlini  <pcarlini@suse.de>

        PR c++/28743
	* g++.dg/template/nontype17.C: New.
        * g++.dg/template/nontype16.C: Add error.

From-SVN: r132316

gcc/cp/ChangeLog

+2008-02-14  Paolo Carlini  <pcarlini@suse.de>
+
+        PR c++/28743
+        * pt.c (determine_specialization): In case of function templates,
+	when the type of DECL does not match FN there is no match.
+
 2008-02-13  Jakub Jelinek  <jakub@redhat.com>
 	    Manuel Lopez-Ibanez  <manu@gcc.gnu.org>
 

gcc/cp/pt.c

@@ -1561,12 +1561,9 @@ determine_specialization (tree template_id,
 	     no partial specializations of functions.  Therefore, if
 	     the type of DECL does not match FN, there is no
 	     match.  */
-	  if (tsk == tsk_template)
-	    {
-	      if (compparms (fn_arg_types, decl_arg_types))
-		candidates = tree_cons (NULL_TREE, fn, candidates);
-	      continue;
-	    }
+	  if (tsk == tsk_template
+	      && !compparms (fn_arg_types, decl_arg_types))
+	    continue;
 
 	  /* See whether this function might be a specialization of this
 	     template.  */

gcc/testsuite/ChangeLog

+2008-02-14  Paolo Carlini  <pcarlini@suse.de>
+
+        PR c++/28743
+	* g++.dg/template/nontype17.C: New.
+        * g++.dg/template/nontype16.C: Add error.
+
 2008-02-13  Jakub Jelinek  <jakub@redhat.com>
 
 	PR c++/35138

gcc/testsuite/g++.dg/template/nontype16.C

@@ -5,5 +5,5 @@ template<int> struct A
     template<typename> void foo();
 };
 
-template<> template<struct T> void A<0>::foo() {} // { dg-error "not a valid type" }
+template<> template<struct T> void A<0>::foo() {} // { dg-error "not a valid type|match" }
  

gcc/testsuite/g++.dg/template/nontype17.C

+// PR c++/28743
+
+template<int> struct A
+{
+    template<typename> void foo();
+};
+
+template<int> template<typename> void A<0>::foo() {} // { dg-error "match" }