Commit 44d90fe1 by Paolo Carlini Committed by Paolo Carlini

c.opt ([Wpointer-arith]): Enabled by -Wpedantic, as documented.

/c-family
2013-04-24  Paolo Carlini  <paolo.carlini@oracle.com>
            Manuel Lopez-Ibanez  <manu@gcc.gnu.org>

	* c.opt ([Wpointer-arith]): Enabled by -Wpedantic, as documented.
	* c-common.c (pointer_int_sum): Change -Wpointer-arith pedwarns
	to simply use OPT_Wpointer_arith.
	(c_sizeof_or_alignof_type): Likewise.

/cp
2013-04-24  Paolo Carlini  <paolo.carlini@oracle.com>

	* typeck.c (cxx_sizeof_or_alignof_type): Change -Wpointer-arith
	pedwarn to simply use OPT_Wpointer_arith.
	(cp_build_unary_op): Likewise.

/c
2013-04-24  Paolo Carlini  <paolo.carlini@oracle.com>

	* c-typeck.c (pointer_diff): Change -Wpointer-arith pedwarns
	to simply use OPT_Wpointer_arith.
	(build_unary_op): Likewise.

/testsuite
2013-04-24  Paolo Carlini  <paolo.carlini@oracle.com>

	* c-c++-common/Wpointer-arith-1.c: New.

Co-Authored-By: Manuel López-Ibáñez <manu@gcc.gnu.org>

From-SVN: r198256
parent f6ce35ac
2013-04-24 Paolo Carlini <paolo.carlini@oracle.com> 2013-04-24 Paolo Carlini <paolo.carlini@oracle.com>
Manuel Lopez-Ibanez <manu@gcc.gnu.org>
* c.opt ([Wpointer-arith]): Enabled by -Wpedantic, as documented.
* c-common.c (pointer_int_sum): Change -Wpointer-arith pedwarns
to simply use OPT_Wpointer_arith.
(c_sizeof_or_alignof_type): Likewise.
2013-04-24 Paolo Carlini <paolo.carlini@oracle.com>
* c-cppbuiltin.c (c_cpp_builtins): Define __GXX_EXPERIMENTAL_CXX1Y__. * c-cppbuiltin.c (c_cpp_builtins): Define __GXX_EXPERIMENTAL_CXX1Y__.
......
...@@ -4280,13 +4280,13 @@ pointer_int_sum (location_t loc, enum tree_code resultcode, ...@@ -4280,13 +4280,13 @@ pointer_int_sum (location_t loc, enum tree_code resultcode,
if (TREE_CODE (TREE_TYPE (result_type)) == VOID_TYPE) if (TREE_CODE (TREE_TYPE (result_type)) == VOID_TYPE)
{ {
pedwarn (loc, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (loc, OPT_Wpointer_arith,
"pointer of type %<void *%> used in arithmetic"); "pointer of type %<void *%> used in arithmetic");
size_exp = integer_one_node; size_exp = integer_one_node;
} }
else if (TREE_CODE (TREE_TYPE (result_type)) == FUNCTION_TYPE) else if (TREE_CODE (TREE_TYPE (result_type)) == FUNCTION_TYPE)
{ {
pedwarn (loc, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (loc, OPT_Wpointer_arith,
"pointer to a function used in arithmetic"); "pointer to a function used in arithmetic");
size_exp = integer_one_node; size_exp = integer_one_node;
} }
...@@ -4864,8 +4864,8 @@ c_sizeof_or_alignof_type (location_t loc, ...@@ -4864,8 +4864,8 @@ c_sizeof_or_alignof_type (location_t loc,
{ {
if (is_sizeof) if (is_sizeof)
{ {
if (complain && (pedantic || warn_pointer_arith)) if (complain && warn_pointer_arith)
pedwarn (loc, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (loc, OPT_Wpointer_arith,
"invalid application of %<sizeof%> to a function type"); "invalid application of %<sizeof%> to a function type");
else if (!complain) else if (!complain)
return error_mark_node; return error_mark_node;
...@@ -4888,8 +4888,8 @@ c_sizeof_or_alignof_type (location_t loc, ...@@ -4888,8 +4888,8 @@ c_sizeof_or_alignof_type (location_t loc,
else if (type_code == VOID_TYPE || type_code == ERROR_MARK) else if (type_code == VOID_TYPE || type_code == ERROR_MARK)
{ {
if (type_code == VOID_TYPE if (type_code == VOID_TYPE
&& complain && (pedantic || warn_pointer_arith)) && complain && warn_pointer_arith)
pedwarn (loc, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (loc, OPT_Wpointer_arith,
"invalid application of %qs to a void type", op_name); "invalid application of %qs to a void type", op_name);
else if (!complain) else if (!complain)
return error_mark_node; return error_mark_node;
......
...@@ -614,7 +614,7 @@ C++ ObjC++ Var(warn_pmf2ptr) Init(1) Warning ...@@ -614,7 +614,7 @@ C++ ObjC++ Var(warn_pmf2ptr) Init(1) Warning
Warn when converting the type of pointers to member functions Warn when converting the type of pointers to member functions
Wpointer-arith Wpointer-arith
C ObjC C++ ObjC++ Var(warn_pointer_arith) Warning C ObjC C++ ObjC++ Var(warn_pointer_arith) Warning LangEnabledBy(C ObjC C++ ObjC++,Wpedantic)
Warn about function pointer arithmetic Warn about function pointer arithmetic
Wpointer-sign Wpointer-sign
......
2013-04-24 Paolo Carlini <paolo.carlini@oracle.com>
* c-typeck.c (pointer_diff): Change -Wpointer-arith pedwarns
to simply use OPT_Wpointer_arith.
(build_unary_op): Likewise.
2013-04-03 Jakub Jelinek <jakub@redhat.com> 2013-04-03 Jakub Jelinek <jakub@redhat.com>
PR c/19449 PR c/19449
......
...@@ -3333,10 +3333,10 @@ pointer_diff (location_t loc, tree op0, tree op1) ...@@ -3333,10 +3333,10 @@ pointer_diff (location_t loc, tree op0, tree op1)
if (TREE_CODE (target_type) == VOID_TYPE) if (TREE_CODE (target_type) == VOID_TYPE)
pedwarn (loc, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (loc, OPT_Wpointer_arith,
"pointer of type %<void *%> used in subtraction"); "pointer of type %<void *%> used in subtraction");
if (TREE_CODE (target_type) == FUNCTION_TYPE) if (TREE_CODE (target_type) == FUNCTION_TYPE)
pedwarn (loc, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (loc, OPT_Wpointer_arith,
"pointer to a function used in subtraction"); "pointer to a function used in subtraction");
/* If the conversion to ptrdiff_type does anything like widening or /* If the conversion to ptrdiff_type does anything like widening or
...@@ -3663,10 +3663,10 @@ build_unary_op (location_t location, ...@@ -3663,10 +3663,10 @@ build_unary_op (location_t location,
|| TREE_CODE (TREE_TYPE (argtype)) == VOID_TYPE) || TREE_CODE (TREE_TYPE (argtype)) == VOID_TYPE)
{ {
if (code == PREINCREMENT_EXPR || code == POSTINCREMENT_EXPR) if (code == PREINCREMENT_EXPR || code == POSTINCREMENT_EXPR)
pedwarn (location, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (location, OPT_Wpointer_arith,
"wrong type argument to increment"); "wrong type argument to increment");
else else
pedwarn (location, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (location, OPT_Wpointer_arith,
"wrong type argument to decrement"); "wrong type argument to decrement");
} }
......
2013-04-24 Paolo Carlini <paolo.carlini@oracle.com>
* typeck.c (cxx_sizeof_or_alignof_type): Change -Wpointer-arith
pedwarn to simply use OPT_Wpointer_arith.
(cp_build_unary_op): Likewise.
2013-04-24 Jason Merrill <jason@redhat.com> 2013-04-24 Jason Merrill <jason@redhat.com>
N3648: init-captures are named. N3648: init-captures are named.
......
...@@ -1522,7 +1522,7 @@ cxx_sizeof_or_alignof_type (tree type, enum tree_code op, bool complain) ...@@ -1522,7 +1522,7 @@ cxx_sizeof_or_alignof_type (tree type, enum tree_code op, bool complain)
if (TREE_CODE (type) == METHOD_TYPE) if (TREE_CODE (type) == METHOD_TYPE)
{ {
if (complain) if (complain)
pedwarn (input_location, pedantic ? OPT_Wpedantic : OPT_Wpointer_arith, pedwarn (input_location, OPT_Wpointer_arith,
"invalid application of %qs to a member function", "invalid application of %qs to a member function",
operator_name_info[(int) op].name); operator_name_info[(int) op].name);
value = size_one_node; value = size_one_node;
...@@ -5601,8 +5601,7 @@ cp_build_unary_op (enum tree_code code, tree xarg, int noconvert, ...@@ -5601,8 +5601,7 @@ cp_build_unary_op (enum tree_code code, tree xarg, int noconvert,
else if (!TYPE_PTROB_P (argtype)) else if (!TYPE_PTROB_P (argtype))
{ {
if (complain & tf_error) if (complain & tf_error)
pedwarn (input_location, pedwarn (input_location, OPT_Wpointer_arith,
pedantic ? OPT_Wpedantic : OPT_Wpointer_arith,
(code == PREINCREMENT_EXPR (code == PREINCREMENT_EXPR
|| code == POSTINCREMENT_EXPR) || code == POSTINCREMENT_EXPR)
? G_("ISO C++ forbids incrementing a pointer of type %qT") ? G_("ISO C++ forbids incrementing a pointer of type %qT")
......
2013-04-24 Paolo Carlini <paolo.carlini@oracle.com> 2013-04-24 Paolo Carlini <paolo.carlini@oracle.com>
* c-c++-common/Wpointer-arith-1.c: New.
2013-04-24 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/cpp1y/cxx1y_macro.C: New. * g++.dg/cpp1y/cxx1y_macro.C: New.
2013-04-24 Paolo Carlini <paolo.carlini@oracle.com> 2013-04-24 Paolo Carlini <paolo.carlini@oracle.com>
......
/* { dg-do compile } */
/* { dg-options "-Wpedantic -Wno-pointer-arith" } */
void h(void)
{
typedef void (*pft) ();
typedef void (ft) ();
void *pv = 0;
pft pf = 0;
pv++;
pf++;
--pv;
--pf;
pv += 1;
pf += 1;
pv = pv - 1;
pf = pf - 1;
sizeof (void);
sizeof (ft);
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment