Commit 3ce5fa4f by Nathan Sidwell Committed by Nathan Sidwell

re PR c++/23797 (ICE on typename outside template)

cp:
	PR c++/23797
	* parser.c (cp_parser_functional_cast): Cope when TYPE is not a
	TYPE_DECL.  Use dependent_type_p to check type.
	* pt.c (uses_template_parms_p): Use dependent_type_p for a
	TYPE_DECL.
	(type_dependent_expression_p): Assert we've not been given a
	TYPE_DECL.
testsuite:
	PR c++/23797
	* g++.dg/other/typename8.C: New.

From-SVN: r105312
parent 51b15ede
2005-10-12 Nathan Sidwell <nathan@codesourcery.com> 2005-10-12 Nathan Sidwell <nathan@codesourcery.com>
PR c++/23797
* parser.c (cp_parser_functional_cast): Cope when TYPE is not a
TYPE_DECL. Use dependent_type_p to check type.
* pt.c (uses_template_parms_p): Use dependent_type_p for a
TYPE_DECL.
(type_dependent_expression_p): Assert we've not been given a
TYPE_DECL.
PR c++/21117 PR c++/21117
* decl.c (check_function_type): Correctly overwrite incomplete * decl.c (check_function_type): Correctly overwrite incomplete
return type with void type. return type with void type.
......
...@@ -3956,6 +3956,7 @@ cp_parser_postfix_expression (cp_parser *parser, bool address_p, bool cast_p) ...@@ -3956,6 +3956,7 @@ cp_parser_postfix_expression (cp_parser *parser, bool address_p, bool cast_p)
/* Consume the `typename' token. */ /* Consume the `typename' token. */
cp_lexer_consume_token (parser->lexer); cp_lexer_consume_token (parser->lexer);
/* Look for the optional `::' operator. */ /* Look for the optional `::' operator. */
cp_parser_global_scope_opt (parser, cp_parser_global_scope_opt (parser,
/*current_scope_valid_p=*/false); /*current_scope_valid_p=*/false);
...@@ -15355,8 +15356,10 @@ cp_parser_functional_cast (cp_parser* parser, tree type) ...@@ -15355,8 +15356,10 @@ cp_parser_functional_cast (cp_parser* parser, tree type)
cast = build_functional_cast (type, expression_list); cast = build_functional_cast (type, expression_list);
/* [expr.const]/1: In an integral constant expression "only type /* [expr.const]/1: In an integral constant expression "only type
conversions to integral or enumeration type can be used". */ conversions to integral or enumeration type can be used". */
if (cast != error_mark_node && !type_dependent_expression_p (type) if (TREE_CODE (type) == TYPE_DECL)
&& !INTEGRAL_OR_ENUMERATION_TYPE_P (TREE_TYPE (type))) type = TREE_TYPE (type);
if (cast != error_mark_node && !dependent_type_p (type)
&& !INTEGRAL_OR_ENUMERATION_TYPE_P (type))
{ {
if (cp_parser_non_integral_constant_expression if (cp_parser_non_integral_constant_expression
(parser, "a call to a constructor")) (parser, "a call to a constructor"))
......
...@@ -4982,6 +4982,8 @@ uses_template_parms (tree t) ...@@ -4982,6 +4982,8 @@ uses_template_parms (tree t)
else if (TREE_CODE (t) == TREE_LIST) else if (TREE_CODE (t) == TREE_LIST)
dependent_p = (uses_template_parms (TREE_VALUE (t)) dependent_p = (uses_template_parms (TREE_VALUE (t))
|| uses_template_parms (TREE_CHAIN (t))); || uses_template_parms (TREE_CHAIN (t)));
else if (TREE_CODE (t) == TYPE_DECL)
dependent_p = dependent_type_p (TREE_TYPE (t));
else if (DECL_P (t) else if (DECL_P (t)
|| EXPR_P (t) || EXPR_P (t)
|| TREE_CODE (t) == TEMPLATE_PARM_INDEX || TREE_CODE (t) == TEMPLATE_PARM_INDEX
...@@ -12442,6 +12444,8 @@ type_dependent_expression_p (tree expression) ...@@ -12442,6 +12444,8 @@ type_dependent_expression_p (tree expression)
return false; return false;
} }
gcc_assert (TREE_CODE (expression) != TYPE_DECL);
return (dependent_type_p (TREE_TYPE (expression))); return (dependent_type_p (TREE_TYPE (expression)));
} }
......
2005-10-12 Nathan Sidwell <nathan@codesourcery.com> 2005-10-12 Nathan Sidwell <nathan@codesourcery.com>
PR c++/23797
* g++.dg/other/typename8.C: New.
PR c++/21117 PR c++/21117
* g++.dg/other/return1.C: New. * g++.dg/other/return1.C: New.
// Copyright (C) 2005 Free Software Foundation, Inc.
// Contributed by Nathan Sidwell 12 Oct 2005 <nathan@codesourcery.com>
// PR 23797:ICE
// Origin: Volker Reichelt <reichelt@gcc.gnu.org>
struct A { typedef int X; };
int i = typename A::X();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment