jit: gcc_jit_context_new_binary_op check res type

gcc/jit/ChangeLog:
2019-07-04  Andrea Corallo <andrea.corallo@arm.com>

	* libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to be a
	numeric type.

gcc/testsuite/ChangeLog:
2019-07-04  Andrea Corallo <andrea.corallo@arm.com>

	* jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c:
	New testcase.

From-SVN: r273089

gcc/jit/ChangeLog

 2019-07-04  Andrea Corallo <andrea.corallo@arm.com>
 
+	* libgccjit.c (gcc_jit_context_new_binary_op): Check result_type to be a
+	numeric type.
+
+2019-07-04  Andrea Corallo <andrea.corallo@arm.com>
+
 	* docs/topics/compatibility.rst (LIBGCCJIT_ABI_12): New ABI tag.
 	* docs/topics/types.rst: Add gcc_jit_context_new_bitfield.
 	* jit-common.h (namespace recording): Add class bitfield.

gcc/jit/libgccjit.c

@@ -1385,6 +1385,12 @@ gcc_jit_context_new_binary_op (gcc_jit_context *ctxt,
     a->get_type ()->get_debug_string (),
     b->get_debug_string (),
     b->get_type ()->get_debug_string ());
+  RETURN_NULL_IF_FAIL_PRINTF4 (
+    result_type->is_numeric (), ctxt, loc,
+    "gcc_jit_binary_op %i with operands a: %s b: %s "
+    "has non numeric result_type: %s",
+    op, a->get_debug_string (), b->get_debug_string (),
+    result_type->get_debug_string ());
 
   return (gcc_jit_rvalue *)ctxt->new_binary_op (loc, op, result_type, a, b);
 }

gcc/testsuite/ChangeLog

+2019-07-04  Andrea Corallo <andrea.corallo@arm.com>
+
+	* jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c:
+	New testcase.
+
 2019-07-04  Wilco Dijkstra  <wdijkstr@arm.com>
 
 	* gcc.dg/tree-ssa/cunroll-15.c: Remove XFAIL on arm.

gcc/testsuite/jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c

+#include <stdlib.h>
+#include <stdio.h>
+
+#include "libgccjit.h"
+
+#include "harness.h"
+
+/* Try to create a binary operator with invalid result type.  */
+
+void
+create_code (gcc_jit_context *ctxt, void *user_data)
+{
+  gcc_jit_type *int_type =
+    gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_INT);
+  gcc_jit_type *void_ptr_type =
+    gcc_jit_context_get_type (ctxt, GCC_JIT_TYPE_VOID_PTR);
+
+  gcc_jit_context_new_binary_op (
+    ctxt,
+    NULL,
+    GCC_JIT_BINARY_OP_MINUS,
+    void_ptr_type,
+    gcc_jit_context_new_rvalue_from_int (ctxt,
+					 int_type,
+					 1),
+    gcc_jit_context_new_rvalue_from_int (ctxt,
+					 int_type,
+					 2));
+}
+
+void
+verify_code (gcc_jit_context *ctxt, gcc_jit_result *result)
+{
+  CHECK_VALUE (result, NULL);
+
+  /* Verify that the correct error message was emitted.	 */
+  CHECK_STRING_VALUE (gcc_jit_context_get_first_error (ctxt),
+		      "gcc_jit_context_new_binary_op: gcc_jit_binary_op 1 with"
+		      " operands a: (int)1 b: (int)2 has non numeric "
+		      "result_type: void *");
+}