Commit 2a26aed6 by Tamar Christina Committed by Tamar Christina

Arm: Add HF modes to ANY iterators

The iterator ANY64 are used in various general split patterns and is supposed
to contain all 64 bit modes.

For some reason the pattern has HI but not HF.  This adds HF so that general
64 bit splits are generated for these modes as well.  These are required
by various split patterns that expect them to be there.

gcc/ChangeLog:

	PR target/88850
	* config/arm/iterators.md (ANY64): Add V4HF.

gcc/testsuite/ChangeLog:

	PR target/88850
	* gcc.target/arm/pr88850-2.c: New test.
	* lib/target-supports.exp
	(check_effective_target_arm_neon_softfp_fp16_ok_nocache,
	check_effective_target_arm_neon_softfp_fp16_ok,
	add_options_for_arm_neon_softfp_fp16): New.

From-SVN: r268884
parent bb2a18a3
2019-02-14 Tamar Christina <tamar.christina@arm.com>
PR target/88850
* config/arm/iterators.md (ANY64): Add V4HF.
2019-02-14 Martin Liska <mliska@suse.cz> 2019-02-14 Martin Liska <mliska@suse.cz>
PR rtl-optimization/89242 PR rtl-optimization/89242
......
...@@ -24,9 +24,9 @@ ...@@ -24,9 +24,9 @@
;;---------------------------------------------------------------------------- ;;----------------------------------------------------------------------------
;; A list of modes that are exactly 64 bits in size. This is used to expand ;; A list of modes that are exactly 64 bits in size. This is used to expand
;; some splits that are the same for all modes when operating on ARM ;; some splits that are the same for all modes when operating on ARM
;; registers. ;; registers.
(define_mode_iterator ANY64 [DI DF V8QI V4HI V2SI V2SF]) (define_mode_iterator ANY64 [DI DF V8QI V4HI V4HF V2SI V2SF])
(define_mode_iterator ANY128 [V2DI V2DF V16QI V8HI V4SI V4SF]) (define_mode_iterator ANY128 [V2DI V2DF V16QI V8HI V4SI V4SF])
......
2019-02-14 Tamar Christina <tamar.christina@arm.com>
PR target/88850
* gcc.target/arm/pr88850-2.c: New test.
* lib/target-supports.exp
(check_effective_target_arm_neon_softfp_fp16_ok_nocache,
check_effective_target_arm_neon_softfp_fp16_ok,
add_options_for_arm_neon_softfp_fp16): New.
2019-02-14 Matthew Malcomson <matthew.malcomson@arm.com> 2019-02-14 Matthew Malcomson <matthew.malcomson@arm.com>
* gcc.dg/rtl/arm/ldrd-peepholes.c: Restrict testcase. * gcc.dg/rtl/arm/ldrd-peepholes.c: Restrict testcase.
......
/* PR target/88850. */
/* { dg-do compile } */
/* { dg-additional-options "-O2 -march=armv7-a -fdump-rtl-final" } */
/* { dg-add-options arm_neon_softfp_fp16 } */
/* { dg-require-effective-target arm_neon_softfp_fp16_ok } */
#include <arm_neon.h>
extern void c (int, float16x4_t);
void a (float16x4_t b)
{
c (0, b);
}
/* Check that these 64-bit moves are done in SI. */
/* { dg-final { scan-rtl-dump "_movsi_vfp" "final" } } */
...@@ -3785,6 +3785,44 @@ proc check_effective_target_arm_neon_fp16_ok { } { ...@@ -3785,6 +3785,44 @@ proc check_effective_target_arm_neon_fp16_ok { } {
check_effective_target_arm_neon_fp16_ok_nocache] check_effective_target_arm_neon_fp16_ok_nocache]
} }
# Return 1 if this is an ARM target supporting -mfpu=neon-fp16
# and -mfloat-abi=softfp together. Some multilibs may be
# incompatible with these options. Also set et_arm_neon_softfp_fp16_flags to
# the best options to add.
proc check_effective_target_arm_neon_softfp_fp16_ok_nocache { } {
global et_arm_neon_softfp_fp16_flags
global et_arm_neon_flags
set et_arm_neon_softfp_fp16_flags ""
if { [check_effective_target_arm32]
&& [check_effective_target_arm_neon_ok] } {
foreach flags {"-mfpu=neon-fp16 -mfloat-abi=softfp"
"-mfloat-abi=softfp -mfp16-format=ieee"
"-mfpu=neon-fp16 -mfloat-abi=softfp -mfp16-format=ieee"} {
if { [check_no_compiler_messages_nocache arm_neon_softfp_fp16_ok object {
#include "arm_neon.h"
float16x4_t
foo (float32x4_t arg)
{
return vcvt_f16_f32 (arg);
}
} "$et_arm_neon_flags $flags"] } {
set et_arm_neon_softfp_fp16_flags [concat $et_arm_neon_flags $flags]
return 1
}
}
}
return 0
}
proc check_effective_target_arm_neon_softfp_fp16_ok { } {
return [check_cached_effective_target arm_neon_softfp_fp16_ok \
check_effective_target_arm_neon_softfp_fp16_ok_nocache]
}
proc check_effective_target_arm_neon_fp16_hw { } { proc check_effective_target_arm_neon_fp16_hw { } {
if {! [check_effective_target_arm_neon_fp16_ok] } { if {! [check_effective_target_arm_neon_fp16_ok] } {
return 0 return 0
...@@ -3808,6 +3846,14 @@ proc add_options_for_arm_neon_fp16 { flags } { ...@@ -3808,6 +3846,14 @@ proc add_options_for_arm_neon_fp16 { flags } {
return "$flags $et_arm_neon_fp16_flags" return "$flags $et_arm_neon_fp16_flags"
} }
proc add_options_for_arm_neon_softfp_fp16 { flags } {
if { ! [check_effective_target_arm_neon_softfp_fp16_ok] } {
return "$flags"
}
global et_arm_neon_softfp_fp16_flags
return "$flags $et_arm_neon_softfp_fp16_flags"
}
# Return 1 if this is an ARM target supporting the FP16 alternative # Return 1 if this is an ARM target supporting the FP16 alternative
# format. Some multilibs may be incompatible with the options needed. Also # format. Some multilibs may be incompatible with the options needed. Also
# set et_arm_neon_fp16_flags to the best options to add. # set et_arm_neon_fp16_flags to the best options to add.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment