Skip to content

R
riscv-gcc-1
Commit 29e9bc10 by Srinath Parvathaneni
Options

arm: Fix the MVE ACLE vbicq intrinsics. 

Following MVE intrinsic testcases are failing in GCC testsuite.

Directory: gcc.target/arm/mve/intrinsics/
Testcases: vbicq_f16.c, vbicq_f32.c, vbicq_s16.c, vbicq_s32.c, vbicq_s8.c
,vbicq_u16.c, vbicq_u32.c and vbicq_u8.c.

This patch fixes the vbicq intrinsics by modifying the intrinsic parameters
and polymorphic variants in "arm_mve.h" header file.

	Backported from mainline
	2020-06-04  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

gcc/
	* config/arm/arm_mve.h (__arm_vbicq_n_u16): Correct the intrinsic
	arguments.
	(__arm_vbicq_n_s16): Likewise.
	(__arm_vbicq_n_u32): Likewise.
	(__arm_vbicq_n_s32): Likewise.
	(__arm_vbicq): Modify polymorphic variant.

gcc/testsuite/
	* gcc.target/arm/mve/intrinsics/vbicq_f16.c: Modify.
	* gcc.target/arm/mve/intrinsics/vbicq_f32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_n_s16.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_n_s32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_n_u16.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_n_u32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_s16.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_s32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_s8.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_u16.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_u32.c: Likewise.
	* gcc.target/arm/mve/intrinsics/vbicq_u8.c: Likewise.
parent aac5ae14
Showing with 28 additions and 16 deletions
gcc/config/arm/arm_mve.h
......@@ -6361,7 +6361,7 @@ __arm_vorrq_n_u16 (uint16x8_t __a, const int __imm)
__extension__ extern __inline uint16x8_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq_n_u16 (uint16x8_t __a, const uint16_t __imm)
__arm_vbicq_n_u16 (uint16x8_t __a, const int __imm)
{
return __builtin_mve_vbicq_n_uv8hi (__a, __imm);
}
......@@ -6473,7 +6473,7 @@ __arm_vorrq_n_s16 (int16x8_t __a, const int __imm)
__extension__ extern __inline int16x8_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq_n_s16 (int16x8_t __a, const int16_t __imm)
__arm_vbicq_n_s16 (int16x8_t __a, const int __imm)
{
return __builtin_mve_vbicq_n_sv8hi (__a, __imm);
}
......@@ -6564,7 +6564,7 @@ __arm_vorrq_n_u32 (uint32x4_t __a, const int __imm)
__extension__ extern __inline uint32x4_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq_n_u32 (uint32x4_t __a, const uint32_t __imm)
__arm_vbicq_n_u32 (uint32x4_t __a, const int __imm)
{
return __builtin_mve_vbicq_n_uv4si (__a, __imm);
}
......@@ -6676,7 +6676,7 @@ __arm_vorrq_n_s32 (int32x4_t __a, const int __imm)
__extension__ extern __inline int32x4_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq_n_s32 (int32x4_t __a, const int32_t __imm)
__arm_vbicq_n_s32 (int32x4_t __a, const int __imm)
{
return __builtin_mve_vbicq_n_sv4si (__a, __imm);
}
......@@ -23182,7 +23182,7 @@ __arm_vorrq (uint16x8_t __a, const int __imm)
__extension__ extern __inline uint16x8_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq (uint16x8_t __a, const uint16_t __imm)
__arm_vbicq (uint16x8_t __a, const int __imm)
{
return __arm_vbicq_n_u16 (__a, __imm);
}
......@@ -23294,7 +23294,7 @@ __arm_vorrq (int16x8_t __a, const int __imm)
__extension__ extern __inline int16x8_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq (int16x8_t __a, const int16_t __imm)
__arm_vbicq (int16x8_t __a, const int __imm)
{
return __arm_vbicq_n_s16 (__a, __imm);
}
......@@ -23385,7 +23385,7 @@ __arm_vorrq (uint32x4_t __a, const int __imm)
__extension__ extern __inline uint32x4_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq (uint32x4_t __a, const uint32_t __imm)
__arm_vbicq (uint32x4_t __a, const int __imm)
{
return __arm_vbicq_n_u32 (__a, __imm);
}
......@@ -23497,7 +23497,7 @@ __arm_vorrq (int32x4_t __a, const int __imm)
__extension__ extern __inline int32x4_t
__attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
__arm_vbicq (int32x4_t __a, const int32_t __imm)
__arm_vbicq (int32x4_t __a, const int __imm)
{
return __arm_vbicq_n_s32 (__a, __imm);
}
......@@ -35963,10 +35963,10 @@ extern void *__ARM_undef;
#define __arm_vbicq(p0,p1) ({ __typeof(p0) __p0 = (p0); \
__typeof(p1) __p1 = (p1); \
_Generic( (int (*)[__ARM_mve_typeid(__p0)][__ARM_mve_typeid(__p1)])0, \
int (*)[__ARM_mve_type_int16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s16 (__ARM_mve_coerce(__p0, int16x8_t), (const int16_t) __p1), \
int (*)[__ARM_mve_type_int32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s32 (__ARM_mve_coerce(__p0, int32x4_t), (const int32_t) __p1), \
int (*)[__ARM_mve_type_uint16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u16 (__ARM_mve_coerce(__p0, uint16x8_t), (const uint16_t) __p1), \
int (*)[__ARM_mve_type_uint32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u32 (__ARM_mve_coerce(__p0, uint32x4_t), (const uint32_t) __p1), \
int (*)[__ARM_mve_type_int16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s16 (__ARM_mve_coerce(__p0, int16x8_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_int32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s32 (__ARM_mve_coerce(__p0, int32x4_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_uint16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u16 (__ARM_mve_coerce(__p0, uint16x8_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_uint32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u32 (__ARM_mve_coerce(__p0, uint32x4_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_int8x16_t][__ARM_mve_type_int8x16_t]: __arm_vbicq_s8 (__ARM_mve_coerce(__p0, int8x16_t), __ARM_mve_coerce(__p1, int8x16_t)), \
int (*)[__ARM_mve_type_int16x8_t][__ARM_mve_type_int16x8_t]: __arm_vbicq_s16 (__ARM_mve_coerce(__p0, int16x8_t), __ARM_mve_coerce(__p1, int16x8_t)), \
int (*)[__ARM_mve_type_int32x4_t][__ARM_mve_type_int32x4_t]: __arm_vbicq_s32 (__ARM_mve_coerce(__p0, int32x4_t), __ARM_mve_coerce(__p1, int32x4_t)), \
......@@ -38875,10 +38875,10 @@ extern void *__ARM_undef;
#define __arm_vbicq(p0,p1) ({ __typeof(p0) __p0 = (p0); \
__typeof(p1) __p1 = (p1); \
_Generic( (int (*)[__ARM_mve_typeid(__p0)][__ARM_mve_typeid(__p1)])0, \
int (*)[__ARM_mve_type_int16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s16 (__ARM_mve_coerce(__p0, int16x8_t), (const int16_t) __p1), \
int (*)[__ARM_mve_type_int32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s32 (__ARM_mve_coerce(__p0, int32x4_t), (const int32_t) __p1), \
int (*)[__ARM_mve_type_uint16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u16 (__ARM_mve_coerce(__p0, uint16x8_t), (const uint16_t) __p1), \
int (*)[__ARM_mve_type_uint32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u32 (__ARM_mve_coerce(__p0, uint32x4_t), (const uint32_t) __p1), \
int (*)[__ARM_mve_type_int16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s16 (__ARM_mve_coerce(__p0, int16x8_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_int32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_s32 (__ARM_mve_coerce(__p0, int32x4_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_uint16x8_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u16 (__ARM_mve_coerce(__p0, uint16x8_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_uint32x4_t][__ARM_mve_type_int_n]: __arm_vbicq_n_u32 (__ARM_mve_coerce(__p0, uint32x4_t), __ARM_mve_coerce1 (__p1, int)), \
int (*)[__ARM_mve_type_int8x16_t][__ARM_mve_type_int8x16_t]: __arm_vbicq_s8 (__ARM_mve_coerce(__p0, int8x16_t), __ARM_mve_coerce(__p1, int8x16_t)), \
int (*)[__ARM_mve_type_int16x8_t][__ARM_mve_type_int16x8_t]: __arm_vbicq_s16 (__ARM_mve_coerce(__p0, int16x8_t), __ARM_mve_coerce(__p1, int16x8_t)), \
int (*)[__ARM_mve_type_int32x4_t][__ARM_mve_type_int32x4_t]: __arm_vbicq_s32 (__ARM_mve_coerce(__p0, int32x4_t), __ARM_mve_coerce(__p1, int32x4_t)), \
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_f16.c
......@@ -19,3 +19,4 @@ foo1 (float16x8_t a, float16x8_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_f32.c
......@@ -19,3 +19,4 @@ foo1 (float32x4_t a, float32x4_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_n_s16.c
......@@ -17,3 +17,4 @@ foo1 (int16x8_t a)
}
/* { dg-final { scan-assembler-times "vbic.i16" 2 } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_n_s32.c
......@@ -17,3 +17,4 @@ foo1 (int32x4_t a)
}
/* { dg-final { scan-assembler-times "vbic.i32" 2 } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_n_u16.c
......@@ -17,3 +17,4 @@ foo1 (uint16x8_t a)
}
/* { dg-final { scan-assembler-times "vbic.i16" 2 } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_n_u32.c
......@@ -17,3 +17,4 @@ foo1 (uint32x4_t a)
}
/* { dg-final { scan-assembler-times "vbic.i32" 2 } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_s16.c
......@@ -19,3 +19,4 @@ foo1 (int16x8_t a, int16x8_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_s32.c
......@@ -19,3 +19,4 @@ foo1 (int32x4_t a, int32x4_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_s8.c
......@@ -19,3 +19,4 @@ foo1 (int8x16_t a, int8x16_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_u16.c
......@@ -19,3 +19,4 @@ foo1 (uint16x8_t a, uint16x8_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_u32.c
......@@ -19,3 +19,4 @@ foo1 (uint32x4_t a, uint32x4_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
gcc/testsuite/gcc.target/arm/mve/intrinsics/vbicq_u8.c
......@@ -19,3 +19,4 @@ foo1 (uint8x16_t a, uint8x16_t b)
}
/* { dg-final { scan-assembler "vbic" } } */
/* { dg-final { scan-assembler-not "__ARM_undef" } } */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment