Commit 2635995a by Mark Wielaard Committed by Michael Koch

gnu_java_awt_peer_gtk_GtkCheckboxPeer.c: Changed C++ comments into C comments.

2004-04-21  Mark Wielaard  <mark@klomp.org>

	* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkCheckboxPeer.c:
	Changed C++ comments into C comments. Removed commented out code.
	* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c:
	Likewise.
	* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c:
	Likewise.
	* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkFileDialogPeer.c:
	Likewise.
	* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c:
	Likewise.
	* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextComponentPeer.c:
	Likewise.
	* native/jni/gtk-peer/gthread-jni.c:
	Likewise.

From-SVN: r80946
parent 1c3d6bb2
2004-04-21 Mark Wielaard <mark@klomp.org> 2004-04-21 Mark Wielaard <mark@klomp.org>
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkCheckboxPeer.c:
Changed C++ comments into C comments. Removed commented out code.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c:
Likewise.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkEvents.c:
Likewise.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkFileDialogPeer.c:
Likewise.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c:
Likewise.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkTextComponentPeer.c:
Likewise.
* native/jni/gtk-peer/gthread-jni.c:
Likewise.
2004-04-21 Mark Wielaard <mark@klomp.org>
* javax/awt/JFrame.java: Implement WindowConstants. Remove final * javax/awt/JFrame.java: Implement WindowConstants. Remove final
static fields defined in interface. static fields defined in interface.
* javax/awt/JDialog.java: Likewise. * javax/awt/JDialog.java: Likewise.
......
/* gtkcheckboxpeer.c -- Native implementation of GtkCheckboxPeer /* gtkcheckboxpeer.c -- Native implementation of GtkCheckboxPeer
Copyright (C) 1998, 1999, 2002, 2003 Free Software Foundation, Inc. Copyright (C) 1998, 1999, 2002, 2003, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -230,7 +230,6 @@ Java_gnu_java_awt_peer_gtk_GtkCheckboxPeer_gtkSetLabel ...@@ -230,7 +230,6 @@ Java_gnu_java_awt_peer_gtk_GtkCheckboxPeer_gtkSetLabel
static void static void
item_toggled (GtkToggleButton *item, jobject peer) item_toggled (GtkToggleButton *item, jobject peer)
{ {
//g_print ("toggled\n");
(*gdk_env)->CallVoidMethod (gdk_env, peer, (*gdk_env)->CallVoidMethod (gdk_env, peer,
postItemEventID, postItemEventID,
peer, peer,
......
/* gtkcomponentpeer.c -- Native implementation of GtkComponentPeer /* gtkcomponentpeer.c -- Native implementation of GtkComponentPeer
Copyright (C) 1998, 1999, 2002 Free Software Foundation, Inc. Copyright (C) 1998, 1999, 2002, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -610,10 +610,12 @@ Java_gnu_java_awt_peer_gtk_GtkComponentPeer_set__Ljava_lang_String_2Ljava_lang_O ...@@ -610,10 +610,12 @@ Java_gnu_java_awt_peer_gtk_GtkComponentPeer_set__Ljava_lang_String_2Ljava_lang_O
gboolean gboolean
filter_expose_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer) filter_expose_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer)
{ {
// Prevent the default event handler from getting this signal if applicable /*
// FIXME: I came up with these filters by looking for patterns in the unwanted * Prevent the default event handler from getting this signal if applicable
// expose events that are fed back to us from gtk/X. Perhaps there is * FIXME: I came up with these filters by looking for patterns in the unwanted
// a way to prevent them from occuring in the first place. * expose events that are fed back to us from gtk/X. Perhaps there is
* a way to prevent them from occuring in the first place.
*/
if (event->type == GDK_EXPOSE && (!GTK_IS_LAYOUT(widget) if (event->type == GDK_EXPOSE && (!GTK_IS_LAYOUT(widget)
|| event->any.window != widget->window)) || event->any.window != widget->window))
{ {
...@@ -622,8 +624,8 @@ filter_expose_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer) ...@@ -622,8 +624,8 @@ filter_expose_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer)
} }
else else
{ {
// There may be non-expose events that are triggered while we're /* There may be non-expose events that are triggered while we're
// painting a heavyweight peer. painting a heavyweight peer. */
return pre_event_handler(widget, event, peer); return pre_event_handler(widget, event, peer);
} }
} }
...@@ -641,8 +643,8 @@ JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GtkComponentPeer_addExposeFilt ...@@ -641,8 +643,8 @@ JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GtkComponentPeer_addExposeFilt
gdk_threads_enter (); gdk_threads_enter ();
// GtkFramePeer is built as a GtkLayout inside a GtkVBox inside a GtkWindow. /* GtkFramePeer is built as a GtkLayout inside a GtkVBox inside a GtkWindow.
// Events go to the GtkLayout layer, so we filter them there. Events go to the GtkLayout layer, so we filter them there. */
if (GTK_IS_WINDOW(ptr)) if (GTK_IS_WINDOW(ptr))
{ {
children = gtk_container_get_children(GTK_CONTAINER(ptr)); children = gtk_container_get_children(GTK_CONTAINER(ptr));
...@@ -685,8 +687,8 @@ JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GtkComponentPeer_removeExposeF ...@@ -685,8 +687,8 @@ JNIEXPORT void JNICALL Java_gnu_java_awt_peer_gtk_GtkComponentPeer_removeExposeF
gdk_threads_enter (); gdk_threads_enter ();
// GtkFramePeer is built as a GtkLayout inside a GtkVBox inside a GtkWindow. /* GtkFramePeer is built as a GtkLayout inside a GtkVBox inside a GtkWindow.
// Events go to the GtkLayout layer, so we filter them there. Events go to the GtkLayout layer, so we filter them there. */
if (GTK_IS_WINDOW(ptr)) if (GTK_IS_WINDOW(ptr))
{ {
children = gtk_container_get_children(GTK_CONTAINER(ptr)); children = gtk_container_get_children(GTK_CONTAINER(ptr));
......
/* gtkevents.c -- GDK/GTK event handlers /* gtkevents.c -- GDK/GTK event handlers
Copyright (C) 1998, 1999, 2002 Free Software Foundation, Inc. Copyright (C) 1998, 1999, 2002, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -934,9 +934,9 @@ pre_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer) ...@@ -934,9 +934,9 @@ pre_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer)
click_count, click_count,
JNI_FALSE); JNI_FALSE);
// Generate an AWT click event only if the release occured in the /* Generate an AWT click event only if the release occured in the
// window it was pressed in, and the mouse has not been dragged since window it was pressed in, and the mouse has not been dragged since
// the last time it was pressed. the last time it was pressed. */
gdk_window_get_size (event->any.window, &width, &height); gdk_window_get_size (event->any.window, &width, &height);
if (! hasBeenDragged if (! hasBeenDragged
&& event->button.x >= 0 && event->button.x >= 0
...@@ -1038,11 +1038,11 @@ pre_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer) ...@@ -1038,11 +1038,11 @@ pre_event_handler (GtkWidget *widget, GdkEvent *event, jobject peer)
break; break;
case GDK_EXPOSE: case GDK_EXPOSE:
{ {
// This filters out unwanted feedback expose events from gtk/X /* This filters out unwanted feedback expose events from gtk/X
// when we explictly invalidate and update heavyweight components, when we explictly invalidate and update heavyweight components,
// thus avoiding an infinite loop. thus avoiding an infinite loop.
// FIXME: I'm not quite sure why we're getting these expose events. FIXME: I'm not quite sure why we're getting these expose events.
// Maybe there is a way to avoid them? Maybe there is a way to avoid them? */
if((event->any.window == widget->window && event->any.send_event) if((event->any.window == widget->window && event->any.send_event)
|| GTK_IS_LAYOUT(widget)) || GTK_IS_LAYOUT(widget))
{ {
...@@ -1181,7 +1181,6 @@ attach_jobject (GdkWindow *window, jobject *obj) ...@@ -1181,7 +1181,6 @@ attach_jobject (GdkWindow *window, jobject *obj)
| GDK_KEY_PRESS_MASK | GDK_KEY_PRESS_MASK
| GDK_FOCUS_CHANGE_MASK); | GDK_FOCUS_CHANGE_MASK);
// g_print("storing obj %p property on window %p\n", obj, window);
gdk_property_change (window, gdk_property_change (window,
addr_atom, addr_atom,
type_atom, type_atom,
...@@ -1196,10 +1195,8 @@ connect_awt_hook (JNIEnv *env, jobject peer_obj, int nwindows, ...) ...@@ -1196,10 +1195,8 @@ connect_awt_hook (JNIEnv *env, jobject peer_obj, int nwindows, ...)
{ {
va_list ap; va_list ap;
jobject *obj; jobject *obj;
//void *ptr = NSA_GET_PTR (env, peer_obj);
obj = NSA_GET_GLOBAL_REF (env, peer_obj); obj = NSA_GET_GLOBAL_REF (env, peer_obj);
//g_print("Connection obj %s\n", gtk_widget_get_name (GTK_WIDGET (ptr)));
g_assert (obj); g_assert (obj);
va_start (ap, nwindows); va_start (ap, nwindows);
......
/* gtkfiledialogpeer.c -- Native implementation of GtkFileDialogPeer /* gtkfiledialogpeer.c -- Native implementation of GtkFileDialogPeer
Copyright (C) 1998, 1999, 2002 Free Software Foundation, Inc. Copyright (C) 1998, 1999, 2002, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -156,7 +156,7 @@ window_closed (GtkDialog *dialog __attribute__((unused)), ...@@ -156,7 +156,7 @@ window_closed (GtkDialog *dialog __attribute__((unused)),
static jmethodID disposeID; static jmethodID disposeID;
void *ptr; void *ptr;
// We only need this for the case when the user closed the window /* We only need this for the case when the user closed the window. */
if (responseId != GTK_RESPONSE_DELETE_EVENT) if (responseId != GTK_RESPONSE_DELETE_EVENT)
return; return;
......
/* gtklistpeer.c -- Native implementation of GtkListPeer /* gtklistpeer.c -- Native implementation of GtkListPeer
Copyright (C) 1998, 1999 Free Software Foundation, Inc. Copyright (C) 1998, 1999, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -324,7 +324,6 @@ item_select (GtkCList *list __attribute__((unused)), ...@@ -324,7 +324,6 @@ item_select (GtkCList *list __attribute__((unused)),
GdkEventButton *event __attribute__((unused)), GdkEventButton *event __attribute__((unused)),
jobject peer_obj) jobject peer_obj)
{ {
//g_print ("select_row\n");
(*gdk_env)->CallVoidMethod (gdk_env, peer_obj, (*gdk_env)->CallVoidMethod (gdk_env, peer_obj,
postListItemEventID, postListItemEventID,
row, row,
...@@ -338,7 +337,6 @@ item_unselect (GtkCList *list __attribute__((unused)), ...@@ -338,7 +337,6 @@ item_unselect (GtkCList *list __attribute__((unused)),
GdkEventButton *event __attribute__((unused)), GdkEventButton *event __attribute__((unused)),
jobject peer_obj) jobject peer_obj)
{ {
//g_print ("unselect_row\n");
(*gdk_env)->CallVoidMethod (gdk_env, peer_obj, (*gdk_env)->CallVoidMethod (gdk_env, peer_obj,
postListItemEventID, postListItemEventID,
row, row,
......
/* gtktextcomponentpeer.c -- Native implementation of GtkTextComponentPeer /* gtktextcomponentpeer.c -- Native implementation of GtkTextComponentPeer
Copyright (C) 1998, 1999 Free Software Foundation, Inc. Copyright (C) 1998, 1999, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -112,8 +112,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getCaretPosition ...@@ -112,8 +112,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getCaretPosition
{ {
void *ptr; void *ptr;
int pos = 0; int pos = 0;
GtkEditable *editable; // type of GtkEntry (TextField) GtkEditable *editable; /* type of GtkEntry (TextField) */
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
GtkTextBuffer *buf; GtkTextBuffer *buf;
GtkTextMark *mark; GtkTextMark *mark;
GtkTextIter iter; GtkTextIter iter;
...@@ -157,8 +157,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_setCaretPosition ...@@ -157,8 +157,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_setCaretPosition
(JNIEnv *env, jobject obj, jint pos) (JNIEnv *env, jobject obj, jint pos)
{ {
void *ptr; void *ptr;
GtkEditable *editable; // type of GtkEntry (TextField) GtkEditable *editable; /* type of GtkEntry (TextField) */
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
GtkTextBuffer *buf; GtkTextBuffer *buf;
GtkTextIter iter; GtkTextIter iter;
...@@ -198,8 +198,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getSelectionStart ...@@ -198,8 +198,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getSelectionStart
{ {
void *ptr; void *ptr;
int pos = 0; int pos = 0;
GtkEditable *editable; // type of GtkEntry (TextField) GtkEditable *editable; /* type of GtkEntry (TextField) */
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
GtkTextBuffer *buf; GtkTextBuffer *buf;
GtkTextIter start; GtkTextIter start;
GtkTextIter end; GtkTextIter end;
...@@ -255,8 +255,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getSelectionEnd ...@@ -255,8 +255,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getSelectionEnd
{ {
void *ptr; void *ptr;
int pos = 0; int pos = 0;
GtkEditable *editable; // type of GtkEntry (TextField) GtkEditable *editable; /* type of GtkEntry (TextField) */
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
GtkTextBuffer *buf; GtkTextBuffer *buf;
GtkTextIter start; GtkTextIter start;
GtkTextIter end; GtkTextIter end;
...@@ -311,8 +311,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_select ...@@ -311,8 +311,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_select
(JNIEnv *env, jobject obj, jint start, jint end) (JNIEnv *env, jobject obj, jint start, jint end)
{ {
void *ptr; void *ptr;
GtkEditable *editable; // type of GtkEntry (TextField) GtkEditable *editable; /* type of GtkEntry (TextField) */
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
GtkTextBuffer *buf; GtkTextBuffer *buf;
GtkTextIter iter; GtkTextIter iter;
...@@ -357,8 +357,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_setEditable ...@@ -357,8 +357,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_setEditable
(JNIEnv *env, jobject obj, jboolean state) (JNIEnv *env, jobject obj, jboolean state)
{ {
void *ptr; void *ptr;
GtkEditable *editable; // type of GtkEntry (TextField) GtkEditable *editable; /* type of GtkEntry (TextField) */
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
ptr = NSA_GET_PTR (env, obj); ptr = NSA_GET_PTR (env, obj);
...@@ -396,8 +396,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getText ...@@ -396,8 +396,8 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_getText
void *ptr; void *ptr;
char *contents = NULL; char *contents = NULL;
jstring jcontents; jstring jcontents;
GtkEditable *editable; // type of GtkEntry (TextField) GtkEditable *editable; /* type of GtkEntry (TextField) */
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
GtkTextBuffer *buf; GtkTextBuffer *buf;
GtkTextIter start, end; GtkTextIter start, end;
...@@ -444,7 +444,7 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_setText ...@@ -444,7 +444,7 @@ Java_gnu_java_awt_peer_gtk_GtkTextComponentPeer_setText
{ {
void *ptr; void *ptr;
const char *str; const char *str;
GtkWidget *text = NULL; // type of GtkTextView (TextArea) GtkWidget *text = NULL; /* type of GtkTextView (TextArea) */
GtkTextBuffer *buf; GtkTextBuffer *buf;
ptr = NSA_GET_PTR (env, obj); ptr = NSA_GET_PTR (env, obj);
......
/* gthread-jni.c -- JNI threading routines for GLIB /* gthread-jni.c -- JNI threading routines for GLIB
Copyright (C) 1998 Free Software Foundation, Inc. Copyright (C) 1998, 2004 Free Software Foundation, Inc.
This file is part of GNU Classpath. This file is part of GNU Classpath.
...@@ -204,7 +204,7 @@ static void g_mutex_lock_jni_impl (GMutex *mutex __attribute__((unused))) { ...@@ -204,7 +204,7 @@ static void g_mutex_lock_jni_impl (GMutex *mutex __attribute__((unused))) {
static gboolean g_mutex_trylock_jni_impl static gboolean g_mutex_trylock_jni_impl
(GMutex *mutex __attribute__((unused))) (GMutex *mutex __attribute__((unused)))
{ {
// Shall we implement this in a JikesRVM-specific way under a flag? /* XXX Shall we implement this in a VM-specific way under a flag? */
return FALSE; return FALSE;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment