re PR c++/33495 (Broken diagnostic: Trouble pretty-printing statement expressions)

2007-11-02  Paolo Carlini  <pcarlini@suse.de>

	PR c++/33495
	* error.c (dump_expr): Deal specially with statements.

2007-11-02  Paolo Carlini  <pcarlini@suse.de>

	PR c++/33495
	* g++.dg/other/error19.C: New.

From-SVN: r129850

gcc/cp/ChangeLog

+2007-11-02  Paolo Carlini  <pcarlini@suse.de>
+
+	PR c++/33495
+	* error.c (dump_expr): Deal specially with statements.
+
 2007-11-01  Jason Merrill  <jason@redhat.com>
 
 	PR c++/30897

gcc/cp/error.c

@@ -1437,6 +1437,12 @@ dump_expr (tree t, int flags)
   if (t == 0)
     return;
 
+  if (STATEMENT_CLASS_P (t))
+    {
+      pp_cxx_identifier (cxx_pp, "<statement>");
+      return;
+    }
+
   switch (TREE_CODE (t))
     {
     case VAR_DECL:

gcc/testsuite/ChangeLog

+2007-11-02  Paolo Carlini  <pcarlini@suse.de>
+
+	PR c++/33495
+	* g++.dg/other/error19.C: New.
+
 2007-11-02  Eric Botcazou  <ebotcazou@libertysurf.fr>
 
 	PR rtl-optimization/28062

gcc/testsuite/g++.dg/other/error19.C

+// PR c++/33495
+
+void foo()
+{
+  if (({while(true);})) // { dg-error "forbids|<statement>" }
+    ;
+}