cselib.c
79.6 KB
-
avoid null ptr deref in cselib_record_sets · 695be092
Jeff Law tells me h8300-elf fails gcc.c-torture/compile/pr49029.c with -O2 -g -mint32 -mh. This patch fixes it. The problem is that strict low part handling in cselib_record_sets assumes src_elt is not NULL. That src_elt is taken from a strict low part set, but it won't always have a src_elt to begin with. In this case, it's because src is a volatile MEM; we don't record values for those. Although we could fix the problem by testing for a NULL src_elt before creating the zero extends corresponding to strict low part sets of formerly const0_rtx REGs, there's no point in recording the additional set that we won't be able to use anyway. We could still record that the whole register has a zero-extend of the value stored in the narrower-mode strict low part of the register, but is that of any use? I guess not, but if we find otherwise, we can change that later. for gcc/ChangeLog * cselib.c (cselib_record_sets): Skip strict low part sets with NULL src_elt. From-SVN: r266873
Alexandre Oliva committed