In order to avoid inconsistent definitions of type off_t, all compilation units should include the "common.h" header file before certain system headers (those which directly or indirectly lead to the definition of off_t). The "common.h" header contains the definition of _FILE_OFFSET_BITS to select 64-bit file offsets. The symptom of this inconsistency, while compiling with -Wextra, is the following warning: In file included from src/common.h:50, from src/commit.c:28: src/util.h: In function git__is_sizet: src/util.h:41: warning: comparison between signed and unsigned In order to fix the problem, we simply remove the #include <time.h> statement at the head of src/commit.c. Note that src/commit.h also includes <time.h>. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Andreas Ericsson <ae@op5.se>
Name |
Last commit
|
Last update |
---|---|---|
.. | ||
block-sha1 | Loading commit data... | |
git | Loading commit data... | |
ppc | Loading commit data... | |
unix | Loading commit data... | |
win32 | Loading commit data... | |
bswap.h | Loading commit data... | |
cc-compat.h | Loading commit data... | |
commit.c | Loading commit data... | |
commit.h | Loading commit data... | |
common.h | Loading commit data... | |
delta-apply.c | Loading commit data... | |
delta-apply.h | Loading commit data... | |
dir.h | Loading commit data... | |
errors.c | Loading commit data... | |
errors.h | Loading commit data... | |
fileops.c | Loading commit data... | |
fileops.h | Loading commit data... | |
hash.c | Loading commit data... | |
hash.h | Loading commit data... | |
map.h | Loading commit data... | |
mingw-compat.h | Loading commit data... | |
msvc-compat.h | Loading commit data... | |
odb.c | Loading commit data... | |
odb.h | Loading commit data... | |
oid.c | Loading commit data... | |
revobject.c | Loading commit data... | |
revobject.h | Loading commit data... | |
revwalk.c | Loading commit data... | |
revwalk.h | Loading commit data... | |
sha1.h | Loading commit data... | |
thread-utils.c | Loading commit data... | |
thread-utils.h | Loading commit data... | |
util.c | Loading commit data... | |
util.h | Loading commit data... |