- 17 Mar, 2015 1 commit
-
-
The caller has otherwise no way to know how long the string will be allocated or ability to free it. This fixes #2944.
Carlos Martín Nieto committed
-
- 06 Dec, 2014 1 commit
-
-
Make it consistent between git_note_create() and git_note_remote() by putting it after the repository.
Carlos Martín Nieto committed
-
- 01 Jul, 2014 1 commit
-
-
Edward Thomson committed
-
- 24 Jan, 2014 1 commit
-
-
This was left over when we did the general switch.
Carlos Martín Nieto committed
-
- 11 Dec, 2013 1 commit
-
-
This changes the behavior of callbacks so that the callback error code is not converted into GIT_EUSER and instead we propagate the return value through to the caller. Instead of using the giterr_capture and giterr_restore functions, we now rely on all functions to pass back the return value from a callback. To avoid having a return value with no error message, the user can call the public giterr_set_str or some such function to set an error message. There is a new helper 'giterr_set_callback' that functions can invoke after making a callback which ensures that some error message was set in case the callback did not set one. In places where the sign of the callback return value is meaningful (e.g. positive to skip, negative to abort), only the negative values are returned back to the caller, obviously, since the other values allow for continuing the loop. The hardest parts of this were in the checkout code where positive return values were overloaded as meaningful values for checkout. I fixed this by adding an output parameter to many of the internal checkout functions and removing the overload. This added some code, but it is probably a better implementation. There is some funkiness in the network code where user provided callbacks could be returning a positive or a negative value and we want to rely on that to cancel the loop. There are still a couple places where an user error might get turned into GIT_EUSER there, I think, though none exercised by the tests.
Russell Belfer committed
-
- 14 Nov, 2013 1 commit
-
-
Ben Straub committed
-
- 06 Mar, 2013 4 commits
-
-
Nico von Geyso committed
-
* fixed style issues * use new iterator functions for git_note_foreach()
Nico von Geyso committed -
Nico von Geyso committed
-
* git_note_iterator_new() - create a new note iterator * git_note_next() - retrieves the next item of the iterator
Nico von Geyso committed
-
- 04 Jan, 2013 1 commit
-
-
Nikolai Vladimirov committed
-
- 03 Jan, 2013 1 commit
-
-
Nikolai Vladimirov committed
-
- 27 Nov, 2012 1 commit
-
-
Russell Belfer committed
-
- 23 Nov, 2012 1 commit
-
-
Without this change, any failed assertion in the second (or a later) test inside a test suite has a chance of double deleting memory, resulting in a heap corruption. See #1096 for details. This leaves alone the test cases where we "just" use cl_git_sandbox_init() and cl_git_sandbox_cleanup(). These methods already take good care to not double delete a repository. Fixes #1096
Sascha Cunz committed
-
- 04 Aug, 2012 1 commit
-
-
This updates all the `foreach()` type functions across the library that take callbacks from the user to have a consistent behavior. The rules are: * A callback terminates the loop by returning any non-zero value * Once the callback returns non-zero, it will not be called again (i.e. the loop stops all iteration regardless of state) * If the callback returns non-zero, the parent fn returns GIT_EUSER * Although the parent returns GIT_EUSER, no error will be set in the library and `giterr_last()` will return NULL if called. This commit makes those changes across the library and adds tests for most of the iteration APIs to make sure that they follow the above rules.
Russell Belfer committed
-
- 21 Jun, 2012 1 commit
-
-
Michael Schubert committed
-
- 12 Jun, 2012 1 commit
-
-
yorah committed
-
- 08 Jun, 2012 1 commit
-
-
- Do not create new levels of fanout when creating notes from libgit2 - Insert a note in an existing matching fanout - Remove a note from an existing fanout - Cleanup git_note_read, git_note_remove, git_note_foreach, git_note_create methods in order use tree structures instead of tree_oids
yorah committed
-
- 07 Jun, 2012 1 commit
-
-
yorah committed
-
- 17 May, 2012 2 commits
-
-
Vicent Martí committed
-
Vicent Martí committed
-
- 16 May, 2012 1 commit
-
-
nulltoken committed
-
- 14 May, 2012 2 commits
- 02 May, 2012 1 commit
-
-
Vicent Martí committed
-
- 01 Apr, 2012 1 commit
-
-
Ben Straub committed
-
- 23 Feb, 2012 1 commit
-
-
Reported-by: Carlos Martín Nieto <carlos@cmartin.tk> Signed-off-by: schu <schu-github@schulog.org>
schu committed
-
- 15 Feb, 2012 1 commit
-
-
This commit adds basic git notes support to libgit2, namely: * git_note_read * git_note_message * git_note_oid * git_note_create * git_note_remove In the long run, we probably want to provide some convenience callback mechanism for merging and moving (filter-branch) notes. Signed-off-by: schu <schu-github@schulog.org>
schu committed
-