- 13 Aug, 2013 1 commit
-
-
Build it on top of the normal iterator instead, which lets use re-use a lot of code.
Carlos Martín Nieto committed
-
- 12 Aug, 2013 2 commits
-
-
Carlos Martín Nieto committed
-
As the name suggests, it iterates over all the entries
Carlos Martín Nieto committed
-
- 08 Aug, 2013 4 commits
-
-
`git_config_set_string(config, "config.section", "")` fails when escaping the value. The buffer in `escape_value` is allocated without NULL-termination. And in case of empty string 0 is passed for buffer size in `git_buf_grow`. `git_buf_detach` returns NULL when the allocated size is 0 and that leads to an error return in `GITERR_CHECK_ALLOC` called after `escape_value` The change in `config_file.c` was suggested by Russell Belfer <rb@github.com>
Nikolai Vladimirov committed -
Make it look like the refs iterator API.
Carlos Martín Nieto committed -
Implement the foreach version as a wrapper around the iterator.
Carlos Martín Nieto committed -
The plain function will return an iterator, so move this one out of the way.
Carlos Martín Nieto committed
-
- 07 Aug, 2013 1 commit
-
-
Parse config headers that have the last quote on the line quoted instead of walking off the end.
Edward Thomson committed
-
- 09 Jul, 2013 1 commit
-
-
The old tests didn't try failing lookups or lookups across multiple config files with some having the pattern and some not having it.
Russell Belfer committed
-
- 07 May, 2013 2 commits
-
-
The rules for which one to open is a bit silly, so let's make it easier for our users.
Carlos Martín Nieto committed -
When a repository is initialised, we need to probe to see if there is a global config to load. If this is not the case, the user isn't able to write to the global config without creating the backend and adding it themselves, which is inconvenient and overly complex. Unconditionally create and add a backend for the global config file regardless of whether it exists as a convenience for users. To enable this, we allow creating backends to files that do not exist yet, changing the semantics somewhat, and making some tests invalid.
Carlos Martín Nieto committed
-
- 21 Apr, 2013 1 commit
-
-
Moving backend implementor objects into include/git2/sys so the APIs can be isolated from the ones that normal libgit2 users would be likely to use.
Russell Belfer committed
-
- 20 Apr, 2013 1 commit
-
-
Adding a multivar when there are no variables with that name set should set the variable instead of failing.
Carlos Martín Nieto committed
-
- 09 Mar, 2013 1 commit
-
-
Passing NULL is non-sensical. The error message leaves to be desired, though, as it leaks internal implementation details. Catch it at the `git_config_set_string` level and set an appropriate error message.
Carlos Martín Nieto committed
-
- 29 Jan, 2013 1 commit
-
-
This is @nulltoken's work to test various invalid config section and key names and make sure we are validating properly.
Russell Belfer committed
-
- 25 Jan, 2013 2 commits
-
-
Check whether the backslash at the end of the line is being escaped or not so as not to consider it a continuation marker when it's e.g. a Windows-style path.
Carlos Martín Nieto committed -
Replaced all cl_assert(!strcmp()) or semantically equivalent forms by cl_assert_equal_s().
Sebastian Bauer committed
-
- 06 Jan, 2013 1 commit
-
-
nulltoken committed
-
- 03 Jan, 2013 3 commits
-
-
Vicent Marti committed
-
Ben Straub committed
-
Ben Straub committed
-
- 05 Dec, 2012 1 commit
-
-
Vicent Marti committed
-
- 30 Nov, 2012 1 commit
-
-
Ben Straub committed
-
- 27 Nov, 2012 1 commit
-
-
Ben Straub committed
-
- 18 Nov, 2012 2 commits
-
-
Michael Schubert committed
-
nulltoken committed
-
- 13 Nov, 2012 4 commits
-
-
Returning NULL for the string when we haven't signaled an error condition is counter-intuitive and causes unnecessary edge cases. Return an empty string when asking for a string value for a configuration variable such as '[section] var' to avoid these edge cases. If the distinction between no value and an empty value is needed, this can be retrieved from the entry directly. As a side-effect, this change stops the int parsing functions from segfaulting on such a variable.
Carlos Martín Nieto committed -
'[section] variable' and '[section] variable =' behave differently when parsed as booleans, so we need to store that distinction internally.
Carlos Martín Nieto committed -
We're already in the git_config namespace, there is no need to repeat it.
Carlos Martín Nieto committed -
Michael Schubert committed
-
- 09 Nov, 2012 2 commits
-
-
This fixes some various warnings that showed up in Travis and a couple uses of uninitialized memory and one memory leak.
Russell Belfer committed -
nulltoken committed
-
- 30 Oct, 2012 1 commit
-
-
This adds a new API that allows users to reload the config if the file has changed on disk. A new config callback function to refresh the config was added. The modified time and file size are used to test if the file needs to be reloaded (and are now stored in the disk backend object). In writing tests, just using mtime was a problem / race, so I wanted to check file size as well. To support that, I extended `git_futils_readbuffer_updated` to optionally check file size in addition to mtime, and I added a new function `git_filebuf_stats` to fetch the mtime and size for an open filebuf (so that the config could be easily refreshed after a write). Lastly, I moved some similar file checking code for attributes into filebuf. It is still only being used for attrs, but it seems potentially reusable, so I thought I'd move it over.
Russell Belfer committed
-
- 25 Oct, 2012 2 commits
- 23 Oct, 2012 2 commits
-
-
Added `struct git_config_entry`: a git_config_entry contains the key, the value, and the config file level from which a config element was found. Added `git_config_open_level`: build a single-level focused config object from a multi-level one. We are now storing `git_config_entry`s in the khash of the config_file
yorah committed -
This can occur after a manual modification of a config file.
yorah committed
-
- 12 Aug, 2012 1 commit
-
-
The config file parser was not working right if there was no whitespace between the value name and the equals sign. This fixes that.
Russell Belfer committed
-
- 04 Aug, 2012 1 commit
-
-
This updates all the `foreach()` type functions across the library that take callbacks from the user to have a consistent behavior. The rules are: * A callback terminates the loop by returning any non-zero value * Once the callback returns non-zero, it will not be called again (i.e. the loop stops all iteration regardless of state) * If the callback returns non-zero, the parent fn returns GIT_EUSER * Although the parent returns GIT_EUSER, no error will be set in the library and `giterr_last()` will return NULL if called. This commit makes those changes across the library and adds tests for most of the iteration APIs to make sure that they follow the above rules.
Russell Belfer committed
-
- 21 Jul, 2012 1 commit
-
-
Carlos Martín Nieto committed
-