1. 11 Aug, 2019 2 commits
  2. 20 Jul, 2019 1 commit
  3. 16 Jun, 2019 1 commit
  4. 15 Jun, 2019 1 commit
  5. 25 Jan, 2019 1 commit
  6. 22 Jan, 2019 1 commit
  7. 04 Dec, 2018 1 commit
  8. 10 Jun, 2018 1 commit
  9. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  10. 13 Jun, 2017 1 commit
  11. 07 Apr, 2017 1 commit
    • filter: only close filter if it's been initialized correctly · cf07db2f
      In the function `git_filter_list_stream_data`, we initialize, write and
      subesquently close the stream which should receive content processed by
      the filter. While we skip writing to the stream if its initialization
      failed, we still try to close it unconditionally -- even if the
      initialization failed, where the stream might not be set at all, leading
      us to segfault.
      
      Semantics in this code is not really clear. The function handling the
      same logic for files instead of data seems to do the right thing here in
      only closing the stream when initialization succeeded. When stepping
      back a bit, this is only reasonable: if a stream cannot be initialized,
      the caller would not expect it to be closed again. So actually, both
      callers of `stream_list_init` fail to do so. The data streaming function
      will always close the stream and the file streaming function will not
      close the stream if writing to it has failed.
      
      The fix is thus two-fold:
      
      - callers of `stream_list_init` now close the stream iff it has been
        initialized
      - `stream_list_init` now closes the lastly initialized stream if
        the current stream in the chain failed to initialize
      
      Add a test which segfaulted previous to these changes.
      Patrick Steinhardt committed
  12. 29 Dec, 2016 1 commit
  13. 09 Feb, 2016 1 commit
  14. 12 Jul, 2015 1 commit
  15. 01 Jul, 2015 1 commit
  16. 10 Jun, 2015 2 commits
  17. 11 May, 2015 1 commit
  18. 07 May, 2015 1 commit
  19. 28 Apr, 2015 1 commit
    • Fix some build warnings · 69f0032b
      In checkout.c and filter.c we were casting a sub struct
      to a parent struct which breaks the strict aliasing rules
      in C. However we can use .parent or .base to access the
      parent struct to avoid the build warnings.
      
      In remote.c the local variable error was not initialized
      or updated in some cases. For unintialized error a build
      warning will be generated. So always keep error variable
      up-to-date.
      Leo Yang committed
  20. 25 Mar, 2015 1 commit
  21. 06 Mar, 2015 2 commits
  22. 19 Feb, 2015 4 commits
  23. 18 Feb, 2015 2 commits
  24. 17 Feb, 2015 4 commits
  25. 13 Feb, 2015 2 commits
  26. 03 Feb, 2015 1 commit
    • attrcache: don't re-read attrs during checkout · 9f779aac
      During checkout, assume that the .gitattributes files aren't
      modified during the checkout.  Instead, create an "attribute session"
      during checkout.  Assume that attribute data read in the same
      checkout "session" hasn't been modified since the checkout started.
      (But allow subsequent checkouts to invalidate the cache.)
      
      Further, cache nonexistent git_attr_file data even when .gitattributes
      files are not found to prevent re-scanning for nonexistent files.
      Edward Thomson committed
  27. 09 Oct, 2014 1 commit
  28. 08 May, 2014 2 commits