1. 30 Jun, 2020 1 commit
  2. 15 Jan, 2020 1 commit
  3. 29 Jul, 2019 1 commit
    • object: deprecate git_object__size for removal · c8e249b0
      In #5118 we remove the double-underscore to make it a normally-named public
      function. However, this is not an interesting function outside of the library
      and it takes up a name for something that could be more useful.
      
      Remove the single-underscore version as we have not done any releases with it.
      Carlos Martín Nieto committed
  4. 18 Jul, 2019 1 commit
  5. 15 Jun, 2019 1 commit
  6. 22 Jan, 2019 1 commit
  7. 17 Jan, 2019 1 commit
  8. 01 Dec, 2018 1 commit
  9. 11 Oct, 2018 1 commit
    • object: properly propagate errors on parsing failures · 6562cdda
      When failing to parse a raw object fromits data, we free the
      partially parsed object but then fail to propagate the error to the
      caller. This may lead callers to operate on objects with invalid memory,
      which will sooner or later cause the program to segfault.
      
      Fix the issue by passing up the error code returned by `parse_raw`.
      Patrick Steinhardt committed
  10. 22 Jun, 2018 1 commit
    • object: implement function to parse raw data · ca4db5f4
      Now that we have implement functions to parse all git objects from raw
      data, we can implement a generic function `git_object__from_raw` to
      create a structure of type `git_object`. This allows us to parse and
      interpret objects from raw data without having to touch the ODB at all,
      which is especially useful for object verification prior to accepting
      them into the repository.
      Patrick Steinhardt committed
  11. 20 Dec, 2017 1 commit
    • object: introduce git_object_stringn2type · d1e44655
      Introduce an internal API to get the object type based on a
      length-specified (not null terminated) string representation.  This can
      be used to compare the (space terminated) object type name in a loose
      object.
      
      Reimplement `git_object_string2type` based on this API.
      Edward Thomson committed
  12. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  13. 08 Jun, 2017 1 commit
    • settings: rename `GIT_OPT_ENABLE_SYNCHRONOUS_OBJECT_CREATION` · 6c23704d
      Initially, the setting has been solely used to enable the use of
      `fsync()` when creating objects. Since then, the use has been extended
      to also cover references and index files. As the option is not yet part
      of any release, we can still correct this by renaming the option to
      something more sensible, indicating not only correlation to objects.
      
      This commit renames the option to `GIT_OPT_ENABLE_FSYNC_GITDIR`. We also
      move the variable from the object to repository source code.
      Patrick Steinhardt committed
  14. 28 Feb, 2017 2 commits
  15. 29 Dec, 2016 1 commit
  16. 11 Mar, 2016 1 commit
    • object: avoid call of memset with ouf of bounds pointer · 61d7328d
      When computing a short OID we do this by first copying the
      leading parts into the new OID structure and then setting the
      trailing part to zero. In the case of the desired length being
      `GIT_OID_HEXSZ - 1` we will call `memset` with an out of bounds
      pointer and a length of 0. While this seems to cause no problems
      for common platforms the C89 standard does not explicitly state
      that calling `memset` with an out of bounds pointer and
      length of 0 is valid.
      
      Fix the potential issue by using the newly introduced
      `git_oid__cpy_prefix` function.
      Patrick Steinhardt committed
  17. 28 Feb, 2016 3 commits
  18. 30 Nov, 2015 1 commit
  19. 26 Jun, 2015 1 commit
    • Revert "object: correct the expected ID size in prefix lookup" · 3d9ef2dc
      This reverts commit 969d4b70.
      
      This was a fluke from Coverity. The length to all the APIs in the
      library is supposed to be passed in as nibbles, not bytes. Passing it as
      bytes would prevent us from parsing uneven-sized SHA1 strings.
      
      Also, the rest of the library was still using nibbles (including
      revparse and the odb_prefix APIs), so this change was seriously breaking
      things in unexpected ways. ^^
      Vicent Marti committed
  20. 10 Jun, 2015 1 commit
    • object: correct the expected ID size in prefix lookup · 969d4b70
      We take in a possibly partial ID by taking a length and working off of
      that to figure out whether to just look up the object or ask the
      backends for a prefix lookup.
      
      Unfortunately we've been checking the size against `GIT_OID_HEXSZ` which
      is the size of a *string* containing a full ID, whereas we need to check
      against the size we can have when it's a 20-byte array.
      
      Change the checks and comment to use `GIT_OID_RAWSZ` which is the
      correct size of a git_oid to have when full.
      Carlos Martín Nieto committed
  21. 22 Nov, 2014 1 commit
    • peel: reject bad queries with EINVALIDSPEC · 753e17b0
      There are some combination of objects and target types which we know
      cannot be fulfilled. Return EINVALIDSPEC for those to signify that there
      is a mismatch in the user-provided data and what the object model is
      capable of satisfying.
      
      If we start at a tag and in the course of peeling find out that we
      cannot reach a particular type, we return EPEEL.
      Carlos Martín Nieto committed
  22. 06 May, 2014 1 commit
  23. 05 Mar, 2014 1 commit
  24. 25 Feb, 2014 1 commit
  25. 28 Oct, 2013 1 commit
  26. 16 Sep, 2013 1 commit
  27. 11 May, 2013 1 commit
  28. 02 May, 2013 1 commit
  29. 01 May, 2013 1 commit
  30. 22 Apr, 2013 6 commits
  31. 10 Apr, 2013 1 commit
  32. 08 Jan, 2013 1 commit