1. 23 Oct, 2017 1 commit
  2. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  3. 29 Dec, 2016 1 commit
  4. 30 Oct, 2015 2 commits
  5. 03 Aug, 2015 1 commit
  6. 21 Mar, 2015 1 commit
  7. 18 Mar, 2015 1 commit
  8. 13 Feb, 2015 1 commit
  9. 10 Dec, 2014 1 commit
  10. 14 Aug, 2014 1 commit
    • Custom transport: minor cleanups · c180c065
       * Move the transport registration mechanisms into a new header under
         'sys/' because this is advanced stuff.
       * Remove the 'priority' argument from the registration as it adds
         unnecessary complexity.  (Since transports cannot decline to operate,
         only the highest priority transport is ever executed.)  Users who
         require per-priority transports can implement that in their custom
         transport themselves.
       * Simplify registration further by taking a scheme (eg "http") instead
         of a prefix (eg "http://").
      Edward Thomson committed
  11. 11 Dec, 2013 1 commit
    • Further EUSER and error propagation fixes · dab89f9b
      This continues auditing all the places where GIT_EUSER is being
      returned and making sure to clear any existing error using the
      new giterr_user_cancel helper.  As a result, places that relied
      on intercepting GIT_EUSER but having the old error preserved also
      needed to be cleaned up to correctly stash and then retrieve the
      actual error.
      
      Additionally, as I encountered places where error codes were not
      being propagated correctly, I tried to fix them up.  A number of
      those fixes are included in the this commit as well.
      Russell Belfer committed
  12. 04 Nov, 2013 1 commit
  13. 30 Oct, 2013 1 commit
  14. 04 Feb, 2013 1 commit
  15. 31 Jan, 2013 3 commits
  16. 08 Jan, 2013 1 commit
  17. 29 Nov, 2012 1 commit
  18. 28 Nov, 2012 1 commit
  19. 01 Nov, 2012 1 commit
  20. 24 Aug, 2012 1 commit
  21. 04 Aug, 2012 1 commit
    • Update iterators for consistency across library · 5dca2010
      This updates all the `foreach()` type functions across the library
      that take callbacks from the user to have a consistent behavior.
      The rules are:
      
      * A callback terminates the loop by returning any non-zero value
      * Once the callback returns non-zero, it will not be called again
        (i.e. the loop stops all iteration regardless of state)
      * If the callback returns non-zero, the parent fn returns GIT_EUSER
      * Although the parent returns GIT_EUSER, no error will be set in
        the library and `giterr_last()` will return NULL if called.
      
      This commit makes those changes across the library and adds tests
      for most of the iteration APIs to make sure that they follow the
      above rules.
      Russell Belfer committed
  22. 30 Jul, 2012 4 commits
  23. 05 Jun, 2012 1 commit
  24. 02 Jun, 2012 1 commit
  25. 19 May, 2012 1 commit
  26. 17 May, 2012 2 commits
  27. 06 May, 2012 1 commit
  28. 05 May, 2012 1 commit
    • Fix gitno_connect() error handling on Windows · b4b96d56
      gitno_connect() can return an error or socket, which is fine on most
      platforms where sockets are file descriptors (signed int), but on Windows,
      SOCKET is an unsigned type, which is problematic when we are trying to
      test if the socket was actually a negative error code.
      
      This fix seperates the error code and socket in gitno_connect(), and fixes
      the error handling in do_connect() functions to compensate. It appears
      that git_connect() and the git-transport do_connect() functions had bugs
      in the non-windows cases too (leaking sockets, and not properly reporting
      connection error, respectively) so I went ahead and fixed those too.
      Scott J. Goldman committed
  29. 03 May, 2012 1 commit
  30. 25 Apr, 2012 2 commits
  31. 17 Apr, 2012 1 commit
  32. 11 Apr, 2012 1 commit