- 09 Nov, 2021 4 commits
-
-
Provide a mechanism for users to limit the number of characters that are examined; `git_fs_path_str_is_valid` and friends will only examine up to `str->size` bytes. `git_fs_path_is_valid` delegates to these new functions by passing `SIZE_MAX` (instead of doing a `strlen`), which is a sentinel value meaning "look for a NUL terminator".
Edward Thomson committed -
Since we're returning a boolean about validation, the name is more properly "is valid".
Edward Thomson committed -
Since we're returning a boolean about validation, the name is more properly "is valid".
Edward Thomson committed -
Introduce `git_fs_path`, which operates on generic filesystem paths. `git_path` will be kept for only git-specific path functionality (for example, checking for `.git` in a path).
Edward Thomson committed
-
- 28 Oct, 2021 1 commit
-
-
in #6083 the test runner was renamed to libgit2_tests, but not all references to the old name were updated. this change changes all of them to use the new name.
Martin Kühl committed
-
- 18 Oct, 2021 1 commit
-
-
Ensure that we always use lowercase function names, and that we do not have spaces preceding open parentheses, for consistency.
Edward Thomson committed
-
- 17 Oct, 2021 2 commits
-
-
Nobody knows what CLAR is. The test building option should be `BUILD_TESTS`.
Edward Thomson committed -
libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again.
Edward Thomson committed
-
- 02 Oct, 2021 1 commit
-
-
Separate the concerns of the hash functions from the git_oid functions. The git_oid structure will need to understand either SHA1 or SHA256; the hash functions should only deal with the appropriate one of these.
Edward Thomson committed
-
- 01 Oct, 2021 1 commit
-
-
Edward Thomson committed
-
- 27 Sep, 2021 1 commit
-
-
`git_strarray` is a public-facing type. Change `git_buf_text_common_prefix` to not use it, and just take an array of strings instead.
Edward Thomson committed
-
- 26 Sep, 2021 2 commits
-
-
Since users are disposing the _contents_ of the oidarray, not freeing the oidarray itself, the proper cleanup function is `git_oidarray_dispose`. Deprecate `git_oidarray_free`.
Edward Thomson committed -
The `repo` argument is now unnecessary. Remove it.
Edward Thomson committed
-
- 25 Sep, 2021 1 commit
-
-
When `git_repository_hashfile` is handed an absolute path, it determines whether the path is within the repository's working directory or not. This is necessary when there is no `as_path` specified. If the path is within the working directory, then the given path should be used for attribute lookups (it is the effective `as_path`). If it is not within the working directory, then it is _not_ eligible. Importantly, now we will _never_ pass an absolute path down to attribute lookup functions.
Edward Thomson committed
-
- 21 Sep, 2021 2 commits
-
-
Using a `git_oid *` in filter options was a mistake; it is a deviation from our typical pattern, and callers in some languages that GC may need very special treatment in order to pass both an options structure and a pointer outside of it.
Edward Thomson committed -
Edward Thomson committed
-
- 20 Sep, 2021 2 commits
-
-
The configuration change will override the environment variable, so the environment variable check needs to come first.
Edward Thomson committed -
Edward Thomson committed
-
- 18 Sep, 2021 6 commits
-
-
`git_diff_format_email` is deprecated in favor of `git_email_create`.
Edward Thomson committed -
`git format-patch` includes diffs with rename detection enabled by default when creating emails. Match this behavior.
Edward Thomson committed -
`git format-patch` includes binary diffs by default when creating emails. Match this behavior.
Edward Thomson committed -
Allow a `0` patch index and `0` patch count; in this case, simply don't display these in the email.
Edward Thomson committed -
Introduce a function to create an email from a diff and multiple inputs about the source of the diff. Creating an email from a diff requires many more inputs, and should be discouraged in favor of building directly from a commit, and is thus in the `sys` namespace.
Edward Thomson committed -
Create `git_email_*` which will encapsulate email creation and application, and `git_email_create_from_commit` in particular, which creates an email for a single commit.
Edward Thomson committed
-
- 16 Sep, 2021 2 commits
-
-
Laurence McGlashan committed
-
Laurence McGlashan committed
-
- 15 Sep, 2021 1 commit
-
-
Colin Stolley committed
-
- 14 Sep, 2021 4 commits
-
-
Co-authored-by: Edward Thomson <ethomson@github.com>
Laurence McGlashan committed -
Laurence McGlashan committed
-
If longpaths is true and filters are enabled, pass git_repository through the filtering code to ensure the cached longpath setting is returned. Fixes: #6054
Laurence McGlashan committed -
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Mathieu Parent committed
-
- 09 Sep, 2021 1 commit
-
-
This tests parsing a multiline string containing multiple quoted comment chars. See #6019
Basile Henry committed
-
- 04 Sep, 2021 1 commit
-
-
Allow users to specify additional repository extensions that they want to support. For example, callers can specify that they support `preciousObjects` and then may open repositories that support `extensions.preciousObjects`. Similarly, callers may opt out of supporting extensions that the library itself supports.
Edward Thomson committed
-
- 03 Sep, 2021 1 commit
-
-
Edward Thomson committed
-
- 02 Sep, 2021 6 commits
-
-
Update the proxy detection for a remote. 1. Honor `http.<url>.proxy` syntax for a remote's direct URL and parent URLs. 2. Honor an empty configuration URL to override a proxy configuration. Add tests to ensure that configuration specificity is honored.
Edward Thomson committed -
Provide a utility method on a url to determine if it matches any pattern in a comma-separated list, similar to what one would find in `NO_PROXY` environment variables.
Edward Thomson committed -
Provide a method to determine if a given URL matches a host:port pattern like the ones found in `NO_PROXY` environment variables.
Edward Thomson committed -
Edward Thomson committed
-
Introduce a utility function that compares a NUL terminated string to a possibly not-NUL terminated string with length. This is similar to `strncmp` but with an added check to ensure that the lengths match (not just the `size` portion of the two strings).
Edward Thomson committed -
Item 2 of 3 from #4164 Signed-off-by: Mathieu Parent <math.parent@gmail.com>
Mathieu Parent committed
-