1. 20 Sep, 2012 1 commit
  2. 13 Sep, 2012 1 commit
  3. 14 Sep, 2012 1 commit
  4. 25 Aug, 2012 1 commit
  5. 24 Aug, 2012 1 commit
  6. 23 Aug, 2012 1 commit
  7. 04 Aug, 2012 1 commit
    • Update iterators for consistency across library · 5dca2010
      This updates all the `foreach()` type functions across the library
      that take callbacks from the user to have a consistent behavior.
      The rules are:
      
      * A callback terminates the loop by returning any non-zero value
      * Once the callback returns non-zero, it will not be called again
        (i.e. the loop stops all iteration regardless of state)
      * If the callback returns non-zero, the parent fn returns GIT_EUSER
      * Although the parent returns GIT_EUSER, no error will be set in
        the library and `giterr_last()` will return NULL if called.
      
      This commit makes those changes across the library and adds tests
      for most of the iteration APIs to make sure that they follow the
      above rules.
      Russell Belfer committed
  8. 30 Jul, 2012 5 commits
  9. 28 Jun, 2012 1 commit
  10. 05 Jun, 2012 1 commit
  11. 02 Jun, 2012 1 commit
  12. 26 May, 2012 1 commit
  13. 19 May, 2012 3 commits
  14. 18 May, 2012 1 commit
  15. 17 May, 2012 3 commits
  16. 06 May, 2012 1 commit
  17. 05 May, 2012 1 commit
    • Fix gitno_connect() error handling on Windows · b4b96d56
      gitno_connect() can return an error or socket, which is fine on most
      platforms where sockets are file descriptors (signed int), but on Windows,
      SOCKET is an unsigned type, which is problematic when we are trying to
      test if the socket was actually a negative error code.
      
      This fix seperates the error code and socket in gitno_connect(), and fixes
      the error handling in do_connect() functions to compensate. It appears
      that git_connect() and the git-transport do_connect() functions had bugs
      in the non-windows cases too (leaking sockets, and not properly reporting
      connection error, respectively) so I went ahead and fixed those too.
      Scott J. Goldman committed
  18. 03 May, 2012 1 commit
  19. 30 Apr, 2012 2 commits
  20. 25 Apr, 2012 2 commits
  21. 23 Apr, 2012 1 commit
  22. 17 Apr, 2012 2 commits
    • Fix warnings on 64-bit windows builds · 44ef8b1b
      This fixes all the warnings on win64 except those in deps, which
      come from the regex code.
      Russell Belfer committed
    • Add git_reference_lookup_oid and lookup_resolved · f201d613
      Adds a new public reference function `git_reference_lookup_oid`
      that directly resolved a reference name to an OID without returning
      the intermediate `git_reference` object (hence, no free needed).
      
      Internally, this adds a `git_reference_lookup_resolved` function
      that combines looking up and resolving a reference.  This allows
      us to be more efficient with memory reallocation.
      
      The existing `git_reference_lookup` and `git_reference_resolve`
      are reimplmented on top of the new utility and a few places in the
      code are changed to use one of the two new functions.
      Russell Belfer committed
  23. 12 Apr, 2012 1 commit
  24. 11 Apr, 2012 3 commits
  25. 10 Apr, 2012 1 commit
  26. 06 Mar, 2012 1 commit
    • error-handling: Repository · cb8a7961
      This also includes droping `git_buf_lasterror` because it makes no sense
      in the new system. Note that in most of the places were it has been
      dropped, the code needs cleanup. I.e. GIT_ENOMEM is going away, so
      instead it should return a generic `-1` and obviously not throw
      anything.
      Vicent Martí committed
  27. 02 Mar, 2012 1 commit
    • Clean up GIT_UNUSED macros on all platforms · 854eccbb
      It turns out that commit 31e9cfc4cbcaf1b38cdd3dbe3282a8f57e5366a5
      did not fix the GIT_USUSED behavior on all platforms.  This commit
      walks through and really cleans things up more thoroughly, getting
      rid of the unnecessary stuff.
      
      To remove the use of some GIT_UNUSED, I ended up adding a couple
      of new iterators for hashtables that allow you to iterator just
      over keys or just over values.
      
      In making this change, I found a bug in the clar tests (where we
      were doing *count++ but meant to do (*count)++ to increment the
      value).  I fixed that but then found the test failing because it
      was not really using an empty repo.  So, I took some of the code
      that I wrote for iterator testing and moved it to clar_helpers.c,
      then made use of that to make it easier to open fixtures on a
      per test basis even within a single test file.
      Russell Belfer committed