- 03 Jul, 2017 1 commit
-
-
Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on.
Patrick Steinhardt committed
-
- 17 Feb, 2017 2 commits
-
-
Patrick Steinhardt committed
-
Patrick Steinhardt committed
-
- 29 Dec, 2016 1 commit
-
-
Error messages should be sentence fragments, and therefore: 1. Should not begin with a capital letter, 2. Should not conclude with punctuation, and 3. Should not end a sentence and begin a new one
Edward Thomson committed
-
- 23 Mar, 2016 1 commit
-
-
Edward Thomson committed
-
- 10 Mar, 2016 1 commit
-
-
Patrick Steinhardt committed
-
- 31 Jul, 2015 1 commit
-
-
Without this change, compiling with gcc and pedantic generates warning: ISO C does not allow extra ‘;’ outside of a function.
Stefan Widgren committed
-
- 07 Apr, 2015 1 commit
-
-
When no reference names could be found we did error out when trying to describe a commit. This is wrong, though, when the option to fall back to a commit's object ID is set.
Patrick Steinhardt committed
-
- 11 Mar, 2015 1 commit
-
-
Keep the definitions in the headers, while putting the declarations in the C files. Putting the function definitions in headers causes them to be duplicated if you include two headers with them.
Carlos Martín Nieto committed
-
- 29 Dec, 2014 1 commit
-
-
Jacques Germishuys committed
-
- 29 Nov, 2014 1 commit
-
-
Edward Thomson committed
-
- 27 Oct, 2014 3 commits
-
-
Pierre-Olivier Latour committed
-
Pierre-Olivier Latour committed
-
Edward Thomson committed
-
- 10 Oct, 2014 3 commits
-
-
Linquize committed
-
Linquize committed
-
If there is a failure then cl_git_pass tries to get the libgit2 error, but p_... functions don't set that. Also - trailing whitespace cleanup.
Russell Belfer committed
-
- 30 Sep, 2014 6 commits
-
-
The MinGW compiler does not like it when we declare a typedef twice.
Carlos Martín Nieto committed -
And implement the option init functions for this and the format options.
Carlos Martín Nieto committed -
Carlos Martín Nieto committed
-
When we describe the workdir, we perform a describe on HEAD and then check to see if the worktree is dirty. If it is and we have a suffix string, we append that to the buffer.
Carlos Martín Nieto committed -
Instead of printing out to the buffer inside the information-gathering phase, write the data to a intermediate result structure. This allows us to split the options into gathering options and formatting options, simplifying the gathering code.
Carlos Martín Nieto committed -
We don't describe arbitrary object, so let's give it the name of the one object type we accept.
Carlos Martín Nieto committed
-
- 30 Apr, 2014 1 commit
-
-
nulltoken committed
-