1. 11 Nov, 2021 1 commit
  2. 09 Nov, 2021 1 commit
  3. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  4. 20 Jul, 2019 1 commit
  5. 05 Jul, 2019 2 commits
  6. 11 Oct, 2018 1 commit
    • fuzzers: initialize libgit2 in standalone driver · 6956a954
      The standalone driver for libgit2's fuzzing targets makes use of
      functions from libgit2 itself. While this is totally fine to do, we need
      to make sure to always have libgit2 initialized via `git_libgit2_init`
      before we call out to any of these. While this happens in most cases as
      we call `LLVMFuzzerInitialize`, which is provided by our fuzzers and
      which right now always calls `git_libgit2_init`, one exception to this
      rule is our error path when not enough arguments have been given. In
      this case, we will call `git_vector_free_deep` without libgit2 having
      been initialized. As we did not set up our allocation functions in that
      case, this will lead to a segmentation fault.
      
      Fix the issue by always initializing and shutting down libgit2 in the
      standalone driver. Note that we cannot let this replace the
      initialization in `LLVMFuzzerInitialize`, as it is required when using
      the "real" fuzzers by LLVM without our standalone driver. It's no
      problem to call the initialization and deinitialization functions
      multiple times, though.
      Patrick Steinhardt committed
  7. 03 Aug, 2018 2 commits
    • fuzzers: rename "fuzz" directory to match our style · 59328ed8
      Our layout uses names like "examples" or "tests" which is why the "fuzz"
      directory doesn't really fit in here. Rename the directory to be called
      "fuzzers" instead. Furthermore, we rename the fuzzer "fuzz_packfile_raw"
      to "packfile_raw_fuzzer", which is also in line with the already
      existing fuzzer at google/oss-fuzz.
      
      While at it, rename the "packfile_raw" fuzzer to instead just be called
      "packfile" fuzzer.
      Patrick Steinhardt committed
    • fuzzers: add build support and instructions · 60e610a2
      This change adds support for building a fuzz target for exercising the
      packfile parser, as well as documentation. It also runs the fuzzers in
      Travis to avoid regressions.
      lhchavez committed