1. 01 Jun, 2020 1 commit
  2. 24 Jun, 2019 1 commit
  3. 15 Feb, 2019 4 commits
    • maps: provide return value when deleting entries · 84a089da
      Currently, the delete functions of maps do not provide a return value. Like
      this, it is impossible to tell whether the entry has really been deleted or not.
      Change the implementation to provide either a return value of zero if the entry
      has been successfully deleted or `GIT_ENOTFOUND` if the key could not be found.
      
      Convert callers to the `delete_at` functions to instead use this higher-level
      interface.
      Patrick Steinhardt committed
    • strmap: introduce high-level setter for key/value pairs · 03555830
      Currently, one would use the function `git_strmap_insert` to insert key/value
      pairs into a map. This function has historically been a macro, which is why its
      syntax is kind of weird: instead of returning an error code directly, it instead
      has to be passed a pointer to where the return value shall be stored. This does
      not match libgit2's common idiom of directly returning error codes.
      
      Introduce a new function `git_strmap_set`, which takes as parameters the map,
      key and value and directly returns an error code. Convert all callers of
      `git_strmap_insert` to make use of it.
      Patrick Steinhardt committed
    • strmap: introduce `git_strmap_get` and use it throughout the tree · ef507bc7
      The current way of looking up an entry from a map is tightly coupled with the
      map implementation, as one first has to look up the index of the key and then
      retrieve the associated value by using the index. As a caller, you usually do
      not care about any indices at all, though, so this is more complicated than
      really necessary. Furthermore, it invites for errors to happen if the correct
      error checking sequence is not being followed.
      
      Introduce a new high-level function `git_strmap_get` that takes a map and a key
      and returns a pointer to the associated value if such a key exists. Otherwise,
      a `NULL` pointer is returned. Adjust all callers that can trivially be
      converted.
      Patrick Steinhardt committed
    • maps: use uniform lifecycle management functions · 351eeff3
      Currently, the lifecycle functions for maps (allocation, deallocation, resize)
      are not named in a uniform way and do not have a uniform function signature.
      Rename the functions to fix that, and stick to libgit2's naming scheme of saying
      `git_foo_new`. This results in the following new interface for allocation:
      
      - `int git_<t>map_new(git_<t>map **out)` to allocate a new map, returning an
        error code if we ran out of memory
      
      - `void git_<t>map_free(git_<t>map *map)` to free a map
      
      - `void git_<t>map_clear(git<t>map *map)` to remove all entries from a map
      
      This commit also fixes all existing callers.
      Patrick Steinhardt committed
  4. 22 Jan, 2019 1 commit
  5. 28 Nov, 2018 1 commit
  6. 03 Jul, 2017 1 commit
  7. 17 Feb, 2017 5 commits
  8. 29 Dec, 2016 1 commit
  9. 15 Nov, 2016 1 commit
  10. 14 Nov, 2016 1 commit
  11. 28 Oct, 2015 1 commit
  12. 15 Feb, 2015 1 commit
  13. 13 Feb, 2015 2 commits
  14. 17 Apr, 2014 2 commits
  15. 04 Feb, 2014 1 commit
    • Convert pqueue to just be a git_vector · 882c7742
      This updates the git_pqueue to simply be a set of specialized
      init/insert/pop functions on a git_vector.
      
      To preserve the pqueue feature of having a fixed size heap, I
      converted the "sorted" field in git_vectors to a more general
      "flags" field so that pqueue could mix in it's own flag.  This
      had a bunch of ramifications because a number of places were
      directly looking at the vector "sorted" field - I added a couple
      new git_vector helpers (is_sorted, set_sorted) so the specific
      representation of this information could be abstracted.
      Russell Belfer committed
  16. 22 Aug, 2013 5 commits
  17. 21 Aug, 2013 2 commits
  18. 20 Aug, 2013 1 commit
    • Add sorted cache data type · 0b7cdc02
      This adds a convenient new data type for caching the contents of
      file in memory when each item in that file corresponds to a name
      and you need to both be able to lookup items by name and iterate
      over them in some sorted order.  The new data type has locks in
      place to manage usage in a threaded environment.
      Russell Belfer committed