1. 26 Jun, 2015 1 commit
    • Revert "object: correct the expected ID size in prefix lookup" · 3d9ef2dc
      This reverts commit 969d4b70.
      
      This was a fluke from Coverity. The length to all the APIs in the
      library is supposed to be passed in as nibbles, not bytes. Passing it as
      bytes would prevent us from parsing uneven-sized SHA1 strings.
      
      Also, the rest of the library was still using nibbles (including
      revparse and the odb_prefix APIs), so this change was seriously breaking
      things in unexpected ways. ^^
      Vicent Marti committed
  2. 10 Jun, 2015 1 commit
    • object: correct the expected ID size in prefix lookup · 969d4b70
      We take in a possibly partial ID by taking a length and working off of
      that to figure out whether to just look up the object or ask the
      backends for a prefix lookup.
      
      Unfortunately we've been checking the size against `GIT_OID_HEXSZ` which
      is the size of a *string* containing a full ID, whereas we need to check
      against the size we can have when it's a 20-byte array.
      
      Change the checks and comment to use `GIT_OID_RAWSZ` which is the
      correct size of a git_oid to have when full.
      Carlos Martín Nieto committed
  3. 22 Nov, 2014 1 commit
    • peel: reject bad queries with EINVALIDSPEC · 753e17b0
      There are some combination of objects and target types which we know
      cannot be fulfilled. Return EINVALIDSPEC for those to signify that there
      is a mismatch in the user-provided data and what the object model is
      capable of satisfying.
      
      If we start at a tag and in the course of peeling find out that we
      cannot reach a particular type, we return EPEEL.
      Carlos Martín Nieto committed
  4. 06 May, 2014 1 commit
  5. 05 Mar, 2014 1 commit
  6. 25 Feb, 2014 1 commit
  7. 28 Oct, 2013 1 commit
  8. 16 Sep, 2013 1 commit
  9. 11 May, 2013 1 commit
  10. 02 May, 2013 1 commit
  11. 01 May, 2013 1 commit
  12. 22 Apr, 2013 6 commits
  13. 10 Apr, 2013 1 commit
  14. 08 Jan, 2013 1 commit
  15. 01 Dec, 2012 1 commit
  16. 29 Nov, 2012 1 commit
  17. 28 Nov, 2012 2 commits
  18. 27 Nov, 2012 1 commit
  19. 22 Nov, 2012 1 commit
  20. 10 Sep, 2012 1 commit
    • Reorg internal odb read header and object lookup · c6ac28fd
      Often `git_odb_read_header` will "fail" and have to read the
      entire object into memory instead of just the header.  When this
      happens, the object is loaded and then disposed of immediately,
      which makes it difficult to efficiently use the header information
      to decide if the object should be loaded (since attempting to do
      so will often result in loading the object twice).
      
      This commit takes the existing code and reorganizes it to have
      two new functions:
      
      - `git_odb__read_header_or_object` which acts just like the old
        read header function except that it returns the object, too, if
        it was forced to load the whole thing.  It then becomes the
        callers responsibility to free the `git_odb_object`.
      - `git_object__from_odb_object` which was extracted from the old
        `git_object_lookup` and creates a subclass of `git_object` from
        an existing `git_odb_object` (separating the ODB lookup from the
        `git_object` creation).  This allows you to use the first header
        reading function efficiently without instantiating the
        `git_odb_object` twice.
      
      There is no net change to the behavior of any of the existing
      functions, but this allows internal code to tap into the ODB
      lookup and object creation to be more efficient.
      Russell Belfer committed
  21. 27 Aug, 2012 1 commit
    • Make git_object_peel a bit smarter · d8057a5b
      This expands the types of peeling that `git_object_peel` knows
      how to do to include TAG -> BLOB peeling, and makes the errors
      slightly more consistent depending on the situation.  It also
      adds a new special behavior where peeling to ANY will peel until
      the object type changes (e.g. chases TAGs to a non-TAG).
      
      Using this expanded peeling, this replaces peeling code that was
      embedded in `git_tag_peel` and `git_reset`.
      Russell Belfer committed
  22. 24 Jul, 2012 1 commit
  23. 17 Jul, 2012 1 commit
  24. 21 Jun, 2012 1 commit
  25. 17 May, 2012 2 commits
  26. 11 May, 2012 1 commit
  27. 08 May, 2012 1 commit
  28. 04 May, 2012 1 commit
    • Fix valgrind issues · 282283ac
      There are three changes here:
      - correctly propogate error code from failed object lookups
      - make zlib inflate use our allocators
      - add OID to notfound error in ODB lookups
      Russell Belfer committed
  29. 03 May, 2012 2 commits
    • Support reading attributes from index · f917481e
      Depending on the operation, we need to consider gitattributes
      in both the work dir and the index.  This adds a parameter to
      all of the gitattributes related functions that allows user
      control of attribute reading behavior (i.e. prefer workdir,
      prefer index, only use index).
      
      This fix also covers allowing us to check attributes (and
      hence do diff and status) on bare repositories.
      
      This was a somewhat larger change that I hoped because it had
      to change the cache key used for gitattributes files.
      Russell Belfer committed
  30. 26 Apr, 2012 1 commit
  31. 13 Mar, 2012 1 commit
    • Migrate ODB files to new error handling · e1de726c
      This migrates odb.c, odb_loose.c, odb_pack.c and pack.c to
      the new style of error handling.  Also got the unix and win32
      versions of map.c.  There are some minor changes to other
      files but no others were completely converted.
      
      This also contains an update to filebuf so that a zeroed out
      filebuf will not think that the fd (== 0) is actually open
      (and inadvertently call close() on fd 0 if cleaned up).
      
      Lastly, this was built and tested on win32 and contains a
      bunch of fixes for the win32 build which was pretty broken.
      Russell Belfer committed
  32. 13 Feb, 2012 1 commit