This makes the diff functions that take callbacks both take
the payload parameter after the callback function pointers and
pass the payload as the last argument to the callback function
instead of the first.  This should make them consistent with
other callbacks across the API.

As part of API review, use a typedef for the callback fn ptr.

Conflicts:
	src/branch.c
	tests-clar/refs/branches/create.c

fix build on FreeBSD

3f9eb1e5 introduced support for SSL certificates issued for IP
addresses, making use of in_addr and in_addr6 structs.  On FreeBSD
these are defined in (a file included in) <netinet/in.h>, so include
that file on FreeBSD and get the build working again.

pack.c: Set p->mwf.fd to -1 on error

Fix invalid read reported by valgrind

If p->mwf.fd is e.g. -2 then it is closed in packfile_free and an exception might be thrown.

Signed-off-by: Sven Strickroth <email@cs-ware.de>

Make `git_repository_head_tree()` return error codes

Create contributing guidelines

Reset all static variables to NULL in clar's __cleanup

Remove use of English expletives

Remove words such as fuck, crap, shit etc.
Remove other potentially offensive words from comments.
Tidy up other geopolicital terms in comments.

Without this change, any failed assertion in the second (or a later) test
inside a test suite has a chance of double deleting memory, resulting in
a heap corruption. See #1096 for details.

This leaves alone the test cases where we "just" use cl_git_sandbox_init()
and cl_git_sandbox_cleanup(). These methods already take good care to not
double delete a repository.

Fixes #1096

Update to Authors

It is okay to not have a .gitconfig file

Fix win32 lstat

Opening a repo is generating an error if you don't have a
.gitconfig file in your home directory, but that should be
legal.

VS-Build: Append C_FLAGS to the end of the already given ones.

My other PR revealed, that the /W4 parameter, we give to MSVC is ignored
because cmake set CMAKE_C_FLAGS already to /W3 and we overwrite it.

The command line tools gave me a D9025 warning for this on every file and
looking into the project properties page on MSVC 2008 tells, that it has
the warning level set to /W3.

However, the warnings introduced by /W4 are far to useless for having
them enabled. So just disable them.

Don't use precompiled headers for command-line based VC builds.