1. 10 Dec, 2014 2 commits
  2. 19 Nov, 2014 1 commit
    • fetch: clear the connection data on close · 1ca61bdc
      When we fetch twice with the same remote object, we did not properly
      clear the connection flags, so we would leak state from the last
      connection.
      
      This can cause the second fetch with the same remote object to fail if
      using a HTTP URL where the server redirects to HTTPS, as the second
      fetch would see `use_ssl` set and think the initial connection wanted to
      downgrade the connection.
      Carlos Martín Nieto committed
  3. 27 Oct, 2014 1 commit
  4. 22 Sep, 2014 1 commit
  5. 16 Sep, 2014 6 commits
  6. 16 Aug, 2014 1 commit
    • http: make sure we can consume the data we request · 294c6f29
      The recv buffer (parse_buffer) and the buffer have independent sizes and
      offsets. We try to fill in parse_buffer as much as possible before
      passing it to the http parser. This is fine most of the time, but fails
      us when the buffer is almost full.
      
      In those situations, parse_buffer can have more data than we would be
      able to put into the buffer (which may be getting full if we're towards
      the end of a data sideband packet).
      
      To work around this, we check if the space we have left on our buffer is
      smaller than what could come from the network. If this happens, we make
      parse_buffer think that it has as much space left as our buffer, so it
      won't try to retrieve more data than we can deal with.
      
      As the start of the data may no longer be at the start of the buffer, we
      need to keep track of where it really starts (data_offset) and use that
      in our calculations for the real size of the data we received from the
      network.
      
      This fixes #2518.
      Carlos Martín Nieto committed
  7. 15 Aug, 2014 4 commits
  8. 13 Jun, 2014 1 commit
  9. 22 Apr, 2014 1 commit
  10. 12 Dec, 2013 1 commit
    • Cleanups, renames, and leak fixes · 9cfce273
      This renames git_vector_free_all to the better git_vector_free_deep
      and also contains a couple of memory leak fixes based on valgrind
      checks.  The fixes are specifically: failure to free global dir
      path variables when not compiled with threading on and failure to
      free filters from the filter registry that had not be initialized
      fully.
      Russell Belfer committed
  11. 11 Dec, 2013 1 commit
    • Remove converting user error to GIT_EUSER · 25e0b157
      This changes the behavior of callbacks so that the callback error
      code is not converted into GIT_EUSER and instead we propagate the
      return value through to the caller.  Instead of using the
      giterr_capture and giterr_restore functions, we now rely on all
      functions to pass back the return value from a callback.
      
      To avoid having a return value with no error message, the user
      can call the public giterr_set_str or some such function to set
      an error message.  There is a new helper 'giterr_set_callback'
      that functions can invoke after making a callback which ensures
      that some error message was set in case the callback did not set
      one.
      
      In places where the sign of the callback return value is
      meaningful (e.g. positive to skip, negative to abort), only the
      negative values are returned back to the caller, obviously, since
      the other values allow for continuing the loop.
      
      The hardest parts of this were in the checkout code where positive
      return values were overloaded as meaningful values for checkout.
      I fixed this by adding an output parameter to many of the internal
      checkout functions and removing the overload.  This added some
      code, but it is probably a better implementation.
      
      There is some funkiness in the network code where user provided
      callbacks could be returning a positive or a negative value and
      we want to rely on that to cancel the loop.  There are still a
      couple places where an user error might get turned into GIT_EUSER
      there, I think, though none exercised by the tests.
      Russell Belfer committed
  12. 26 Sep, 2013 3 commits
  13. 24 Sep, 2013 3 commits
  14. 25 Mar, 2013 2 commits
  15. 31 Jan, 2013 4 commits
  16. 08 Jan, 2013 1 commit
  17. 10 Dec, 2012 1 commit
  18. 29 Nov, 2012 2 commits
  19. 28 Nov, 2012 1 commit
  20. 13 Nov, 2012 2 commits
  21. 09 Nov, 2012 1 commit