Commits · 9b7a6a99807862778706c455d6ba361a3b1f8f7b · lvzhengyang / git2

04 Apr, 2011 5 commits

config: check for EOF before newline · 9b7a6a99

If a line ends at EOF there is no need to check for the newline
character and doing so will cause us to read memory beyond the
allocatd memory as we check for the Windows-style new-line, which is
two bytes long.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Apr 04, 2011

9b7a6a99 Browse Files

config: support multiline values · 72946881

If a variable value has the traditional continuation character (\) as
the last non-space character in the line, then we continue reading the
value on the next line.

Using more than two lines is also supported.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Apr 04, 2011

72946881 Browse Files

config: don't mix buffer reading methods · 2454ce78

Make header and variable parse functions use their own buffers instead
of giving them the line they need to read as a parameter which they
mostly ignore.

This is in preparation for multiline configuration variables.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Apr 04, 2011

2454ce78 Browse Files

config: also free the file buffer on error · 9f1b54d6

On error, the buffer containing the file contents also needs to be
freed.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Apr 04, 2011

9f1b54d6 Browse Files

config: Fix typo and remove debug statement · fe116e26
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Apr 04, 2011
fe116e26 Browse Files

31 Mar, 2011 7 commits

Merge upstream/development · f026f2b9
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 31, 2011
f026f2b9 Browse Files

Add support for subsections · 11d0e705

A variable name is stored internally with its section the way it
appeared in the configuration file in order to have the information
about what parts are case-sensitive inline.

Really implement parse_section_header_ext and move the assignment of
variables to config_parse.

The variable name matching is now done in a case-away way by
cvar_name_match and cvar_section_match. Before the user sees it, it's
normalized to the two- or three-dot version.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Mar 31, 2011

11d0e705 Browse Files

move build_varname above parse_section · 6482929b
Carlos Martín Nieto committed Mar 31, 2011

6482929b Browse Files
build_varname: lowercase the variable name · d7354d70
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 31, 2011
d7354d70 Browse Files
config_parse: no need to check if current_section is non-null · 0bbaf9aa
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 31, 2011
0bbaf9aa Browse Files

Add strtolower and strntolower functions · 923fe455

As parts of variable names are case-sensitive, we need these functions.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Mar 31, 2011

923fe455 Browse Files

config_set: really replace the value on overwrite · df22949a
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 31, 2011
df22949a Browse Files

30 Mar, 2011 7 commits

git_config_set_int: use the right buffer · 8ecc5ae5
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 30, 2011
8ecc5ae5 Browse Files
git_config: reorder fields according to use · e21881d1
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 30, 2011
e21881d1 Browse Files

config: use a singly-linked list instead of a hash table · dadc0158

Such a list preserves the order the variables were first read in which
will be useful later for merging different data-sets. Furthermore,
reading and writing out the same configuration should not reorganize
the variables, which could happen when iterating through all the items
in a hash table.

A hash table is overkill for this small a data-set anyway.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Mar 30, 2011

dadc0158 Browse Files

Store the parsed variables · d28830c2
```
Store the key-value pair as strings.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 30, 2011
d28830c2 Browse Files

Initialise the config reader in config_parse · 934fcf78

git_config_open shouldn't have to initialise variables that are only
used inside config_parse and its callees.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Mar 30, 2011

934fcf78 Browse Files

Determine variable type at runtime · 2974aa94

Config variables should be interpreted at run-time, as we don't know if a
zero means false or zero, or if yes means true or "yes".

As a variable has no intrinsic type, git_cvtype is gone and the public
API takes care of enforcing a few rules.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>

committed Mar 30, 2011

2974aa94 Browse Files

build_varname: allocate memory · 2e445cac
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
Carlos Martín Nieto committed Mar 30, 2011
2e445cac Browse Files

29 Mar, 2011 21 commits
- Fix help message for waf configure --with-sqlite · a796d24c
  Olivier Ramonat committed Mar 29, 2011
  
  a796d24c Browse Files
- Check for looser reference names · 553fbd64
```
res/dummy/a and refs/stash must pass. The other rules are already
tested by the rest of the checks.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  553fbd64 Browse Files
- normalize_name: allow more references under refs/ · 83c95128
```
Allow any well-formed reference name to live under refs/ removing the
condition that they be under refs/{heads,tags,remotes}/ as was the
design of git.

An exception is made for HEAD which is allowed to contain an OID
reference in detached HEAD state.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  83c95128 Browse Files
- refs: Don't allow references to inexistent OIDs · 9a53df7e
  Vicent Marti committed Mar 29, 2011
  
  9a53df7e Browse Files
- Enforce coding conventions in refs.c · 95cde17c
```
Internal methods are static and without the git prefix.
'Force' methods have a `_f` prefix to match the other 'force' methods.
```
  Vicent Marti committed Mar 29, 2011
  95cde17c Browse Files
- Make overwrite test more comprehensive · fc1eeb9d
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  fc1eeb9d Browse Files
- force-rename test: check for the right name · ec991936
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  ec991936 Browse Files
- rename: don't return early if the target ref exists · dad4a4d5
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  dad4a4d5 Browse Files
- Add tests covering overwriting references · 591a9423
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  591a9423 Browse Files
- Fix documentation copy error · 4cd6ed75
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  4cd6ed75 Browse Files
- Match the comment with the error string · c7db45e8
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  c7db45e8 Browse Files
- Allow forcing the creation or renaming of references · fa204962
```
Add internal reference create and rename functions which take a force
parameter, telling them to overwrite an existing reference if it
exists.

These functions try to update the reference if it's of the same type
as the one it's going to be replaced by. Otherwise the old reference
becomes invalid.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  fa204962 Browse Files
- Add GIT_EEXISTS error code · baad182c
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  baad182c Browse Files
- Expose config API for setters, getters and foreach · 9a3c5e55
```
These functions can be used to query or modify the variables in a
given configuration. No sanity checking is done on the variable names.

This is mostly meant as an API preview.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  9a3c5e55 Browse Files
- Add build_varname to make a full var name · 26faa366
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  26faa366 Browse Files
- cvar_free: also free the config var's name · e15afc8e
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  e15afc8e Browse Files
- Move git_cvar_type to include/git2/config.h · 6d7bb4e0
```
Include it in src/config.h and fix the header name #define.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  6d7bb4e0 Browse Files
- Free the config var hash contents in git_config_free · 3d23b74a
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  3d23b74a Browse Files
- Rename git_config_{type,var} to git_cvar{_type,} · 238df559
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  238df559 Browse Files
- Make GIT_EINVALIDTYPE available for use in config · 05314b5b
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  05314b5b Browse Files
- Don't leak if config parsing fails · 9f7f4122
```
Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
```
  Carlos Martín Nieto committed Mar 29, 2011
  9f7f4122 Browse Files