1. 05 Aug, 2014 1 commit
    • Round up pool alloc sizes for alignment · 38ddf227
      To make sure that items returned from pool allocations are aligned
      on nice boundaries, this rounds up all pool allocation sizes to a
      multiple of 8.  This adds a small amount of overhead to each item.
      
      The rounding up could be made optional with an extra parameter to
      the pool initialization that turned on rounding only for pools
      where item alignment actually matters, but I think for the extra
      code and complexity that would be involved, that it makes sense
      just to burn a little bit of extra memory and enable this all the
      time.
      Russell Belfer committed
  2. 28 May, 2014 1 commit
  3. 15 May, 2014 1 commit
    • Better search path sandboxing · 8487e237
      There are a number of tests that modify the global or system
      search paths during the tests.  This adds a helper function to
      make it easier to restore those paths and makes sure that they
      are getting restored in a manner that preserves test isolation.
      Russell Belfer committed
  4. 23 Apr, 2014 2 commits
  5. 22 Apr, 2014 1 commit
  6. 20 Apr, 2014 1 commit
  7. 17 Apr, 2014 2 commits
  8. 07 Apr, 2014 1 commit
  9. 01 Apr, 2014 1 commit
  10. 26 Mar, 2014 1 commit
  11. 24 Mar, 2014 2 commits
  12. 12 Mar, 2014 1 commit
  13. 03 Mar, 2014 2 commits
  14. 25 Feb, 2014 1 commit
  15. 04 Feb, 2014 1 commit
  16. 30 Jan, 2014 2 commits
  17. 20 Jan, 2014 1 commit
  18. 13 Dec, 2013 2 commits
  19. 11 Dec, 2013 2 commits
    • Remove converting user error to GIT_EUSER · 25e0b157
      This changes the behavior of callbacks so that the callback error
      code is not converted into GIT_EUSER and instead we propagate the
      return value through to the caller.  Instead of using the
      giterr_capture and giterr_restore functions, we now rely on all
      functions to pass back the return value from a callback.
      
      To avoid having a return value with no error message, the user
      can call the public giterr_set_str or some such function to set
      an error message.  There is a new helper 'giterr_set_callback'
      that functions can invoke after making a callback which ensures
      that some error message was set in case the callback did not set
      one.
      
      In places where the sign of the callback return value is
      meaningful (e.g. positive to skip, negative to abort), only the
      negative values are returned back to the caller, obviously, since
      the other values allow for continuing the loop.
      
      The hardest parts of this were in the checkout code where positive
      return values were overloaded as meaningful values for checkout.
      I fixed this by adding an output parameter to many of the internal
      checkout functions and removing the overload.  This added some
      code, but it is probably a better implementation.
      
      There is some funkiness in the network code where user provided
      callbacks could be returning a positive or a negative value and
      we want to rely on that to cancel the loop.  There are still a
      couple places where an user error might get turned into GIT_EUSER
      there, I think, though none exercised by the tests.
      Russell Belfer committed
    • Further EUSER and error propagation fixes · dab89f9b
      This continues auditing all the places where GIT_EUSER is being
      returned and making sure to clear any existing error using the
      new giterr_user_cancel helper.  As a result, places that relied
      on intercepting GIT_EUSER but having the old error preserved also
      needed to be cleaned up to correctly stash and then retrieve the
      actual error.
      
      Additionally, as I encountered places where error codes were not
      being propagated correctly, I tried to fix them up.  A number of
      those fixes are included in the this commit as well.
      Russell Belfer committed
  20. 14 Nov, 2013 1 commit