1. 27 Jun, 2018 3 commits
  2. 26 Jun, 2018 2 commits
  3. 25 Jun, 2018 7 commits
  4. 24 Jun, 2018 3 commits
  5. 22 Jun, 2018 6 commits
    • Clear revwalk sorting when resetting · 4fd81c53
      Currently we fail to clear the sorting flag for revwalks when resetting.
      This caused a poor interaction with the limited flag during a recent
      patch. This patch clears the revwalk sorting flag and causes it to no
      longer persist over resets.
      Nika Layzell committed
    • deps: fix implicit fallthrough warning in http-parser · cacbf998
      GCC 7 has introduced new warnings for implicit fallthrough in switch
      statements. Whenever there is no branch in a case block, GCC will watch
      out for some heuristics which indicate that the implicit fallthrough is
      intended, like a "fallthrough" comment. The third-party http-parser code
      manages to trick this heuristic in one case, even though there is a
      "FALLTHROUGH" comment. Fortunately, GCC has also added a strictness
      level to the -Wimplicit-fallthrough diagnostic, such that we can loosen
      this heuristic and make it more lax.
      
      Set -Wimplicit-fallthrough=1 in http-parser's CMake build instructions,
      which is the strictest level that gets rid of the warning. This level
      will treat any kind of comment as a "fallthrough" comment, which
      silences the warning.
      Patrick Steinhardt committed
    • Merge pull request #4411 from pks-t/pks/config-parse-cleanups · b121b7ac
      Config parser cleanups
      Edward Thomson committed
    • config_file: avoid free'ing OOM buffers · e1e90dcc
      Buffers which ran out of memory will never have any memory attached to
      them. As such, it is not necessary to call `git_buf_free` if the buffer
      is out of memory.
      Patrick Steinhardt committed
    • config_parse: always sanitize out-parameters in `parse_variable` · 83b5f161
      The `parse_variable` function has two out parameters `var_name` and
      `var_value`. Currently, those are not being sanitized to `NULL`. when.
      any error happens inside of the `parse_variable` function. Fix that.
      While at it, the coding style is improved to match our usual coding
      practices more closely.
      Patrick Steinhardt committed
    • config_parse: have `git_config_parse` own entry value and name · e51e29e8
      The function `git_config_parse` uses several callbacks to pass data
      along to the caller as it parses the file. One design shortcoming here
      is that strings passed to those callbacks are expected to be freed by
      them, which is really confusing.
      
      Fix the issue by changing memory ownership here. Instead of expecting
      the `on_variable` callbacks to free memory for `git_config_parse`, just
      do it inside of `git_config_parse`. While this obviously requires a bit
      more memory allocation churn due to having to copy both name and value
      at some places, this shouldn't be too much of a burden.
      Patrick Steinhardt committed
  6. 18 Jun, 2018 5 commits
  7. 17 Jun, 2018 1 commit
  8. 16 Jun, 2018 1 commit
  9. 15 Jun, 2018 12 commits