1. 14 Feb, 2023 2 commits
  2. 12 Feb, 2023 1 commit
  3. 14 Jul, 2022 1 commit
  4. 20 Jun, 2022 1 commit
  5. 15 Jun, 2022 1 commit
  6. 23 Feb, 2022 1 commit
  7. 31 Jan, 2022 1 commit
  8. 18 Nov, 2021 1 commit
  9. 22 Oct, 2021 1 commit
  10. 21 Oct, 2021 2 commits
  11. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  12. 09 Sep, 2021 1 commit
  13. 31 Jan, 2021 1 commit
  14. 27 Nov, 2020 1 commit
  15. 09 Jun, 2020 1 commit
  16. 08 Jun, 2020 2 commits
  17. 06 Nov, 2019 1 commit
  18. 21 Sep, 2019 1 commit
  19. 19 May, 2019 1 commit
  20. 22 Jan, 2019 1 commit
  21. 17 Jan, 2019 1 commit
  22. 01 Dec, 2018 1 commit
  23. 18 Oct, 2018 1 commit
  24. 10 Jun, 2018 1 commit
  25. 16 Feb, 2018 1 commit
    • Explicitly mark fallthrough cases with comments · 06b8a40f
      A lot of compilers nowadays generate warnings when there are cases in a
      switch statement which implicitly fall through to the next case. To
      avoid this warning, the last line in the case that is falling through
      can have a comment matching a regular expression, where one possible
      comment body would be `/* fall through */`.
      
      An alternative to the comment would be an explicit attribute like e.g.
      `[[clang::fallthrough]` or `__attribute__ ((fallthrough))`. But GCC only
      introduced support for such an attribute recently with GCC 7. Thus, and
      also because the fallthrough comment is supported by most compilers, we
      settle for using comments instead.
      
      One shortcoming of that method is that compilers are very strict about
      that. Most interestingly, that comment _really_ has to be the last line.
      In case a closing brace follows the comment, the heuristic will fail.
      Patrick Steinhardt committed
  26. 03 Jul, 2017 1 commit
    • Make sure to always include "common.h" first · 0c7f49dd
      Next to including several files, our "common.h" header also declares
      various macros which are then used throughout the project. As such, we
      have to make sure to always include this file first in all
      implementation files. Otherwise, we might encounter problems or even
      silent behavioural differences due to macros or defines not being
      defined as they should be. So in fact, our header and implementation
      files should make sure to always include "common.h" first.
      
      This commit does so by establishing a common include pattern. Header
      files inside of "src" will now always include "common.h" as its first
      other file, separated by a newline from all the other includes to make
      it stand out as special. There are two cases for the implementation
      files. If they do have a matching header file, they will always include
      this one first, leading to "common.h" being transitively included as
      first file. If they do not have a matching header file, they instead
      include "common.h" as first file themselves.
      
      This fixes the outlined problems and will become our standard practice
      for header and source files inside of the "src/" from now on.
      Patrick Steinhardt committed
  27. 05 May, 2017 1 commit
  28. 29 Dec, 2016 1 commit
  29. 06 Oct, 2016 1 commit
  30. 05 Sep, 2014 1 commit
  31. 05 Feb, 2014 1 commit
  32. 20 Jan, 2014 1 commit
  33. 02 Oct, 2013 1 commit
  34. 11 Sep, 2013 1 commit
  35. 07 Sep, 2013 2 commits
  36. 19 Aug, 2013 1 commit