- 16 Dec, 2015 1 commit
-
-
Instead of calling `git_index_add` in a loop, use the new `git_index_fill` internal API to fill the index with the initial staged entries. The new `fill` helper assumes that all the entries will be unique and valid, so it can append them at the end of the entries vector and only sort it once at the end. It performs no validation checks. This prevents the quadratic behavior caused by having to sort the entries list once after every insertion.
Vicent Marti committed
-
- 14 Dec, 2015 2 commits
-
-
Treat GIT_PASSTHROUGH as though git_cred_acquire_cb isn't set.
Edward Thomson committed -
Line count overflow in git_blame_hunk and git_blame__entry
Edward Thomson committed
-
- 10 Dec, 2015 2 commits
-
-
diff: include commit message when formatting patch
Carlos Martín Nieto committed -
index: always queue `remove_entry` for removal
Carlos Martín Nieto committed
-
- 09 Dec, 2015 3 commits
-
-
reset: perform the checkout before moving HEAD or the index
Carlos Martín Nieto committed -
This keeps the state of the workdir the same as one from HEAD, removing a source of possible confusion when calculating the work that is to be done.
Carlos Martín Nieto committed -
Carlos Martín Nieto committed
-
- 08 Dec, 2015 5 commits
-
-
Use a typedef for the submodule_foreach callback.
Carlos Martín Nieto committed -
tree: mark a tree as already sorted
Edward Thomson committed -
joshaber committed
-
This fits with the style for the rest of the project, but more importantly, makes life easier for bindings authors who auto-generate code.
joshaber committed -
When replacing an index with a new one, we need to iterate through all index entries in order to determine which entries are equal. When it is not possible to re-use old entries for the new index, we move it into a list of entries that are to be removed and thus free'd. When we encounter a non-zero error code, though, we skip adding the current index entry to the remove-queue. `INSERT_MAP_EX`, which is the function last run before adding to the remove-queue, may return a positive non-zero code that indicates what exactly happened while inserting the element. In this case we skip adding the entry to the remove-queue but still continue the current operation, leading to a leak of the current entry. Fix this by checking for a negative return value instead of a non-zero one when we want to add the current index entry to the remove-queue.
Patrick Steinhardt committed
-
- 06 Dec, 2015 3 commits
-
-
The trees are sorted on-disk, so we don't have to go over them again. This cuts almost a fifth of time spent parsing trees.
Carlos Martín Nieto committed -
CMakeLists: Compare CMAKE_SIZEOF_VOID_P as a number, not as a string
Carlos Martín Nieto committed -
checkout test: Apply umask to file-mode test as well
Carlos Martín Nieto committed
-
- 03 Dec, 2015 3 commits
-
-
tree: use a specialised mode parse function
Edward Thomson committed -
index: canonicalize inserted paths safely
Carlos Martín Nieto committed -
When adding to the index, we look to see if a portion of the given path matches a portion of a path in the index. If so, we will use the existing path information. For example, when adding `foo/bar.c`, if there is an index entry to `FOO/other` and the filesystem is case insensitive, then we will put `bar.c` into the existing tree instead of creating a new one with a different case. Use `strncmp` to do that instead of `memcmp`. When we `bsearch` into the index, we locate the position where the new entry would go. The index entry at that position does not necessarily have a relation to the entry we're adding, so we cannot make assumptions and use `memcmp`. Instead, compare them as strings. When canonicalizing paths, we look for the first index entry that matches a given substring.
Edward Thomson committed
-
- 02 Dec, 2015 2 commits
-
-
Instead of going out to strtol, which is made to parse generic numbers, copy a parse function from git which is specialised for file modes.
Carlos Martín Nieto committed -
Sebastian Schuberth committed
-
- 01 Dec, 2015 9 commits
-
-
Fix the file-mode test to expect system umask being applied to the created file as well (it is currently applied to the directory only). This fixes the test on systems where umask != 022. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Michał Górny committed -
Chris Hescock committed
-
tree: mark cloned tree entries as un-pooled
Edward Thomson committed -
When duplicating a `struct git_tree_entry` with `git_tree_entry_dup` the resulting structure is not allocated inside a memory pool. As we do a 1:1 copy of the original struct, though, we also copy the `pooled` field, which is set to `true` for pooled entries. This results in a huge memory leak as we never free tree entries that were duplicated from a pooled tree entry. Fix this by marking the newly duplicated entry as un-pooled.
Patrick Steinhardt committed -
When formatting a patch as email we do not include the commit's message in the formatted patch output. Implement this and add a test that verifies behavior.
Patrick Steinhardt committed -
It is already possible to get a commit's summary with the `git_commit_summary` function. It is not possible to get the remaining part of the commit message, that is the commit message's body. Fix this by introducing a new function `git_commit_body`.
Patrick Steinhardt committed -
The `git_blame__entry` struct keeps track of line counts with `int` fields. Since `int` is only guaranteed to be at least 16 bits we may overflow on certain platforms when line counts exceed 2^15. Fix this by instead storing line counts in `size_t`.
Patrick Steinhardt committed -
It is not unreasonable to have versioned files with a line count exceeding 2^16. Upon blaming such files we fail to correctly keep track of the lines as `git_blame_hunk` stores them in `uint16_t` fields. Fix this by converting the line fields of `git_blame_hunk` to `size_t`. Add test to verify behavior.
Patrick Steinhardt committed -
Improvements to tree parsing speed
Edward Thomson committed
-
- 30 Nov, 2015 5 commits
-
-
Compiler warning fixes
Carlos Martín Nieto committed -
Patrick Steinhardt committed
-
Patrick Steinhardt committed
-
Return an error in case the length is too big. Also take this opportunity to have a single allocating function for the size and overflow logic.
Carlos Martín Nieto committed -
Recursive Merge
Carlos Martín Nieto committed
-
- 28 Nov, 2015 4 commits
-
-
This reduces the size of the struct from 32 to 26 bytes, and leaves a single padding byte at the end of the struct (which comes from the zero-length array).
Carlos Martín Nieto committed -
We already know the size due to the `memchr()` so use that information instead of calling `strlen()` on it.
Carlos Martín Nieto committed -
These are rather small allocations, so we end up spending a non-trivial amount of time asking the OS for memory. Since these entries are tied to the lifetime of their tree, we can give the tree a pool so we speed up the allocations.
Carlos Martín Nieto committed -
We've already looked at the filename with `memchr()` and then used `strlen()` to allocate the entry. We already know how much we have to advance to get to the object id, so add the filename length instead of looking at each byte again.
Carlos Martín Nieto committed
-
- 25 Nov, 2015 1 commit
-
-
Edward Thomson committed
-