- 11 Nov, 2021 8 commits
-
-
There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics.
Edward Thomson committed -
Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly.
Edward Thomson committed -
path: refactor utility path functions
Edward Thomson committed -
Support checking for object existence without refresh
Edward Thomson committed -
Document that `git_odb` is thread-safe
Edward Thomson committed
-
- 10 Nov, 2021 1 commit
-
-
Commit 4ae41f9c made `git_odb` race-free, and added internal locking. Update `docs/threading.md` accordingly, so that APIs built atop libgit2 (e.g. language bindings) can count on this.
Josh Triplett committed
-
- 09 Nov, 2021 14 commits
-
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Edward Thomson committed
-
Teach `git_path_is_valid` to respect `core.longpaths`. Add helper methods to validate length and set the error message appropriately.
Edward Thomson committed -
Add a `git_str` based validity check; the existing `git_path_is_valid` defers to it.
Edward Thomson committed -
Edward Thomson committed
-
Edward Thomson committed
-
Provide a mechanism for users to limit the number of characters that are examined; `git_fs_path_str_is_valid` and friends will only examine up to `str->size` bytes. `git_fs_path_is_valid` delegates to these new functions by passing `SIZE_MAX` (instead of doing a `strlen`), which is a sentinel value meaning "look for a NUL terminator".
Edward Thomson committed -
Since we're returning a boolean about validation, the name is more properly "is valid".
Edward Thomson committed -
Since we're returning a boolean about validation, the name is more properly "is valid".
Edward Thomson committed -
Introduce `git_fs_path`, which operates on generic filesystem paths. `git_path` will be kept for only git-specific path functionality (for example, checking for `.git` in a path).
Edward Thomson committed -
ci: only update docs on push
Edward Thomson committed -
Only update the documentation on a `push`. We were previously updating the documentation only when not in a `pull_request`, which meant that we would push documentation updates in manual build triggers.
Edward Thomson committed
-
- 08 Nov, 2021 4 commits
-
-
To accommodate less capable compilers. Co-authored-by: Peter Pettersson <85582231+boretrk@users.noreply.github.com>
Josh Triplett committed -
Add optional refreshing in the fake backend, and count the number of refresh calls if enabled.
Josh Triplett committed -
Looking up a non-existent object currently always invokes `git_odb_refresh`. If looking up a large batch of objects, many of which may legitimately not exist, this will repeatedly refresh the ODB to no avail. Add a `git_odb_exists_ext` that accepts flags controlling the ODB lookup, and add a flag to suppress the refresh. This allows the user to control if and when they refresh (for instance, refreshing once before starting the batch).
Josh Triplett committed -
Commit b1a6c316 moved auto-refresh into the pack backend, and added a comment accordingly. Commit 43820f20 moved auto-refresh back *out* of backends into the ODB layer, but didn't update the comment.
Josh Triplett committed
-
- 28 Oct, 2021 2 commits
-
-
libgit2_clar is now libgit2_tests
Edward Thomson committed -
in #6083 the test runner was renamed to libgit2_tests, but not all references to the old name were updated. this change changes all of them to use the new name.
Martin Kühl committed
-
- 18 Oct, 2021 6 commits
-
-
cmake: cleanups and consistency
Edward Thomson committed -
Ensure that we always use lowercase function names, and that we do not have spaces preceding open parentheses, for consistency.
Edward Thomson committed -
The `STDCALL` option was removed; remove the (unreachable) error message.
Edward Thomson committed -
There's no need to make tracing opt-in; it should always be included.
Edward Thomson committed -
Edward Thomson committed
-
macOS may support ENABLE_REPRODUCIBLE_BUILDS, allow users to opt-in to it. (Especially since ENABLE_REPRODUCIBLE_BUILDS is not the default.)
Edward Thomson committed
-
- 17 Oct, 2021 5 commits
-
-
Edward Thomson committed
-
Nobody knows what CLAR is. The test building option should be `BUILD_TESTS`.
Edward Thomson committed -
`git_buf`: now a public-only API (`git_str` is our internal API)
Edward Thomson committed -
libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again.
Edward Thomson committed -
We have been inconsistent about the way that we handle `git_buf`s provided by users. _Usually_ we require that it has been properly initialized with `GIT_BUF_INIT`, but _sometimes_ we simply overwrite the data in it regardless. And even more rarely, we will grow a user-provided buffer and concatenate data onto it (see `git_diff_format_email`). Document the path forward for `git_buf`, which is that we always require that the buffer is intitialized with `GIT_BUF_INIT`. `git_diff_format_email` will be kept backward compatible but users are encouraged to switch to the new `git_email` APIs.
Edward Thomson committed
-