1. 23 Dec, 2021 2 commits
    • Merge pull request #6146 from Qix-/main · 734468d6
      cmake: use project-specific root variable instead of CMAKE_SOURCE_DIR
      Edward Thomson committed
    • cmake: use PROJECT_SOURCE_DIR of CMAKE_SOURCE_DIR · c5cd71b2
      Also applies to *_BINARY_DIR.
      
      This effectively reverts 84083dcc,
      which broke all users of libgit2 that use it as a CMake subdirectory
      (via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers
      to the root-most CMake directory, which in the case of
      `add_subdirectory()` is a parent project to libgit2 and thus the paths
      don't make any sense to the configuration files. Corollary,
      CMAKE_SOURCE_DIR only makes sense if the CMake project is always the
      root project - which can rarely be guaranteed.
      
      In all honesty, CMake should deprecate and eventually remove
      CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches
      and confusion for years, they're rarely useful over
      CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR,
      and they cause a lot of confusing configuration and source
      code layouts to boot.
      
      Any time they are used, they break `add_subdirectory()` almost 100% of
      the time, cause confusing error messages, and hide subtle bugs.
      Josh Junon committed
  2. 05 Dec, 2021 1 commit
  3. 01 Dec, 2021 3 commits
  4. 22 Nov, 2021 6 commits
  5. 19 Nov, 2021 3 commits
  6. 18 Nov, 2021 1 commit
  7. 17 Nov, 2021 5 commits
  8. 16 Nov, 2021 1 commit
  9. 15 Nov, 2021 4 commits
  10. 14 Nov, 2021 9 commits
  11. 12 Nov, 2021 2 commits
  12. 11 Nov, 2021 3 commits