1. 17 Oct, 2021 1 commit
    • str: introduce `git_str` for internal, `git_buf` is external · f0e693b1
      libgit2 has two distinct requirements that were previously solved by
      `git_buf`.  We require:
      
      1. A general purpose string class that provides a number of utility APIs
         for manipulating data (eg, concatenating, truncating, etc).
      2. A structure that we can use to return strings to callers that they
         can take ownership of.
      
      By using a single class (`git_buf`) for both of these purposes, we have
      confused the API to the point that refactorings are difficult and
      reasoning about correctness is also difficult.
      
      Move the utility class `git_buf` to be called `git_str`: this represents
      its general purpose, as an internal string buffer class.  The name also
      is an homage to Junio Hamano ("gitstr").
      
      The public API remains `git_buf`, and has a much smaller footprint.  It
      is generally only used as an "out" param with strict requirements that
      follow the documentation.  (Exceptions exist for some legacy APIs to
      avoid breaking callers unnecessarily.)
      
      Utility functions exist to convert a user-specified `git_buf` to a
      `git_str` so that we can call internal functions, then converting it
      back again.
      Edward Thomson committed
  2. 01 Dec, 2018 1 commit
  3. 13 Jul, 2018 1 commit
    • treewide: remove use of C++ style comments · 9994cd3f
      C++ style comment ("//") are not specified by the ISO C90 standard and
      thus do not conform to it. While libgit2 aims to conform to C90, we did
      not enforce it until now, which is why quite a lot of these
      non-conforming comments have snuck into our codebase. Do a tree-wide
      conversion of all C++ style comments to the supported C style comments
      to allow us enforcing strict C90 compliance in a later commit.
      Patrick Steinhardt committed
  4. 29 Jun, 2018 1 commit
  5. 10 Jun, 2018 1 commit
  6. 28 Jul, 2017 1 commit
    • tests: rebase::submodule: verify initialization method calls · c0558c62
      Some return codes for functions which may fail are not being checked in
      `test_rebase_submodule__initialize`. This may lead us to not notice
      errors when initializing the environment and would possibly result in
      either memory corruption or segfaults as soon as any of the
      initialization steps fails. Fix this by wrapping these function calls
      into `cl_git_pass`.
      Patrick Steinhardt committed
  7. 25 Jul, 2017 1 commit
  8. 03 Mar, 2017 1 commit
    • rebase: ignore untracked files in submodules · 2270ca9f
      An untracked file in a submodule should not prevent a rebase from
      starting.  Even if the submodule's SHA is changed, and that file would
      conflict with a new tracked file, it's still OK to start the rebase
      and discover the conflict later.
      
      Signed-off-by: David Turner <dturner@twosigma.com>
      David Turner committed